[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

[michellephung <gi...@git.apache.org>]

Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-111664404
  
    Hi,
    I opened a PR (https://github.com/wadsashika/couchdb-fauxton/pull/1) for grabbing the total docs in the source and target databases.
    
    There are some gaps I left open in the PR, that you should watch out for:
     - This will only be good for local DBs, so you will still have make a function in that case that the target/source is a remote database
    
     - I noticed that sometimes you can have more documents written than there are total in the source db, so the percentage will not really be accurate. Any ideas for how we might solve this one? We may have to rethink our strategy on this.
    
    - When I grab the task object in the store, I am only looking for the first object the list that matches the databaseName. But, in case you have a source name like 'def', and there exists 2 databases named 'abcdef', and 'defghi', you might grab data from the wrong source. You'll have to do some error handling here.
    
    - I left the source functions separate from the target functions for clarity, but you should combine them so that they are one function. They do the same thing.
    
    
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---