You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by gresockj <gi...@git.apache.org> on 2017/09/07 14:36:31 UTC
[GitHub] nifi pull request #2133: NIFI-4361: Fixing early recovery shutdown due to EO...
GitHub user gresockj opened a pull request:
https://github.com/apache/nifi/pull/2133
NIFI-4361: Fixing early recovery shutdown due to EOF in walog partition
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gresockj/nifi NIFI-4361
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2133
----
commit 7457228bcfa7a2ec862f5395983fc4c5c3032faf
Author: Joe Gresock <jo...@lmco.com>
Date: 2017-09-07T14:32:43Z
NIFI-4361: Fixing early recovery shutdown due to EOF in walog partition
----
---
[GitHub] nifi pull request #2133: NIFI-4361: Fixing early recovery shutdown due to EO...
Posted by gresockj <gi...@git.apache.org>.
Github user gresockj commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2133#discussion_r137839524
--- Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java ---
@@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo
subsequentTransactionId = nextPartition.getNextRecoverableTransactionId();
} catch (final IOException e) {
logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; "
- + "assuming crash and ignoring this transaction",
+ + "attempting to get the next recoverable transaction ID",
--- End diff --
I had a thought that this would be necessary, but I'm not sure what the ending condition would be. How would you determine that we've run out of recovery files?
---
[GitHub] nifi issue #2133: NIFI-4361: Fixing early recovery shutdown due to EOF in wa...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2133
@gresockj Sorry I must have not seen your comment on here. This PR has been around for quite a while. However, I wonder if https://github.com/apache/nifi/pull/2416 makes this no longer relevant? I recently implemented a new version of the write-ahead log due to an issue that was discovered (NIFI-4774). The new implementation actually avoids using multiple partitions at all so this, I believe, becomes a non-issue. If you agree, then is it okay for you to close the PR? If you don't agree, can you help me understand?
---
[GitHub] nifi pull request #2133: NIFI-4361: Fixing early recovery shutdown due to EO...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2133#discussion_r137837796
--- Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java ---
@@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo
subsequentTransactionId = nextPartition.getNextRecoverableTransactionId();
} catch (final IOException e) {
logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; "
- + "assuming crash and ignoring this transaction",
+ + "attempting to get the next recoverable transaction ID",
--- End diff --
@gresockj thanks for the contribution! The only concern that I have here is that this update assumes that we will never get more than 1 IOException in a row... I think we need to continue looping until we've run out of 'recovery files' for the partition.
---