You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/15 18:28:52 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
singhpk234 opened a new pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133
### About Change
Attribute exposes functions such as withNullability which can be used.
Incase of AttributeRef this is existing impl : [CodePointer](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala#L306-L312)
```
/**
* Returns a copy of this [[AttributeReference]] with changed nullability.
*/
override def withNullability(newNullability: Boolean): AttributeReference = {
if (nullable == newNullability) {
this
} else {
AttributeReference(name, dataType, newNullability, metadata)(exprId, qualifier)
}
}
```
As per my understanding, our intention was only to change nullablity we should use this rather than creating new AttributeRef obj
---
### Testing Done
ran TestMerge locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133#issuecomment-1065810728
@aokolnychyi, can you please take a pass ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133#issuecomment-1066145040
This looks good to me. It is slightly different, but I see no problem with keeping the original expression ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133#issuecomment-1042382801
@aokolnychyi can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 edited a comment on pull request #4133: Spark : use withNullability rather than creating new AttributeRef and losing ExprId, Qualifiers
Posted by GitBox <gi...@apache.org>.
singhpk234 edited a comment on pull request #4133:
URL: https://github.com/apache/iceberg/pull/4133#issuecomment-1065810728
@aokolnychyi, can you please take a pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org