[jira] [Commented] (AMBARI-18350) Declare URL uniqueness in repoinfo.xml

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478377#comment-15478377 ] 

Hadoop QA commented on AMBARI-18350:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827781/AMBARI-18350.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 54 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8627//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8627//console

This message is automatically generated.

> Declare URL uniqueness in repoinfo.xml
> --------------------------------------
>
>                 Key: AMBARI-18350
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18350
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: trunk
>
>         Attachments: AMBARI-18350.patch
>
>
> Repository info for a stack can contain any number of repo definitions.  For HDP, there are two repos used (HDP and HDP-UTILS).  When checking repositories for duplicate URL, the code does this:
> {noformat}
> if (! repositoryEntity.getRepositoryId().startsWith("HDP-UTILS") &&  // HDP-UTILS is shared between repo versions
> ! existingRepoVersion.getId().equals(repositoryVersion.getId())) { // Allow modifying already defined repo version
> existingRepoUrls.add(repositoryEntity.getBaseUrl());
> }
> {noformat}
> We should make the unique declaration directly for the repository so authors don't have to guess.  This entails:
> * Change {{repoinfo.xml}} to support a {{<unique>}} element within {{<repo>}}
> * {{<unique>}} should apply to, say, versions of HDP that change with each release.  Absence of said element implies {{false}} for backward compatibility.
> * Change {{RepositoryVersionResourceProvider.validateRepositoryVersion(...)}} to use this boolean for uniqueness check.
> * Update the {{version_definition.xsd}} to include this new element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)