You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by liufengdb <gi...@git.apache.org> on 2017/10/03 00:42:03 UTC

[GitHub] spark pull request #19394: [SPARK-22170][SQL] Reduce memory consumption in b...

Github user liufengdb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19394#discussion_r142290483
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
    @@ -280,13 +280,20 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with Logging with Serializ
         results.toArray
       }
     
    +  private[spark] def executeCollectIterator(): (Long, Iterator[InternalRow]) = {
    +    val countsAndBytes = getByteArrayRdd().collect()
    --- End diff --
    
    This still fetches all the compressed rows to the driver, before building the hashed relation. Ideally, you should fetch the rows from executors incrementally. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org