You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/10 15:33:36 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #72: drivers: serial: Fix a wrong variable in serial.c in SMP mode.

masayuki2009 opened a new pull request #72: drivers: serial: Fix a wrong variable in serial.c in SMP mode.
URL: https://github.com/apache/incubator-nuttx/pull/72
 
 
   ### Summary
   
   - During testing K210 (RV64GC) in SMP mode, I found a bug in drivers/serial/serial.c which I added code to avoid data corruption in the following commit. 
   
     commit dacd041a94b4150a90b401ef2098ae0015c7fa97
     Author: Masayuki Ishikawa <ma...@gmail.com>
     Date:   Wed Oct 16 13:09:03 2019 +0000
   
     Actually the variable 'flags' was override (i.e. destroyed) in uart_putxmitchar() and thus interrupt would be disabled. In this PR, I Introduced a new variable flags2 to avoid this bug.
   
   ### Impact
   
   - SMP systems which write to serial driver will be affected.
   
   ### Limitations / TODO
   
   -  No limitations
   
   ### Testing
   
   - I tested this PR with K210 and Spresense in SMP mode and finally smp app and ostest ostest app passed on both platforms!
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #72: drivers: serial: Fix a wrong variable in serial.c in SMP mode.

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #72: drivers: serial: Fix a wrong variable in serial.c in SMP mode.
URL: https://github.com/apache/incubator-nuttx/pull/72
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services