You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/21 07:41:20 UTC
[GitHub] [flink] rmetzger opened a new pull request, #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
rmetzger opened a new pull request, #19782:
URL: https://github.com/apache/flink/pull/19782
This is a small improvement to the "build from source" instructions, to use the maven wrapper, which will use the right maven version, avoiding various issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1326521295
@snuyanzin Thanks again for interrupting me.
What do you suggest to add to the `.m2/settings.xml` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1326552600
something like this
```
<settings>
<mirrors>
<mirror>
<id>conjars-https</id>
<url>https://conjars.org/repo/</url>
<mirrorOf>conjars</mirrorOf>
</mirror>
</mirrors>
</settings>
```
Initially it was suggested by Chesnay at https://issues.apache.org/jira/browse/FLINK-27640#comment-17539474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1361130485
Note: I've created https://github.com/apache/flink/pull/21529 to deal with the conjars issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a diff in pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
pnowojski commented on code in PR #19782:
URL: https://github.com/apache/flink/pull/19782#discussion_r882478708
##########
README.md:
##########
@@ -75,7 +75,7 @@ Prerequisites for building Flink:
```
git clone https://github.com/apache/flink.git
cd flink
-mvn clean package -DskipTests # this will take up to 10 minutes
+./mvnw clean package -DskipTests # this will take up to 15 minutes
Review Comment:
In all 3 of those files I would add a note +/-:
> Note usage of `mvnw` wrapper istead of mvn directly to ensure that the supported version of mvn will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1319705674
@rmetzger to make thing clear
> I see that @snuyanzin proposal has been merged in a different PR in the meantime.
NO, it was not merged, it was just closed in favor of this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1319718272
Oh, thanks a lot. Then I'll incorporate your changes and ping you again for a review ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1239155381
Probably also makes sense to add this to `docs/content/docs/flinkDev/ide_setup.md`
```
7. Set up maven home path to maven-wrapper.
Go to "File" → "Settings" → "Build,Execution,Deployment" → "Build Tools" → "Maven".
For "Maven home path" select "Use maven-wrapper".
8. Open the "Maven" tab (or right-click on the imported project and find "Maven") and run
"Generate Sources and Update Folders". Alternatively, you can run
`./mvnw clean package -DskipTests`.
9. Build the Project ("Build" → "Build Project").
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1319700756
Thanks for the approval. I see that @snuyanzin proposal has been merged in a different PR in the meantime. Sorry that I haven't been responsive on this PR.
I've rebased the PR. Once CI is happy, I'll merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19782:
URL: https://github.com/apache/flink/pull/19782#issuecomment-1133557747
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2c10b075ea58a57e150fc06bec054d8efea93760",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2c10b075ea58a57e150fc06bec054d8efea93760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c10b075ea58a57e150fc06bec054d8efea93760 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org