You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:42:36 UTC
[GitHub] [airflow] eladkal opened a new pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
eladkal opened a new pull request #17940:
URL: https://github.com/apache/airflow/pull/17940
1. Extract shared code to utils.
2. Allow any iterable as `week_day`.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#issuecomment-910023634
single mysql 5.7 test failed on timeout on tests not related to this PR.
merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#discussion_r699802753
##########
File path: airflow/utils/weekday.py
##########
@@ -45,3 +46,27 @@ def get_weekday_number(cls, week_day_str):
raise AttributeError(f'Invalid Week Day passed: "{week_day_str}"')
return cls[sanitized_week_day_str]
+
+ @classmethod
+ def convert(cls, day: Union[str, 'WeekDay']) -> int:
+ """Helper function that returns the day number in the week"""
+ if isinstance(day, WeekDay):
+ return day
+ return cls.get_weekday_number(week_day_str=day)
+
+ @classmethod
+ def validate_week_day(cls, day_iterable: Union[str, 'WeekDay', Set[str], List[str]]):
+ """Validate each item of iterable and create a set to ease compare of values"""
+ if not isinstance(day_iterable, Iterable):
+ if isinstance(day_iterable, WeekDay):
+ day_iterable = {day_iterable}
+ else:
+ raise TypeError(
+ "Unsupported Type for is_today parameter: {}."
+ "Input should be iterable type."
+ "str, set, list, dict or Weekday enum type".format(type(day_iterable))
Review comment:
```suggestion
"Unsupported Type for is_today parameter: {type(day_iterable)}. "
"Input should be iterable type: "
"str, set, list, dict or Weekday enum type"
```
nit:
- I think f-string here would be better as it locates closer to where it's actually used.
- I believe multi-lines strings are concatenated without the space between the sentences.
##########
File path: airflow/utils/weekday.py
##########
@@ -45,3 +46,27 @@ def get_weekday_number(cls, week_day_str):
raise AttributeError(f'Invalid Week Day passed: "{week_day_str}"')
return cls[sanitized_week_day_str]
+
+ @classmethod
+ def convert(cls, day: Union[str, 'WeekDay']) -> int:
+ """Helper function that returns the day number in the week"""
+ if isinstance(day, WeekDay):
+ return day
+ return cls.get_weekday_number(week_day_str=day)
+
+ @classmethod
+ def validate_week_day(cls, day_iterable: Union[str, 'WeekDay', Set[str], List[str]]):
+ """Validate each item of iterable and create a set to ease compare of values"""
+ if not isinstance(day_iterable, Iterable):
+ if isinstance(day_iterable, WeekDay):
+ day_iterable = {day_iterable}
+ else:
+ raise TypeError(
+ "Unsupported Type for is_today parameter: {}."
+ "Input should be iterable type."
+ "str, set, list, dict or Weekday enum type".format(type(day_iterable))
Review comment:
```suggestion
"Unsupported Type for is_today parameter: {type(day_iterable)}. "
"Input should be iterable type: "
"str, set, list, dict or Weekday enum type"
```
nit:
- I think f-string here would be better as it locates closer to where it's actually used.
- I believe multi-lines strings are concatenated without the space between the sentences, so we need to add them at the end for each line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#discussion_r699802753
##########
File path: airflow/utils/weekday.py
##########
@@ -45,3 +46,27 @@ def get_weekday_number(cls, week_day_str):
raise AttributeError(f'Invalid Week Day passed: "{week_day_str}"')
return cls[sanitized_week_day_str]
+
+ @classmethod
+ def convert(cls, day: Union[str, 'WeekDay']) -> int:
+ """Helper function that returns the day number in the week"""
+ if isinstance(day, WeekDay):
+ return day
+ return cls.get_weekday_number(week_day_str=day)
+
+ @classmethod
+ def validate_week_day(cls, day_iterable: Union[str, 'WeekDay', Set[str], List[str]]):
+ """Validate each item of iterable and create a set to ease compare of values"""
+ if not isinstance(day_iterable, Iterable):
+ if isinstance(day_iterable, WeekDay):
+ day_iterable = {day_iterable}
+ else:
+ raise TypeError(
+ "Unsupported Type for is_today parameter: {}."
+ "Input should be iterable type."
+ "str, set, list, dict or Weekday enum type".format(type(day_iterable))
Review comment:
```suggestion
"Unsupported Type for is_today parameter: {type(day_iterable)}. "
"Input should be iterable type: "
"str, set, list, dict or Weekday enum type"
```
nit:
- I think f-string here would be better as it locates closer to where it's actually used.
- I believe multi-lines strings are concatenated without the space between the sentences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#issuecomment-910023634
single mysql 5.7 test failed on timeout on tests not related to this PR.
merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#issuecomment-909210281
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#issuecomment-909210281
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #17940:
URL: https://github.com/apache/airflow/pull/17940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#issuecomment-909210281
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #17940:
URL: https://github.com/apache/airflow/pull/17940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #17940: Refactor BranchDayOfWeekOperator, DayOfWeekSensor
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #17940:
URL: https://github.com/apache/airflow/pull/17940#discussion_r699802753
##########
File path: airflow/utils/weekday.py
##########
@@ -45,3 +46,27 @@ def get_weekday_number(cls, week_day_str):
raise AttributeError(f'Invalid Week Day passed: "{week_day_str}"')
return cls[sanitized_week_day_str]
+
+ @classmethod
+ def convert(cls, day: Union[str, 'WeekDay']) -> int:
+ """Helper function that returns the day number in the week"""
+ if isinstance(day, WeekDay):
+ return day
+ return cls.get_weekday_number(week_day_str=day)
+
+ @classmethod
+ def validate_week_day(cls, day_iterable: Union[str, 'WeekDay', Set[str], List[str]]):
+ """Validate each item of iterable and create a set to ease compare of values"""
+ if not isinstance(day_iterable, Iterable):
+ if isinstance(day_iterable, WeekDay):
+ day_iterable = {day_iterable}
+ else:
+ raise TypeError(
+ "Unsupported Type for is_today parameter: {}."
+ "Input should be iterable type."
+ "str, set, list, dict or Weekday enum type".format(type(day_iterable))
Review comment:
```suggestion
"Unsupported Type for is_today parameter: {type(day_iterable)}. "
"Input should be iterable type: "
"str, set, list, dict or Weekday enum type"
```
nit:
- I think f-string here would be better as it locates closer to where it's actually used.
- I believe multi-lines strings are concatenated without the space between the sentences, so we need to add them at the end for each line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org