You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eric de Maulde (JIRA)" <ji...@apache.org> on 2011/03/16 02:05:29 UTC

[jira] Created: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Scaling image for every size type from ImageProperties.xml
----------------------------------------------------------

                 Key: OFBIZ-4217
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
             Project: OFBiz
          Issue Type: Improvement
          Components: framework, product, specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: trunk 1081272
            Reporter: Eric de Maulde
            Priority: Trivial
             Fix For: SVN trunk


With the new image management, there are more predefined image size types to upload an image.
The webmaster needs flexibility because each web site are different.
So, I believe the webmaster needs to customize image size type to scale uploaded images, according to his constraints.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010267#comment-13010267 ] 

Eric de Maulde commented on OFBIZ-4217:
---------------------------------------

Size type from ImageProperties.xml could be more flexible because all web sites are different and image dimensions are unique for each website.
So, I've integrated personal size type for my web site (See attached ImageProperties.xml)
Online result for image urls : http://www.fabiance.fr/meubles-de-jardin-hemisphere-editions/chaise-longue-transat-sol and http://www.fabiance.fr/chambre-sciae-agathe-40/lit-luminaires

What do you think about this flexible preconfigured image size types to automatically scale uploading original product image ?

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Attachment: ScalingImageForEverySizeType.patch

Sorry. The previous patch tries to save image dimensions but product entity doesn't contain fields.

This patch doesn't try to save image dimensions.

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Attachment: ScalingImageForEverySizeType.patch

This new patch includes too ImageTransform.java modifications in order to scale an image with only one configured dimension for size type.

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1082281
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Saroj Khamlue (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010594#comment-13010594 ] 

Saroj Khamlue commented on OFBIZ-4217:
--------------------------------------

I got the error when I chose "Original" and tried to upload image in product content page.

Exception: org.ofbiz.widget.screen.ScreenRenderException
Message: Error rendering screen [component://product/widget/catalog/ProductScreens.xml#EditProductContent]: java.lang.IllegalArgumentException: [GenericEntity.set] "imgHeight" is not a field of Product, must be one of: productId, productTypeId...

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Attachment: ScalingImageForEverySizeType.patch

This new patch includes too deleting of every old scaling image files, while a new image is uploading.

It works for images order by productId or size type.

It deletes every old related image files, even if its extension is different (jpeg, jpg, JPEG, JPG, png, PNG ...) to optimize disk space.

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1081272
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to upload an image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to scale uploaded images, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Attachment: ScalingImageForEverySizeType.patch

This patch allows to customize (decrease, increase, change name) image size type from ImageProperties.xml.
An uploading image is scaled to every configured image size type from properties.
It's very flexible.

This patch works only with image product content, not yet with the new image management.
I'm waiting for your decision to make more.

Problem : when a user uploads several additional images, there is a transaction time out !

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1081272
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to upload an image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to scale uploaded images, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Description: 
With the new image management, there are more predefined image size types to scale an uplaoding image.
The webmaster needs flexibility because each web site are different.
So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.


  was:
With the new image management, there are more predefined image size types to upload an image.
The webmaster needs flexibility because each web site are different.
So, I believe the webmaster needs to customize image size type to scale uploaded images, according to his constraints.


    Environment: trunk 1082281  (was: trunk 1081272)

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1082281
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Environment: trunk 1084574  (was: trunk 1082281)

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4217:
----------------------------------

    Attachment: ImageProperties.xml

My personnal image size types allow to display pre-sized images for the HTML/CSS code.
_ More faster
_ Images pixelate less
_ More flexible/personnal

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-4217.
------------------------------

    Resolution: Fixed

Committed revision 1085275.
Thanks for the patch!

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1084574
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to scale an uplaoding image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

Posted by "Eric de Maulde (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007306#comment-13007306 ] 

Eric de Maulde commented on OFBIZ-4217:
---------------------------------------

Furthermore, maybe it's enough to save in database only the original image (url ... height, width).
Then, through the image.filename.format and image.filename.additionalviewsize.format (from catalog.properties) developper builds the desired url with the image size type.

> Scaling image for every size type from ImageProperties.xml
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 1081272
>            Reporter: Eric de Maulde
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ScalingImageForEverySizeType.patch
>
>
> With the new image management, there are more predefined image size types to upload an image.
> The webmaster needs flexibility because each web site are different.
> So, I believe the webmaster needs to customize image size type to scale uploaded images, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira