You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crunch.apache.org by "Micah Whitacre (JIRA)" <ji...@apache.org> on 2016/07/29 21:54:20 UTC

[jira] [Commented] (CRUNCH-612) Add support of private constructors to Avros.reflect

    [ https://issues.apache.org/jira/browse/CRUNCH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400058#comment-15400058 ] 

Micah Whitacre commented on CRUNCH-612:
---------------------------------------

+1 Patch looks good and the build passes.  Will push to master.

> Add support of private constructors to Avros.reflect 
> -----------------------------------------------------
>
>                 Key: CRUNCH-612
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-612
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Clément MATHIEU
>            Assignee: Josh Wills
>         Attachments: CRUNCH-612.patch
>
>
> While Avro reflect supports private no-arg constructors since at least 1.4.0, see [this test case|https://gist.github.com/cykl/bf8936fca0410d0cea61402bf5b1e5f9], Crunch mandates this constructor to be public for deep copy. It seems like an unfortunate shortcoming rather than a conscious choice. 
> Since hiding the mandatory no-arg constructor can be quite useful to avoid API pollution, let's patch AvroDeepCopier to add support of private ctor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)