You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/27 03:32:58 UTC

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5699: [HUDI-4161] Make sure partition values are taken from partition path

alexeykudinkin commented on code in PR #5699:
URL: https://github.com/apache/hudi/pull/5699#discussion_r883243990


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -108,9 +108,6 @@ case class HoodieFileIndex(spark: SparkSession,
    * @return list of PartitionDirectory containing partition to base files mapping
    */
   override def listFiles(partitionFilters: Seq[Expression], dataFilters: Seq[Expression]): Seq[PartitionDirectory] = {
-    val convertedPartitionFilters =

Review Comment:
   This has to be removed since now there partition values are populated from partition path as is, and therefore users will have to query them as they are -- no conversion is needed therefore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org