You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/09/04 21:55:58 UTC

[GitHub] Juice10 opened a new pull request #327: move arrow to the anchor and nest the lists

Juice10 opened a new pull request #327: move arrow to the anchor and nest the lists
URL: https://github.com/apache/incubator-openwhisk-website/pull/327
 
 
   In PR: https://github.com/apache/incubator-openwhisk-website/pull/326 a bug crept in in versions of Chrome where the list image would push the block level anchor down on to the next line.
   ![image](https://user-images.githubusercontent.com/4106/45059685-d288c200-b06a-11e8-9245-e2ac3d8ebe2d.png)
   
   I've moved the display none/block toggle to css and I'm simply adding and removing the `collapsible-toggle-toggled` class to display/hide the nested list. `collapsible-toggle` now adds the arrow as the background of it's first child anchor. This is more reliable than the list-image that has different behavior in different browsers.
   
   As part of this fix I changed the #whiskIndex from being an id to a classname. A number of issues where popping up with specificity and I noticed that due to specificity we had a number of css attributes that where not doing anything. I suspect we might have more of those. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services