You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/07/26 20:39:28 UTC
[GitHub] brooklyn-server pull request #274: Load default exception mapper in web.xml
GitHub user grkvlt opened a pull request:
https://github.com/apache/brooklyn-server/pull/274
Load default exception mapper in web.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/brooklyn-server stop-404-error-log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit a1f995fa96043ea02ec3f9455fb35e2e4e4dd547
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date: 2016-07-26T03:00:12Z
Load default exception mapper in web.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
I thought you need this in tests (where web.xml is only used). For classic brooklyn that's added in BrooklynRestApi.getMiscResources() see also BrooklynRestApp.getProperties(). For Karaf in brooklyn-rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml:91.
Svet.
> On 29.07.2016 \u0433., at 3:54, Andrew Donald Kennedy <no...@github.com> wrote:
>
> @neykov <https://github.com/neykov> actually it doesn't work, it turns out. i think the idea is sound, but need to work out how Karaf is loading CXF and JAX:RS
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/brooklyn-server/pull/274#issuecomment-236075060>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADcdz8CNmcwKbyQA6MEob8640a4tkjX9ks5qaV1egaJpZM4JVkRB>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
@neykov actually it doesn't work, it turns out. i think the idea is sound, but need to work out how Karaf is loading CXF and JAX:RS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #274: Load default exception mapper in web.xml
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
Changes look good. Can be merged after removing the changes for `DefaultExceptionMapper.java`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
@neykov I removed the `import` lines in `DefaultExceptionMapper.java` so I'm going to merge now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
LGTM. Can you remove changes on DefaultExceptionMapper.java file then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/274
@neykov this is working now, generates 404 messages in `log/amp/debug/log` only now:
```
15:16:06,772 DEBUG 116 util.WebResourceUtils [qtp195664508-128] responding 404 Not Found (Application 'ga04h7dad6' not found)
15:16:06,772 DEBUG 116 util.WebResourceUtils [qtp195664508-132] responding 404 Not Found (Cannot find task 'OrnSCyAl')
15:16:06,778 DEBUG 116 util.DefaultExceptionMapper [qtp195664508-128] REST request running as WebEntitlementContext[guest@87.246.78.46:mdezL3] threw: javax.ws.rs.WebApplicationException: HTTP 404 Not Found
15:16:06,778 DEBUG 116 util.DefaultExceptionMapper [qtp195664508-132] REST request running as WebEntitlementContext[guest@87.246.78.46:Ch3UH1] threw: javax.ws.rs.WebApplicationException: HTTP 404 Not Found
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---