You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/06 10:43:59 UTC
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #55: add test case plugin on jdk17
wu-sheng commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744110904
##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,95 +32,44 @@
<artifactId>jvm-container</artifactId>
<name>SkyWalking JVM Runner Image</name>
- <profiles>
- <profile>
- <id>jdk8</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk8-${project.version}</name>
- <build>
- <from>openjdk:8u102</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>jdk14</id>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk14-${project.version}</name>
- <build>
- <from>openjdk:14-buster</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.33.0</version>
+ <configuration>
+ <images>
+ <image>
+ <name>skywalking/agent-test-jvm:jdk${java_major_version}-${project.version}</name>
+ <build>
+ <from>openjdk:${java_major_version}-buster</from>
Review comment:
Same here.
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-test.md
##########
@@ -20,17 +20,18 @@ The test framework provides `JVM-container` and `Tomcat-container` base images i
### JVM-container Image Introduction
-[JVM-container](../../../../../test/plugin/containers/jvm-container) uses `openjdk:8` as the base image. `JVM-container` supports JDK14, which inherits `openjdk:14`.
+[JVM-container](../../../../../test/plugin/containers/jvm-container) uses `openjdk:8-buster` as the base image. `JVM-container` supports JDK14 and JDK17, which inherits `openjdk:14-buster` and `openjdk:17-buster`.
Review comment:
What is buster suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org