[GitHub] [ozone] sky76093016 commented on a change in pull request #2297: HDDS-5286. Document SCM HA classes

[GitBox <gi...@apache.org>]

sky76093016 commented on a change in pull request #2297:
URL: https://github.com/apache/ozone/pull/2297#discussion_r644417592



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMDBCheckpointProvider.java
##########
@@ -31,6 +31,10 @@
 
 
 // TODO: define a generic interface for this
+
+/**
+ * Checkpoint write sream and exception handling.

Review comment:
       Solve it.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHANodeDetails.java
##########
@@ -60,6 +60,9 @@
 import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SECURITY_SERVICE_PORT_KEY;
 import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
 
+/**
+ * Construct SCM HA node details.

Review comment:
       Solve it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org