You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/13 19:20:32 UTC

[GitHub] [trafficserver] JosiahWI opened a new pull request, #9837: Convert esi tests to use Catch framework

JosiahWI opened a new pull request, #9837:
URL: https://github.com/apache/trafficserver/pull/9837

   The tests won't work in CMake Release mode because it passes -DNDEBUG which removes all the asserts. This change will ensure that the tests always run in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on pull request #9837: Convert esi tests to use Catch framework

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9837:
URL: https://github.com/apache/trafficserver/pull/9837#issuecomment-1589975112

   [approve ci Debian]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt merged pull request #9837: Convert esi tests to use Catch framework

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9837:
URL: https://github.com/apache/trafficserver/pull/9837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on pull request #9837: Convert esi tests to use Catch framework

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9837:
URL: https://github.com/apache/trafficserver/pull/9837#issuecomment-1590012688

   [approve ci cmake]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on pull request #9837: Convert esi tests to use Catch framework

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9837:
URL: https://github.com/apache/trafficserver/pull/9837#issuecomment-1589981619

   [approve ci cmake debian]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org