You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by Burton Rhodes <bu...@gmail.com> on 2023/07/13 14:06:40 UTC
Intellij Struts 2 Plugin for 6.x DTD
I have attempted to update the Intellij Struts 2 plugin to work with the
new 6.0 DTD xml structure. This is my first dive into Intellij plugins,
and to be honest, I'm not sure everything is working exactly as it is
supposed to. That said, the links from Action classes to the
corresponding struts xml files work when using the CTRL+click on the
class name - which is what I use most anyway. I've included a link to
the build/plugin ZIP file below. I am assuming that Intellij will not
accept my PR request anytime soon as there are several existing PRs
collecting dust.
If anyone has experience in Intellij plugins or wants to give some time
trying to make everything work, feel free to fork my repository.
Release with packaged plugin
https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
Forked Repository
https://github.com/burtonrhodes/intellij-obsolete-plugins
Thanks,
Burton
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Great. This is definitely the best solution moving forward.
------ Original Message ------
From "Lukasz Lenart" <lu...@apache.org>
To "Struts Users Mailing List" <us...@struts.apache.org>
Date 9/3/2023 4:57:44 AM
Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>Just to keep you in the loop - we are in touch with Jetbrains to
>donate the plugin to ASF :)
>
>sob., 26 sie 2023 o 15:50 Burton Rhodes <bu...@gmail.com> napisał(a):
>>
>> Nice. Sounds good.
>>
>>
>> ------ Original Message ------
>> From "Lukasz Lenart" <lu...@apache.org>
>> To "Struts Users Mailing List" <us...@struts.apache.org>
>> Date 8/26/2023 7:41:52 AM
>> Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>>
>> >sob., 26 sie 2023 o 14:09 Burton Rhodes <bu...@gmail.com> napisał(a):
>> >> Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
>> >
>> >I assume we can submit it as a new plugin to the Jetbrain marketplace
>> >https://plugins.jetbrains.com/docs/intellij/publishing-plugin.html
>> >
>> >
>> >Regards
>> >--
>> >Łukasz
>> >
>> >---------------------------------------------------------------------
>> >To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> >For additional commands, e-mail: user-help@struts.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
Just to keep you in the loop - we are in touch with Jetbrains to
donate the plugin to ASF :)
sob., 26 sie 2023 o 15:50 Burton Rhodes <bu...@gmail.com> napisał(a):
>
> Nice. Sounds good.
>
>
> ------ Original Message ------
> From "Lukasz Lenart" <lu...@apache.org>
> To "Struts Users Mailing List" <us...@struts.apache.org>
> Date 8/26/2023 7:41:52 AM
> Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>
> >sob., 26 sie 2023 o 14:09 Burton Rhodes <bu...@gmail.com> napisał(a):
> >> Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
> >
> >I assume we can submit it as a new plugin to the Jetbrain marketplace
> >https://plugins.jetbrains.com/docs/intellij/publishing-plugin.html
> >
> >
> >Regards
> >--
> >Łukasz
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> >For additional commands, e-mail: user-help@struts.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Nice. Sounds good.
------ Original Message ------
From "Lukasz Lenart" <lu...@apache.org>
To "Struts Users Mailing List" <us...@struts.apache.org>
Date 8/26/2023 7:41:52 AM
Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>sob., 26 sie 2023 o 14:09 Burton Rhodes <bu...@gmail.com> napisał(a):
>> Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
>
>I assume we can submit it as a new plugin to the Jetbrain marketplace
>https://plugins.jetbrains.com/docs/intellij/publishing-plugin.html
>
>
>Regards
>--
>Łukasz
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
sob., 26 sie 2023 o 14:09 Burton Rhodes <bu...@gmail.com> napisał(a):
> Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
I assume we can submit it as a new plugin to the Jetbrain marketplace
https://plugins.jetbrains.com/docs/intellij/publishing-plugin.html
Regards
--
Łukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
As far as I know, there are no references to other packages/modules from the /struts2 directory so copying it over to an isolated repository should work just fine.
Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
Thanks,
Burton
------ Original Message ------
From "Lukasz Lenart" <lu...@apache.org>
To "Struts Users Mailing List" <us...@struts.apache.org>
Date 8/26/2023 3:13:33 AM
Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>Finally circling back to this :)
>
>Thanks a lot Burton for all the explanations, I was planning to setup
>a new ASF repository struts-idea and copy your code into it. I wonder
>if I can drop all other plugins and just have the Struts plugin. As
>far as I know the plugin uses Apache 2.0 license so we can make any
>changes we want to release under the ASF umbrella. I assume we just
>need this to be copied:
>
>https://github.com/burtonrhodes/intellij-obsolete-plugins/tree/master/struts2
>
>Let me know what you think
>
>Best regards
>Łukasz
>
>niedz., 30 lip 2023 o 17:53 Burton Rhodes <bu...@gmail.com> napisał(a):
>>
>> Lukasz,
>> Many thanks. I think putting this under the Struts umbrella is a good
>> idea. Feel free to copy or fork my code here:
>>https://github.com/burtonrhodes/intellij-obsolete-plugins
>>
>> Yann Cebron at Intellij didn't like my package refactor in my original
>> update, so in order to remove all the noise from my forked master branch, I
>> did a hard update removing several commits. I also reverted back to the
>> original bumped Struts Plugin v2023.2.1. I realize this really isn't the
>> "correct" way to do this, but it will give us a clean slate to move forward
>> with.
>>
>> My latest version should work with intellij 232.x. I am currently using
>> intellij v232.8660.185 and everything is working fine. Let me know if this
>> is not the case for you. You can download the latest build here:
>>https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
>>
>> Lastly, I closed my PR request to the upstream branch because of Yann's two
>> requirements (https://github.com/JetBrains/intellij-obsolete-plugins/pull/11
>> ).
>> 1) Undo package refactor for the "main/java/com/intellij/struts2/ognl"
>> directory.
>> - I'm still confused about this since none of the class package names match
>> the directory structure. Even the associated tests are in the correct
>> "test/java/com/intellij/lang/ognl" directory. One or the other, IMHO,
>> should be refactored.
>>
>> 2) Implement tests for the new 6.0 DTD.
>> - I am unable to do this since I can't figure out how to get past an
>> IllegalAccessError when running tests as described here:
>>https://github.com/JetBrains/intellij-obsolete-plugins/pull/11#issuecomment-1646868223
>>
>> #1 is solved in my current release. However, with #2 I am stuck. If you
>> can figure out how to implement some tests, the PR would be accepted and
>> patched into the Intellij Plugin Repository which would be ideal.
>>
>> Thanks,
>> Burton
>>
>> On Sun, Jul 30, 2023 at 12:57 AM Lukasz Lenart <lu...@apache.org>
>> wrote:
>>
>> > czw., 13 lip 2023 o 19:11 Burton Rhodes <bu...@gmail.com>
>> > napisał(a):
>> > >
>> > > Apologies for the additional email, but I believe this latest version is
>> > > working properly:
>> > >
>> > https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
>> > >
>> > > I welcome any feedback.
>> >
>> > Thanks a lot Burton for taking care of this, nicely done! I wonder if
>> > we should bring the plugin under the ASF umbrella as part of the
>> > Struts project?
>> >
>> > Could you upgrade the plugin to be compatible with IDEA build 232.x?
>> > > Incompatible: requires IDE build 231.* or earlier
>> >
>> >
>> > Regards
>> > --
>> > Łukasz
>> > + 48 606 323 122 http://www.lenart.org.pl/
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> > For additional commands, e-mail: user-help@struts.apache.org
>> >
>> >
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
I finally managed to figure out what was wrong and now the very first
PR is ready
https://github.com/apache/struts-intellij-plugin/pull/1
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
I started working on IP Clearance procedure and prepared a simple GH
Actions workflow (among other things), yet some tests are failing and
I wonder if this can be related to my changes
https://github.com/apache/struts-intellij-plugin/pull/1
Running locally I get:
[ 1623] WARN - #c.i.o.v.n.p.l.VfsLog - VFS Log version differs
from the implementation version: log null vs implementation -43
[ 1988] WARN - #c.i.u.n.s.ConfirmingTrustManager - Received an
empty list of custom trusted root certificates from the system. Check
log above for possible errors, enable debug logging in category
'org.jetbrains.nativecerts' for more information
9:34:54 AM: failed on iteration 1 (use
`recheckingIteration(3201180346085451506L, 1)` or
`withSeed(3201180346085451506L)` to reproduce), shrinking...
09:34:54,050 SEVERE #TestFramework - Test failed
org.jetbrains.jetCheck.PropertyFalsified: Failed with
org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot satisfy
condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
On commands:<none>
The failure is not reproducible on re-run!!! Possible cause: side
effects in the test.
To re-run the minimal failing case, run
PropertyChecker.customized().rechecking("0ILnxgXym5XmDQE=")
.checkScenarios(...)
To re-run the test with all intermediate shrinking steps, use
`recheckingIteration(3201180346085451506L, 1)` instead for last
iteration, or `withSeed(3201180346085451506L)` for all iterations
Property failure reason:
org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot satisfy
condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
at org.jetbrains.jetCheck.GenerativeDataStructure.generateConditional(GenerativeDataStructure.java:68)
at org.jetbrains.jetCheck.Generator.lambda$suchThat$3(Generator.java:101)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generateNonShrinkable(GenerativeDataStructure.java:52)
at org.jetbrains.jetCheck.Generator.lambda$noShrink$2(Generator.java:83)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generate(GenerativeDataStructure.java:40)
at org.jetbrains.jetCheck.Scenario.safeGenerate(Scenario.java:102)
at org.jetbrains.jetCheck.Scenario.access$200(Scenario.java:14)
at org.jetbrains.jetCheck.Scenario$1.generateValue(Scenario.java:61)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$19(MadTestingUtil.java:284)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.common.RunAllKt.runAllCatching(runAll.kt:61)
at com.intellij.testFramework.common.RunAllKt.runAll(runAll.kt:32)
at com.intellij.testFramework.RunAll.run(RunAll.kt:21)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$24(MadTestingUtil.java:301)
at org.jetbrains.jetCheck.Scenario.performCommand(Scenario.java:43)
at org.jetbrains.jetCheck.Scenario.<init>(Scenario.java:23)
at org.jetbrains.jetCheck.Scenario.lambda$scenarios$0(Scenario.java:138)
at org.jetbrains.jetCheck.Iteration.findCounterExample(Iteration.java:61)
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:118)
at org.jetbrains.jetCheck.CheckSession.run(Iteration.java:166)
at org.jetbrains.jetCheck.PropertyChecker$Parameters.checkScenarios(PropertyChecker.java:200)
at org.jetbrains.jetCheck.PropertyChecker.checkScenarios(PropertyChecker.java:31)
at com.intellij.lang.ognl.OgnlCodeInsightSanityTest.testIncrementalHighlighterUpdate(OgnlCodeInsightSanityTest.java:76)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$11(UsefulTestCase.java:477)
at com.intellij.testFramework.UsefulTestCase.lambda$wrapTestRunnable$13(UsefulTestCase.java:498)
at com.intellij.testFramework.UsefulTestCase.runTestRunnable(UsefulTestCase.java:402)
at com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:418)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:485)
at com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:788)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:731)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:758)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:302)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
==========================
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:121)
at org.jetbrains.jetCheck.CheckSession.run(Iteration.java:166)
at org.jetbrains.jetCheck.PropertyChecker$Parameters.checkScenarios(PropertyChecker.java:200)
at org.jetbrains.jetCheck.PropertyChecker.checkScenarios(PropertyChecker.java:31)
at com.intellij.lang.ognl.OgnlCodeInsightSanityTest.testIncrementalHighlighterUpdate(OgnlCodeInsightSanityTest.java:76)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$11(UsefulTestCase.java:477)
at com.intellij.testFramework.UsefulTestCase.lambda$wrapTestRunnable$13(UsefulTestCase.java:498)
at com.intellij.testFramework.UsefulTestCase.runTestRunnable(UsefulTestCase.java:402)
at com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:418)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:485)
at com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:788)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:731)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:758)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:302)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
Caused by: org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot
satisfy condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
at org.jetbrains.jetCheck.GenerativeDataStructure.generateConditional(GenerativeDataStructure.java:68)
at org.jetbrains.jetCheck.Generator.lambda$suchThat$3(Generator.java:101)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generateNonShrinkable(GenerativeDataStructure.java:52)
at org.jetbrains.jetCheck.Generator.lambda$noShrink$2(Generator.java:83)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generate(GenerativeDataStructure.java:40)
at org.jetbrains.jetCheck.Scenario.safeGenerate(Scenario.java:102)
at org.jetbrains.jetCheck.Scenario.access$200(Scenario.java:14)
at org.jetbrains.jetCheck.Scenario$1.generateValue(Scenario.java:61)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$19(MadTestingUtil.java:284)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.common.RunAllKt.runAllCatching(runAll.kt:61)
at com.intellij.testFramework.common.RunAllKt.runAll(runAll.kt:32)
at com.intellij.testFramework.RunAll.run(RunAll.kt:21)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$24(MadTestingUtil.java:301)
at org.jetbrains.jetCheck.Scenario.performCommand(Scenario.java:43)
at org.jetbrains.jetCheck.Scenario.<init>(Scenario.java:23)
at org.jetbrains.jetCheck.Scenario.lambda$scenarios$0(Scenario.java:138)
at org.jetbrains.jetCheck.Iteration.findCounterExample(Iteration.java:61)
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:118)
... 29 more
org.jetbrains.jetCheck.PropertyFalsified: Failed with
org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot satisfy
condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
On commands:<none>
The failure is not reproducible on re-run!!! Possible cause: side
effects in the test.
To re-run the minimal failing case, run
PropertyChecker.customized().rechecking("0ILnxgXym5XmDQE=")
.checkScenarios(...)
To re-run the test with all intermediate shrinking steps, use
`recheckingIteration(3201180346085451506L, 1)` instead for last
iteration, or `withSeed(3201180346085451506L)` for all iterations
Property failure reason:
org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot satisfy
condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
at org.jetbrains.jetCheck.GenerativeDataStructure.generateConditional(GenerativeDataStructure.java:68)
at org.jetbrains.jetCheck.Generator.lambda$suchThat$3(Generator.java:101)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generateNonShrinkable(GenerativeDataStructure.java:52)
at org.jetbrains.jetCheck.Generator.lambda$noShrink$2(Generator.java:83)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generate(GenerativeDataStructure.java:40)
at org.jetbrains.jetCheck.Scenario.safeGenerate(Scenario.java:102)
at org.jetbrains.jetCheck.Scenario.access$200(Scenario.java:14)
at org.jetbrains.jetCheck.Scenario$1.generateValue(Scenario.java:61)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$19(MadTestingUtil.java:284)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.common.RunAllKt.runAllCatching(runAll.kt:61)
at com.intellij.testFramework.common.RunAllKt.runAll(runAll.kt:32)
at com.intellij.testFramework.RunAll.run(RunAll.kt:21)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$24(MadTestingUtil.java:301)
at org.jetbrains.jetCheck.Scenario.performCommand(Scenario.java:43)
at org.jetbrains.jetCheck.Scenario.<init>(Scenario.java:23)
at org.jetbrains.jetCheck.Scenario.lambda$scenarios$0(Scenario.java:138)
at org.jetbrains.jetCheck.Iteration.findCounterExample(Iteration.java:61)
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:118)
at org.jetbrains.jetCheck.CheckSession.run(Iteration.java:166)
at org.jetbrains.jetCheck.PropertyChecker$Parameters.checkScenarios(PropertyChecker.java:200)
at org.jetbrains.jetCheck.PropertyChecker.checkScenarios(PropertyChecker.java:31)
at com.intellij.lang.ognl.OgnlCodeInsightSanityTest.testIncrementalHighlighterUpdate(OgnlCodeInsightSanityTest.java:76)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$11(UsefulTestCase.java:477)
at com.intellij.testFramework.UsefulTestCase.lambda$wrapTestRunnable$13(UsefulTestCase.java:498)
at com.intellij.testFramework.UsefulTestCase.runTestRunnable(UsefulTestCase.java:402)
at com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:418)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:485)
at com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:788)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:731)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:758)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:302)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
==========================
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:121)
at org.jetbrains.jetCheck.CheckSession.run(Iteration.java:166)
at org.jetbrains.jetCheck.PropertyChecker$Parameters.checkScenarios(PropertyChecker.java:200)
at org.jetbrains.jetCheck.PropertyChecker.checkScenarios(PropertyChecker.java:31)
at com.intellij.lang.ognl.OgnlCodeInsightSanityTest.testIncrementalHighlighterUpdate(OgnlCodeInsightSanityTest.java:76)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$11(UsefulTestCase.java:477)
at com.intellij.testFramework.UsefulTestCase.lambda$wrapTestRunnable$13(UsefulTestCase.java:498)
at com.intellij.testFramework.UsefulTestCase.runTestRunnable(UsefulTestCase.java:402)
at com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:418)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:485)
at com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:788)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:731)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:758)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:302)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
Caused by: org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot
satisfy condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
at org.jetbrains.jetCheck.GenerativeDataStructure.generateConditional(GenerativeDataStructure.java:68)
at org.jetbrains.jetCheck.Generator.lambda$suchThat$3(Generator.java:101)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generateNonShrinkable(GenerativeDataStructure.java:52)
at org.jetbrains.jetCheck.Generator.lambda$noShrink$2(Generator.java:83)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generate(GenerativeDataStructure.java:40)
at org.jetbrains.jetCheck.Scenario.safeGenerate(Scenario.java:102)
at org.jetbrains.jetCheck.Scenario.access$200(Scenario.java:14)
at org.jetbrains.jetCheck.Scenario$1.generateValue(Scenario.java:61)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$19(MadTestingUtil.java:284)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.common.RunAllKt.runAllCatching(runAll.kt:61)
at com.intellij.testFramework.common.RunAllKt.runAll(runAll.kt:32)
at com.intellij.testFramework.RunAll.run(RunAll.kt:21)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$24(MadTestingUtil.java:301)
at org.jetbrains.jetCheck.Scenario.performCommand(Scenario.java:43)
at org.jetbrains.jetCheck.Scenario.<init>(Scenario.java:23)
at org.jetbrains.jetCheck.Scenario.lambda$scenarios$0(Scenario.java:138)
at org.jetbrains.jetCheck.Iteration.findCounterExample(Iteration.java:61)
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:118)
... 29 more
Cannot satisfy condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
org.jetbrains.jetCheck.CannotSatisfyCondition: Cannot satisfy
condition can find a file under
/Users/lukaszlenart/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIU/2023.1.1/e45081dc718ef8d79831d3bf759d70fd0dc451c1/ideaIU-2023.1.1/contrib/struts2/ognl/testData/
satisfying given filters
at org.jetbrains.jetCheck.GenerativeDataStructure.generateConditional(GenerativeDataStructure.java:68)
at org.jetbrains.jetCheck.Generator.lambda$suchThat$3(Generator.java:101)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generateNonShrinkable(GenerativeDataStructure.java:52)
at org.jetbrains.jetCheck.Generator.lambda$noShrink$2(Generator.java:83)
at org.jetbrains.jetCheck.GenerativeDataStructure$CurrentData.generateOn(GenerativeDataStructure.java:86)
at org.jetbrains.jetCheck.GenerativeDataStructure.generate(GenerativeDataStructure.java:40)
at org.jetbrains.jetCheck.Scenario.safeGenerate(Scenario.java:102)
at org.jetbrains.jetCheck.Scenario.access$200(Scenario.java:14)
at org.jetbrains.jetCheck.Scenario$1.generateValue(Scenario.java:61)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$19(MadTestingUtil.java:284)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.RunAll$Companion$actionSequence$1$1.invoke(RunAll.kt:70)
at com.intellij.testFramework.common.RunAllKt.runAllCatching(runAll.kt:61)
at com.intellij.testFramework.common.RunAllKt.runAll(runAll.kt:32)
at com.intellij.testFramework.RunAll.run(RunAll.kt:21)
at com.intellij.testFramework.propertyBased.MadTestingUtil.lambda$performOnFileContents$24(MadTestingUtil.java:301)
at org.jetbrains.jetCheck.Scenario.performCommand(Scenario.java:43)
at org.jetbrains.jetCheck.Scenario.<init>(Scenario.java:23)
at org.jetbrains.jetCheck.Scenario.lambda$scenarios$0(Scenario.java:138)
at org.jetbrains.jetCheck.Iteration.findCounterExample(Iteration.java:61)
at org.jetbrains.jetCheck.Iteration.performIteration(Iteration.java:118)
at org.jetbrains.jetCheck.CheckSession.run(Iteration.java:166)
at org.jetbrains.jetCheck.PropertyChecker$Parameters.checkScenarios(PropertyChecker.java:200)
at org.jetbrains.jetCheck.PropertyChecker.checkScenarios(PropertyChecker.java:31)
at com.intellij.lang.ognl.OgnlCodeInsightSanityTest.testIncrementalHighlighterUpdate(OgnlCodeInsightSanityTest.java:76)
at java.base@17.0.6/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at java.base@17.0.6/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base@17.0.6/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base@17.0.6/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$11(UsefulTestCase.java:477)
at com.intellij.testFramework.UsefulTestCase.lambda$wrapTestRunnable$13(UsefulTestCase.java:498)
at com.intellij.testFramework.UsefulTestCase.runTestRunnable(UsefulTestCase.java:402)
at com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:418)
at com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:485)
at com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:788)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:731)
at java.base@17.0.6/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base@17.0.6/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:758)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:302)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Good to hear. I made some hasty changes to make the plug-in "work" with
newer versions of IntelliJ, but to be honest, I was never able to get
the tests to run. Additionally, the latest update to IntelliJ's SDK
(v1.15.0 -> v 1.16.x) deprecated/removed quite a few methods. My fork
is here [1], but I would suggest you probably start from original
repository.
[1] https://github.com/burtonrhodes/intellij-obsolete-plugins
Thanks,
Burton
------ Original Message ------
From "Lukasz Lenart" <lu...@apache.org>
To "Struts Users Mailing List" <us...@struts.apache.org>
Date 2/26/2024 1:25:18 AM
Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>Finally all is set, the code has been donated & imported and also the
>plugin has been transferred under ASF org
>https://plugins.jetbrains.com/organizations/apache
>
>Time to get familiar with the code base :D
>
>Cheers
>Lukasz
>
>wt., 6 lut 2024 o 10:24 Lukasz Lenart <lu...@apache.org> napisał(a):
>>
>> Code has been donated to ASF, I created a new repo [1], yet I have to
>> import the code [2]
>>
>> [1] https://github.com/apache/struts-intellij-plugin
>> [2] https://github.com/JetBrains/intellij-obsolete-plugins/tree/master/struts2
>>
>>
>> Cheers
>> Lukasz
>>
>> sob., 30 gru 2023 o 10:57 Lukasz Lenart <lu...@apache.org> napisał(a):
>> >
>> > pt., 22 gru 2023 o 14:49 Burton Rhodes <bu...@gmail.com> napisał(a):
>> > >
>> > > Lukasz,
>> > > It appears the Struts 2 Intellij Plugin needs to be updated after
>> > > upgrading to Intellij 2023.3. I am happy to help bump the version
>> > > numbers, but I'm not sure where the Struts repository is for this
>> > > plugin. I know you were going to create one after I upgraded the last
>> > > version. Can you point me in the right direction so I can create a PR?
>> >
>> > Thanks Burton for bringing this to my attention as I totally forgot
>> > about this. I requested donation of the plugin code to ASF but I
>> > didn't get a positive response yet, I will ping them again :)
>> >
>> >
>> > Cheers
>> > Łukasz
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
Finally all is set, the code has been donated & imported and also the
plugin has been transferred under ASF org
https://plugins.jetbrains.com/organizations/apache
Time to get familiar with the code base :D
Cheers
Lukasz
wt., 6 lut 2024 o 10:24 Lukasz Lenart <lu...@apache.org> napisał(a):
>
> Code has been donated to ASF, I created a new repo [1], yet I have to
> import the code [2]
>
> [1] https://github.com/apache/struts-intellij-plugin
> [2] https://github.com/JetBrains/intellij-obsolete-plugins/tree/master/struts2
>
>
> Cheers
> Lukasz
>
> sob., 30 gru 2023 o 10:57 Lukasz Lenart <lu...@apache.org> napisał(a):
> >
> > pt., 22 gru 2023 o 14:49 Burton Rhodes <bu...@gmail.com> napisał(a):
> > >
> > > Lukasz,
> > > It appears the Struts 2 Intellij Plugin needs to be updated after
> > > upgrading to Intellij 2023.3. I am happy to help bump the version
> > > numbers, but I'm not sure where the Struts repository is for this
> > > plugin. I know you were going to create one after I upgraded the last
> > > version. Can you point me in the right direction so I can create a PR?
> >
> > Thanks Burton for bringing this to my attention as I totally forgot
> > about this. I requested donation of the plugin code to ASF but I
> > didn't get a positive response yet, I will ping them again :)
> >
> >
> > Cheers
> > Łukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
Code has been donated to ASF, I created a new repo [1], yet I have to
import the code [2]
[1] https://github.com/apache/struts-intellij-plugin
[2] https://github.com/JetBrains/intellij-obsolete-plugins/tree/master/struts2
Cheers
Lukasz
sob., 30 gru 2023 o 10:57 Lukasz Lenart <lu...@apache.org> napisał(a):
>
> pt., 22 gru 2023 o 14:49 Burton Rhodes <bu...@gmail.com> napisał(a):
> >
> > Lukasz,
> > It appears the Struts 2 Intellij Plugin needs to be updated after
> > upgrading to Intellij 2023.3. I am happy to help bump the version
> > numbers, but I'm not sure where the Struts repository is for this
> > plugin. I know you were going to create one after I upgraded the last
> > version. Can you point me in the right direction so I can create a PR?
>
> Thanks Burton for bringing this to my attention as I totally forgot
> about this. I requested donation of the plugin code to ASF but I
> didn't get a positive response yet, I will ping them again :)
>
>
> Cheers
> Łukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
pt., 22 gru 2023 o 14:49 Burton Rhodes <bu...@gmail.com> napisał(a):
>
> Lukasz,
> It appears the Struts 2 Intellij Plugin needs to be updated after
> upgrading to Intellij 2023.3. I am happy to help bump the version
> numbers, but I'm not sure where the Struts repository is for this
> plugin. I know you were going to create one after I upgraded the last
> version. Can you point me in the right direction so I can create a PR?
Thanks Burton for bringing this to my attention as I totally forgot
about this. I requested donation of the plugin code to ASF but I
didn't get a positive response yet, I will ping them again :)
Cheers
Łukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Lukasz,
It appears the Struts 2 Intellij Plugin needs to be updated after
upgrading to Intellij 2023.3. I am happy to help bump the version
numbers, but I'm not sure where the Struts repository is for this
plugin. I know you were going to create one after I upgraded the last
version. Can you point me in the right direction so I can create a PR?
Thanks,
Burton
------ Original Message ------
From "Burton Rhodes" <bu...@gmail.com>
To "Struts Users Mailing List" <us...@struts.apache.org>; "Struts Users
Mailing List" <us...@struts.apache.org>
Date 8/26/2023 7:06:23 AM
Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>As far as I know, there are no references to other packages/modules from the /struts2 directory so copying it over to an isolated repository should work just fine.
>
>Curious... with a separate repository, how would you submit a PR to intellij with an updated version? Do you think they review/accept a version from another repository or would you have to copy code over to the "intellij-obsolete-plugins" repository prior to submitting for every update?
>
>Thanks,
>Burton
>
>------ Original Message ------
>From "Lukasz Lenart" <lu...@apache.org>
>To "Struts Users Mailing List" <us...@struts.apache.org>
>Date 8/26/2023 3:13:33 AM
>Subject Re: Intellij Struts 2 Plugin for 6.x DTD
>
>>Finally circling back to this :)
>>
>>Thanks a lot Burton for all the explanations, I was planning to setup
>>a new ASF repository struts-idea and copy your code into it. I wonder
>>if I can drop all other plugins and just have the Struts plugin. As
>>far as I know the plugin uses Apache 2.0 license so we can make any
>>changes we want to release under the ASF umbrella. I assume we just
>>need this to be copied:
>>
>>https://github.com/burtonrhodes/intellij-obsolete-plugins/tree/master/struts2
>>
>>Let me know what you think
>>
>>Best regards
>>Łukasz
>>
>>niedz., 30 lip 2023 o 17:53 Burton Rhodes <bu...@gmail.com> napisał(a):
>>>
>>> Lukasz,
>>> Many thanks. I think putting this under the Struts umbrella is a good
>>> idea. Feel free to copy or fork my code here:
>>>https://github.com/burtonrhodes/intellij-obsolete-plugins
>>>
>>> Yann Cebron at Intellij didn't like my package refactor in my original
>>> update, so in order to remove all the noise from my forked master branch, I
>>> did a hard update removing several commits. I also reverted back to the
>>> original bumped Struts Plugin v2023.2.1. I realize this really isn't the
>>> "correct" way to do this, but it will give us a clean slate to move forward
>>> with.
>>>
>>> My latest version should work with intellij 232.x. I am currently using
>>> intellij v232.8660.185 and everything is working fine. Let me know if this
>>> is not the case for you. You can download the latest build here:
>>>https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
>>>
>>> Lastly, I closed my PR request to the upstream branch because of Yann's two
>>> requirements (https://github.com/JetBrains/intellij-obsolete-plugins/pull/11
>>> ).
>>> 1) Undo package refactor for the "main/java/com/intellij/struts2/ognl"
>>> directory.
>>> - I'm still confused about this since none of the class package names match
>>> the directory structure. Even the associated tests are in the correct
>>> "test/java/com/intellij/lang/ognl" directory. One or the other, IMHO,
>>> should be refactored.
>>>
>>> 2) Implement tests for the new 6.0 DTD.
>>> - I am unable to do this since I can't figure out how to get past an
>>> IllegalAccessError when running tests as described here:
>>>https://github.com/JetBrains/intellij-obsolete-plugins/pull/11#issuecomment-1646868223
>>>
>>> #1 is solved in my current release. However, with #2 I am stuck. If you
>>> can figure out how to implement some tests, the PR would be accepted and
>>> patched into the Intellij Plugin Repository which would be ideal.
>>>
>>> Thanks,
>>> Burton
>>>
>>> On Sun, Jul 30, 2023 at 12:57 AM Lukasz Lenart <lu...@apache.org>
>>> wrote:
>>>
>>> > czw., 13 lip 2023 o 19:11 Burton Rhodes <bu...@gmail.com>
>>> > napisał(a):
>>> > >
>>> > > Apologies for the additional email, but I believe this latest version is
>>> > > working properly:
>>> > >
>>> > https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
>>> > >
>>> > > I welcome any feedback.
>>> >
>>> > Thanks a lot Burton for taking care of this, nicely done! I wonder if
>>> > we should bring the plugin under the ASF umbrella as part of the
>>> > Struts project?
>>> >
>>> > Could you upgrade the plugin to be compatible with IDEA build 232.x?
>>> > > Incompatible: requires IDE build 231.* or earlier
>>> >
>>> >
>>> > Regards
>>> > --
>>> > Łukasz
>>> > + 48 606 323 122 http://www.lenart.org.pl/
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>>> > For additional commands, e-mail: user-help@struts.apache.org
>>> >
>>> >
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>>For additional commands, e-mail: user-help@struts.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
Finally circling back to this :)
Thanks a lot Burton for all the explanations, I was planning to setup
a new ASF repository struts-idea and copy your code into it. I wonder
if I can drop all other plugins and just have the Struts plugin. As
far as I know the plugin uses Apache 2.0 license so we can make any
changes we want to release under the ASF umbrella. I assume we just
need this to be copied:
https://github.com/burtonrhodes/intellij-obsolete-plugins/tree/master/struts2
Let me know what you think
Best regards
Łukasz
niedz., 30 lip 2023 o 17:53 Burton Rhodes <bu...@gmail.com> napisał(a):
>
> Lukasz,
> Many thanks. I think putting this under the Struts umbrella is a good
> idea. Feel free to copy or fork my code here:
> https://github.com/burtonrhodes/intellij-obsolete-plugins
>
> Yann Cebron at Intellij didn't like my package refactor in my original
> update, so in order to remove all the noise from my forked master branch, I
> did a hard update removing several commits. I also reverted back to the
> original bumped Struts Plugin v2023.2.1. I realize this really isn't the
> "correct" way to do this, but it will give us a clean slate to move forward
> with.
>
> My latest version should work with intellij 232.x. I am currently using
> intellij v232.8660.185 and everything is working fine. Let me know if this
> is not the case for you. You can download the latest build here:
> https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
>
> Lastly, I closed my PR request to the upstream branch because of Yann's two
> requirements (https://github.com/JetBrains/intellij-obsolete-plugins/pull/11
> ).
> 1) Undo package refactor for the "main/java/com/intellij/struts2/ognl"
> directory.
> - I'm still confused about this since none of the class package names match
> the directory structure. Even the associated tests are in the correct
> "test/java/com/intellij/lang/ognl" directory. One or the other, IMHO,
> should be refactored.
>
> 2) Implement tests for the new 6.0 DTD.
> - I am unable to do this since I can't figure out how to get past an
> IllegalAccessError when running tests as described here:
> https://github.com/JetBrains/intellij-obsolete-plugins/pull/11#issuecomment-1646868223
>
> #1 is solved in my current release. However, with #2 I am stuck. If you
> can figure out how to implement some tests, the PR would be accepted and
> patched into the Intellij Plugin Repository which would be ideal.
>
> Thanks,
> Burton
>
> On Sun, Jul 30, 2023 at 12:57 AM Lukasz Lenart <lu...@apache.org>
> wrote:
>
> > czw., 13 lip 2023 o 19:11 Burton Rhodes <bu...@gmail.com>
> > napisał(a):
> > >
> > > Apologies for the additional email, but I believe this latest version is
> > > working properly:
> > >
> > https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
> > >
> > > I welcome any feedback.
> >
> > Thanks a lot Burton for taking care of this, nicely done! I wonder if
> > we should bring the plugin under the ASF umbrella as part of the
> > Struts project?
> >
> > Could you upgrade the plugin to be compatible with IDEA build 232.x?
> > > Incompatible: requires IDE build 231.* or earlier
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> > For additional commands, e-mail: user-help@struts.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Lukasz,
Many thanks. I think putting this under the Struts umbrella is a good
idea. Feel free to copy or fork my code here:
https://github.com/burtonrhodes/intellij-obsolete-plugins
Yann Cebron at Intellij didn't like my package refactor in my original
update, so in order to remove all the noise from my forked master branch, I
did a hard update removing several commits. I also reverted back to the
original bumped Struts Plugin v2023.2.1. I realize this really isn't the
"correct" way to do this, but it will give us a clean slate to move forward
with.
My latest version should work with intellij 232.x. I am currently using
intellij v232.8660.185 and everything is working fine. Let me know if this
is not the case for you. You can download the latest build here:
https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
Lastly, I closed my PR request to the upstream branch because of Yann's two
requirements (https://github.com/JetBrains/intellij-obsolete-plugins/pull/11
).
1) Undo package refactor for the "main/java/com/intellij/struts2/ognl"
directory.
- I'm still confused about this since none of the class package names match
the directory structure. Even the associated tests are in the correct
"test/java/com/intellij/lang/ognl" directory. One or the other, IMHO,
should be refactored.
2) Implement tests for the new 6.0 DTD.
- I am unable to do this since I can't figure out how to get past an
IllegalAccessError when running tests as described here:
https://github.com/JetBrains/intellij-obsolete-plugins/pull/11#issuecomment-1646868223
#1 is solved in my current release. However, with #2 I am stuck. If you
can figure out how to implement some tests, the PR would be accepted and
patched into the Intellij Plugin Repository which would be ideal.
Thanks,
Burton
On Sun, Jul 30, 2023 at 12:57 AM Lukasz Lenart <lu...@apache.org>
wrote:
> czw., 13 lip 2023 o 19:11 Burton Rhodes <bu...@gmail.com>
> napisał(a):
> >
> > Apologies for the additional email, but I believe this latest version is
> > working properly:
> >
> https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
> >
> > I welcome any feedback.
>
> Thanks a lot Burton for taking care of this, nicely done! I wonder if
> we should bring the plugin under the ASF umbrella as part of the
> Struts project?
>
> Could you upgrade the plugin to be compatible with IDEA build 232.x?
> > Incompatible: requires IDE build 231.* or earlier
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Lukasz Lenart <lu...@apache.org>.
czw., 13 lip 2023 o 19:11 Burton Rhodes <bu...@gmail.com> napisał(a):
>
> Apologies for the additional email, but I believe this latest version is
> working properly:
> https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
>
> I welcome any feedback.
Thanks a lot Burton for taking care of this, nicely done! I wonder if
we should bring the plugin under the ASF umbrella as part of the
Struts project?
Could you upgrade the plugin to be compatible with IDEA build 232.x?
> Incompatible: requires IDE build 231.* or earlier
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Intellij Struts 2 Plugin for 6.x DTD
Posted by Burton Rhodes <bu...@gmail.com>.
Apologies for the additional email, but I believe this latest version is
working properly:
https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.2
I welcome any feedback.
Thanks,
Burton
------ Original Message ------
From "Burton Rhodes" <bu...@gmail.com>
To "Struts Users Mailing List" <us...@struts.apache.org>
Date 7/13/2023 9:06:40 AM
Subject Intellij Struts 2 Plugin for 6.x DTD
>I have attempted to update the Intellij Struts 2 plugin to work with
>the new 6.0 DTD xml structure. This is my first dive into Intellij
>plugins, and to be honest, I'm not sure everything is working exactly
>as it is supposed to. That said, the links from Action classes to the
>corresponding struts xml files work when using the CTRL+click on the
>class name - which is what I use most anyway. I've included a link to
>the build/plugin ZIP file below. I am assuming that Intellij will not
>accept my PR request anytime soon as there are several existing PRs
>collecting dust.
>
>If anyone has experience in Intellij plugins or wants to give some time
>trying to make everything work, feel free to fork my repository.
>
>Release with packaged plugin
>https://github.com/burtonrhodes/intellij-obsolete-plugins/releases/tag/v2023.2.1
>
>Forked Repository
>https://github.com/burtonrhodes/intellij-obsolete-plugins
>
>Thanks,
>Burton
>
>
>
>
>