[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #31887: Adapt Notifier for sla_miss_callback

["utkarsharma2 (via GitHub)" <gi...@apache.org>]

utkarsharma2 commented on code in PR #31887:
URL: https://github.com/apache/airflow/pull/31887#discussion_r1229552851


##########
airflow/dag_processing/processor.py:
##########
@@ -530,7 +530,13 @@ def manage_slas(cls, dag_folder, dag_id: str, session: Session = NEW_SESSION) ->
                 for callback in callbacks:
                     cls.logger().info("Calling SLA miss callback %s", callback)
                     try:
-                        callback(dag, task_list, blocking_task_list, slas, blocking_tis)
+                        callback(
+                            dag=dag,
+                            task_list=task_list,
+                            blocking_task_list=blocking_task_list,
+                            slas=slas,
+                            blocking_tis=blocking_tis,
+                        )

Review Comment:
   @ephraimbuddy I have updated a testcase to ensure we are calling the `sla_callback` with the correct set of parameters in the following [commit](https://github.com/apache/airflow/pull/31887/commits/37108da7ea2de9ecf3c0d5d85946f581efae8313). 
   
   However, when I updated the dag with the function you provided, I'm not seeing any output in the scheduler/webserver component. Are those the right places to see the log?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org