You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "architjainjain (via GitHub)" <gi...@apache.org> on 2026/03/05 11:20:16 UTC

[PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

architjainjain opened a new pull request, #6349:
URL: https://github.com/apache/hive/pull/6349

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   upgrading commons-lang3 to 3.17.0 which is at the same level of hadoop
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   To remove older version of commons-lang3 and making it to most achievable version parallel to hadoop.
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   ### How was this patch tested?
   local build and CI
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "architjainjain (via GitHub)" <gi...@apache.org>.
architjainjain commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4004374031

   Dependency tree
   [Uploading after.txt…]()
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "architjainjain (via GitHub)" <gi...@apache.org>.
architjainjain commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4044900790

   @zabetak Thanks!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4007189797

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "architjainjain (via GitHub)" <gi...@apache.org>.
architjainjain commented on code in PR #6349:
URL: https://github.com/apache/hive/pull/6349#discussion_r2916937286


##########
iceberg/iceberg-shading/pom.xml:
##########
@@ -43,6 +43,12 @@
       <groupId>org.apache.iceberg</groupId>
       <artifactId>iceberg-data</artifactId>
       <optional>true</optional>
+      <exclusions>
+        <exclusion>
+          <groupId>org.apache.commons</groupId>
+          <artifactId>commons-lang3</artifactId>
+        </exclusion>
+      </exclusions>

Review Comment:
   @zabetak made the required changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #6349:
URL: https://github.com/apache/hive/pull/6349#discussion_r2911403099


##########
iceberg/iceberg-shading/pom.xml:
##########
@@ -43,6 +43,12 @@
       <groupId>org.apache.iceberg</groupId>
       <artifactId>iceberg-data</artifactId>
       <optional>true</optional>
+      <exclusions>
+        <exclusion>
+          <groupId>org.apache.commons</groupId>
+          <artifactId>commons-lang3</artifactId>
+        </exclusion>
+      </exclusions>

Review Comment:
   We shouldn't rely on exclusions to get the correct version. The right path forward is to declare the dependency in the `dependencyManagement` section in top level `pom.xml` files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak merged PR #6349:
URL: https://github.com/apache/hive/pull/6349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4038104813

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4004741380

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6349&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6349&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6349&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6349)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29387:upgrade commons-lang3 to 3.17.x [hive]

Posted by "architjainjain (via GitHub)" <gi...@apache.org>.
architjainjain commented on PR #6349:
URL: https://github.com/apache/hive/pull/6349#issuecomment-4037683773

   After making changes using the dependency management. Attaching before and after dep-tree.
   ### Before
   [dep-before.txt](https://github.com/user-attachments/files/25896505/dep-before.txt)
   | Module Name | Resolved Version |
   | :--- | :--- |
   | Hive Storage API | 3.17.0 |
   | Hive Shims Common | 3.12.0 |
   | Hive Shims | 3.17.0 |
   | Hive Shims (Duplicate) | 3.12.0 |
   | Hive Standalone Metastore Common Code | 3.14.0 |
   | Hive Common | 3.14.0 |
   | Hive Service RPC | 3.12.0 |
   | Hive Serde | 3.14.0 |
   | Hive Metastore Client | 3.14.0 |
   | Hive Metastore Server | 3.14.0 |
   | Hive Metastore | 3.14.0 |
   | Hive Parser | 3.14.0 |
   | Hive UDF | 3.14.0 |
   | Hive Llap Common | 3.14.0 |
   | Hive Llap Client | 3.14.0 |
   | Hive Llap Tez | 3.14.0 |
   | Hive Query Language | 3.14.0 |
   | Hive Llap Server | 3.14.0 |
   | Hive HPL/SQL | 3.14.0 |
   | Hive Service | 3.14.0 |
   | Hive Accumulo Handler | 3.14.0 |
   | Hive JDBC | 3.12.0 |
   | Hive Beeline | 3.14.0 |
   | Hive CLI | 3.14.0 |
   | Hive Contrib | 3.14.0 |
   | Hive Druid Handler | 3.14.0 |
   | Hive HBase Handler | 3.14.0 |
   | Hive JDBC Handler | 3.14.0 |
   | Hive HCatalog | 3.17.0 |
   | Hive HCatalog Core | 3.14.0 |
   | Hive HCatalog Pig Adapter | 3.17.0 |
   | Hive HCatalog Server Extensions | 3.17.0 |
   | Hive HCatalog Webhcat Java Client | 3.14.0 |
   | Hive HCatalog Webhcat | 3.17.0 |
   | Hive Streaming | 3.14.0 |
   | Hive Llap External Client | 3.14.0 |
   | Hive Kudu Handler | 3.14.0 |
   | Hive Iceberg Modules | 3.17.0 |
   | Hive Iceberg Shading | 3.12.0 |
   | Hive Iceberg Catalog | 3.14.0 |
   | Hive Iceberg Handler | 3.14.0 |
   | Hive Kafka Storage Handler | 3.14.0 |
   | Hive Metastore REST Catalog | 3.14.0 |
   | Hive Packaging | 3.14.0 |
   | Hive Metastore Tools common libraries | 3.14.0 |
   | Hive metastore benchmarks | 3.14.0 |
   | Hive Metastore Packaging | 3.14.0 |
   
   
   ### After
   [dep-after.txt](https://github.com/user-attachments/files/25896551/dep-after.txt)
   | Module Name | Resolved Version |
   | :--- | :--- |
   | Hive Storage API | 3.17.0 |
   | Hive Shims Common | 3.17.0 |
   | Hive Shims | 3.17.0 |
   | Hive Standalone Metastore Common Code | 3.17.0 |
   | Hive Common | 3.17.0 |
   | Hive Service RPC | 3.17.0 |
   | Hive Serde | 3.17.0 |
   | Hive Metastore Client | 3.17.0 |
   | Hive Metastore Server | 3.17.0 |
   | Hive Metastore | 3.17.0 |
   | Hive Parser | 3.17.0 |
   | Hive UDF | 3.17.0 |
   | Hive Llap Common | 3.17.0 |
   | Hive Llap Client | 3.17.0 |
   | Hive Llap Tez | 3.17.0 |
   | Hive Query Language | 3.17.0 |
   | Hive Llap Server | 3.17.0 |
   | Hive HPL/SQL | 3.17.0 |
   | Hive Service | 3.17.0 |
   | Hive Accumulo Handler | 3.17.0 |
   | Hive JDBC | 3.17.0 |
   | Hive Beeline | 3.17.0 |
   | Hive CLI | 3.17.0 |
   | Hive Contrib | 3.17.0 |
   | Hive Druid Handler | 3.17.0 |
   | Hive HBase Handler | 3.17.0 |
   | Hive JDBC Handler | 3.17.0 |
   | Hive HCatalog | 3.17.0 |
   | Hive HCatalog Core | 3.17.0 |
   | Hive HCatalog Pig Adapter | 3.17.0 |
   | Hive HCatalog Server Extensions | 3.17.0 |
   | Hive HCatalog Webhcat Java Client | 3.17.0 |
   | Hive HCatalog Webhcat | 3.17.0 |
   | Hive Streaming | 3.17.0 |
   | Hive Llap External Client | 3.17.0 |
   | Hive Kudu Handler | 3.17.0 |
   | Hive Iceberg Modules | 3.17.0 |
   | Hive Iceberg Shading | 3.17.0 |
   | Hive Iceberg Catalog | 3.17.0 |
   | Hive Iceberg Handler | 3.17.0 |
   | Hive Kafka Storage Handler | 3.17.0 |
   | Hive Metastore REST Catalog | 3.17.0 |
   | Hive Packaging | 3.17.0 |
   | Hive Metastore Tools common libraries | 3.17.0 |
   | Hive metastore benchmarks | 3.17.0 |
   | Hive Metastore Packaging | 3.17.0 |
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org