You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "javanna (via GitHub)" <gi...@apache.org> on 2023/08/10 14:50:58 UTC
[GitHub] [lucene] javanna opened a new pull request, #12499: Simplify task executor for concurrent operations
javanna opened a new pull request, #12499:
URL: https://github.com/apache/lucene/pull/12499
Based on the proposal in #12498, this PR removes the QueueSizeBasedExecutor (package private) in favour of simply offloading concurrent execution to the provided executor. In need of specific behaviour, it can all be included in the executor itself.
This removes an instanceof check that determines which type of executor wrapper is used, which means that some tasks may be executed on the caller thread depending on queue size, whenever a rejection happens, or always for the last slice. This behaviour is not configurable in any way, and is too rigid. Rather than making this pluggable, I propose to make Lucene less opinionated about concurrent tasks execution and require that users include their own execution strategy directly in the executor that they provide to the index searcher.
Relates to #12498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1687122736
@sohami here it is: #12515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] reta commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1682819596
@sohami fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] sohami commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "sohami (via GitHub)" <gi...@apache.org>.
sohami commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1683053853
> @sohami fyi
Thanks @reta for tagging me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1682812371
Thanks for looking @reta ! i plan on merging this soon, if anyone else would like to review, please go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna merged pull request #12499: Simplify task executor for concurrent operations
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna merged PR #12499:
URL: https://github.com/apache/lucene/pull/12499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1686951882
Thanks all for looking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] sohami commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "sohami (via GitHub)" <gi...@apache.org>.
sohami commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1683057195
@javanna For single slice case are we thinking to leave it as is or change that as well to offload to the provided `executor` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #12499: Simplify task executor for concurrent operations
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12499:
URL: https://github.com/apache/lucene/pull/12499#issuecomment-1686902882
@sohami I will open a follow-up to offload single slices too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org