You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Russell E Glaue (Created) (JIRA)" <ji...@apache.org> on 2012/02/23 18:46:48 UTC
[jira] [Created] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
------------------------------------------------------------------------
Key: GERONIMO-6286
URL: https://issues.apache.org/jira/browse/GERONIMO-6286
Project: Geronimo
Issue Type: Sub-task
Security Level: public (Regular issues)
Affects Versions: 3.0-beta-1
Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
Reporter: Russell E Glaue
There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
- framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
- framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
- framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Russell E Glaue (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell E Glaue updated GERONIMO-6286:
--------------------------------------
Attachment: geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
Modifies:
- framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
- framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
- framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Labels: geronimo
> Attachments: geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Forrest Xia (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia reassigned GERONIMO-6286:
-------------------------------------
Assignee: Forrest Xia
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Assignee: Forrest Xia
> Labels: geronimo
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Forrest Xia (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia resolved GERONIMO-6286.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0-beta-2
3.0
3.0-beta@1295402, 3.0 trunk@1295406
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Assignee: Forrest Xia
> Labels: geronimo
> Fix For: 3.0, 3.0-beta-2
>
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Russell E Glaue (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell E Glaue updated GERONIMO-6286:
--------------------------------------
Attachment: geronimo-6286-BaseJava-StartServer-StartClient.patch
geronimo-6286-BaseJava-StartServer-StartClient.patch
Modifies:
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
Please review this patch.
I thought it best to keep this one simple and require the user to specify the full path for the org.apache.geronimo.server.dir if they wish to define it.
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Labels: geronimo
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Russell E Glaue (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216636#comment-13216636 ]
Russell E Glaue commented on GERONIMO-6286:
-------------------------------------------
No I did not test. The first patch I am not able to test the SSL, but it was just a path change. I did not know how the code in the second patch was used in Geronimo. It was a little more involved, So I split the patches and asked for it to be reviewed. I should have specifically asked for it to be ”tested”. Sorry.
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Assignee: Forrest Xia
> Labels: geronimo
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6286) o.a.g.server.dir should be used
instead of o.a.g.home.dir in misc places
Posted by "Forrest Xia (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215364#comment-13215364 ]
Forrest Xia commented on GERONIMO-6286:
---------------------------------------
They looks good to me, thank you very much for the patches.
Want to know if you did some testing with those patches?
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Labels: geronimo
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (GERONIMO-6286) o.a.g.server.dir
should be used instead of o.a.g.home.dir in misc places
Posted by "Russell E Glaue (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215028#comment-13215028 ]
Russell E Glaue edited comment on GERONIMO-6286 at 2/23/12 8:37 PM:
--------------------------------------------------------------------
geronimo-6286-BaseJava-StartServer-StartClient.patch
Modifies:
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/BaseJavaCommand.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
Please review this patch.
I thought it best to keep this one simple and require the user to specify the full path for the org.apache.geronimo.server.dir if they wish to define it.
was (Author: rglaue):
geronimo-6286-BaseJava-StartServer-StartClient.patch
Modifies:
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
Please review this patch.
I thought it best to keep this one simple and require the user to specify the full path for the org.apache.geronimo.server.dir if they wish to define it.
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
> Key: GERONIMO-6286
> URL: https://issues.apache.org/jira/browse/GERONIMO-6286
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Affects Versions: 3.0-beta-1
> Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 (Tikanga); Java JDK1.6.0_25
> Reporter: Russell E Glaue
> Labels: geronimo
> Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when instead they should ideally be using org.apache.geronimo.server.dir .
> - framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira