You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Lohit Vijayarenu (JIRA)" <ji...@apache.org> on 2008/07/02 22:54:45 UTC

[jira] Created: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Hadoop dfs metric FilesListed shows number of files listed instead of operations
--------------------------------------------------------------------------------

                 Key: HADOOP-3683
                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
             Project: Hadoop Core
          Issue Type: Bug
          Components: dfs, metrics
    Affects Versions: 0.18.0
            Reporter: Lohit Vijayarenu


Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610106#action_12610106 ] 

Hadoop QA commented on HADOOP-3683:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12385158/HADOOP-Metricsfix-3.patch
  against trunk revision 673517.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2787/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2787/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2787/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2787/console

This message is automatically generated.

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Reviewed, Incompatible change])
          Status: Patch Available  (was: Open)

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3683:
---------------------------------

    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Incompatible change])

+1.

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Attachment: HADOOP-Metricsfix-3-19.patch

Same patch against for 0.19

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3-19.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624793#action_12624793 ] 

Hudson commented on HADOOP-3683:
--------------------------------

Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3-19.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Affects Version/s:     (was: 0.18.0)
                       0.17.1
        Fix Version/s: 0.18.0
             Assignee: Lohit Vijayarenu
         Release Note: Change FileListed to getNumGetListingOps and add CreateFileOps, DeleteFileOps and AddBlockOps metrics. 
         Hadoop Flags: [Incompatible change]

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Attachment: HADOOP-Metricsfix-3.patch

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3683:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Reviewed, Incompatible change])
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Lohit

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3-19.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Attachment: HADOOP-Metricsfix.patch

Updated patch with changed names as suggested by Raghu. 

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.18.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Attachment: HADOOP-Metricsfix.patch

Attached patch fixes this
- changed FilesListed to FilesListedOps
- added FilesCreatedOps, FilesDeletedOps and AddBlockOps

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.18.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3683:
-------------------------------------

    Attachment: HADOOP-Metricsfix-2.patch

I had renamed a public API. This attached patch deprecates it following the release process. 

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.18.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3683) Hadoop dfs metric FilesListed shows number of files listed instead of operations

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610386#action_12610386 ] 

Lohit Vijayarenu commented on HADOOP-3683:
------------------------------------------

    [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

Tested test-patch locally for the patch against 0.19

> Hadoop dfs metric FilesListed shows number of files listed instead of operations
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-3683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, metrics
>    Affects Versions: 0.17.1
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-Metricsfix-2.patch, HADOOP-Metricsfix-3-19.patch, HADOOP-Metricsfix-3.patch, HADOOP-Metricsfix.patch, HADOOP-Metricsfix.patch
>
>
> Hadoop dfs metric FilesListed shows number of files listed, it should be number of fileListing operations instead. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.