[jira] [Commented] (SAMZA-1516) Another round of issues found by BEAM tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269562#comment-16269562 ] 

ASF GitHub Bot commented on SAMZA-1516:
---------------------------------------

GitHub user xinyuiscool opened a pull request:

    https://github.com/apache/samza/pull/370

    SAMZA-1516: Another round of issues found by BEAM tests

    A couple of more fixes: 1. fix a bug of identifying input streams for an operator. 2. for partitionBy, set the partitionKey to 0L when key is null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xinyuiscool/samza SAMZA-1516

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #370
    
----
commit a888ec5052138a7cdc66d948505b5917f62cefb7
Author: xiliu <xi...@xiliu-ld1.linkedin.biz>
Date:   2017-11-28T22:05:24Z

    SAMZA-1516: Another round of issues found by BEAM tests

----


> Another round of issues found by BEAM tests
> -------------------------------------------
>
>                 Key: SAMZA-1516
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1516
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Xinyu Liu
>            Assignee: Xinyu Liu
>             Fix For: 0.14.0
>
>
> A couple of more fixes:
> 1. fix a bug of identifying input streams for an operator. The logic is inside the traversal of operator graph inside OperatorImplGraph. Basically we need to traverse further to add the input stream to the operator even the operator is already created.
> 2. for partitionBy, right now if there is null key and null partition key, Kafka will do round-robin. This is causing problems for BEAM reduce. Since BEAM assume records without key will go to a single reducer. Add a fix in partitonBy to set the partitionKey.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)