You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/03 19:19:00 UTC
[jira] [Work logged] (BEAM-11087) [Go SDK] Validate Side Input
behavior WRT windows
[ https://issues.apache.org/jira/browse/BEAM-11087?focusedWorklogId=674871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674871 ]
ASF GitHub Bot logged work on BEAM-11087:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/21 19:18
Start Date: 03/Nov/21 19:18
Worklog Time Spent: 10m
Work Description: lostluck merged pull request #15871:
URL: https://github.com/apache/beam/pull/15871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 674871)
Time Spent: 3h (was: 2h 50m)
> [Go SDK] Validate Side Input behavior WRT windows
> --------------------------------------------------
>
> Key: BEAM-11087
> URL: https://issues.apache.org/jira/browse/BEAM-11087
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Fix For: 2.35.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> DoFns with Side inputs implicitly observe windows, as Side Inputs are scoped to a current window, a powerful feature of beam.
> The ideal would be to you could try to unit test this in the exec package, creating a fake side input adapter (or use the real one), to more directly target the implementation.
> [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/sideinput.go#L34] and exercising the ParDo code for Side Input handling directly.
> [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/pardo.go#L38]
> Then it should be possible to bolster that with appropriate mock windows to ensure that side inputs are configured correctly.
> Altnernatively this behavior could be tested and validated with an integration test against real runners due to the complexity around Side Inputs making unit testing a challenge. (While side input code could be tested in that fashion, it's likely dramatically simpler to do the integration test.)
> Some light tests with Side Inputs already exist, but they're purely in the Global Window. Add tests for non-global windows to ensure that Side Inputs are scoped correctly.
> Integration test directory: [https://github.com/apache/beam/tree/master/sdks/go/test/integration/primitives]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)