You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/11/25 10:34:03 UTC
[GitHub] [commons-vfs] JanAelb opened a new pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
JanAelb opened a new pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222
There is an issue when parsing urls containing backslashes in Http4FileSystem and derived classes.
https://issues.apache.org/jira/browse/VFS-810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] JanAelb closed pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
Posted by GitBox <gi...@apache.org>.
JanAelb closed pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222#issuecomment-979263867
-1 as the string in the example `"http4://alice\\1234:secret@localhost:80"` is not an RFC compliant URI, neither in [RFC 2396](https://datatracker.ietf.org/doc/html/rfc2396) or [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986).
The problem is two-fold though, the above, plus the fact that there is a long-standing issue within VFS where we incorrectly handle percent-encoded values.
If in the above you meant to escape the a single `\` character then then URL should be `"http4://alice%5C1234:secret@localhost:80"`; but, that seems to cause problems within VFS, so that's what needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] JanAelb commented on pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
Posted by GitBox <gi...@apache.org>.
JanAelb commented on pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222#issuecomment-979787104
Thank you 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] JanAelb commented on pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
Posted by GitBox <gi...@apache.org>.
JanAelb commented on pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222#issuecomment-979346404
Thank you for the quick response.
Passing `"http4://alice%5C1234:secret@localhost:80"` is indeed the problem I want to handle. I updated the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #222: VFS-810: Use different UriBuilder for Http4FileSystem
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #222:
URL: https://github.com/apache/commons-vfs/pull/222#issuecomment-979380307
I have a possible fix in the guts of VFS, stay tuned... This PR is still not the best path IMO because it only deals with a single provider, does not solve the general problem, and adds a dependency on yet another library which happens to be used to test Hadoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org