You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2017/04/12 07:56:01 UTC
[GitHub] cloudstack pull request #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session ...
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2037
CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility
MySQL 5.7 has a more strict SQL mode by default with which CloudStack
is not compatible.
By setting the SQL Mode to a more relaxed mode on run-time we can
run without changing any SQL server settings.
Admins could also apply this to the [mysqld] section of their my.cnf:
sql_mode = 'STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
Signed-off-by: Wido den Hollander <wi...@widodh.nl>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack sql_mode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit d3f307b1b06da095db7f4410b9e7505182b726af
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2017-04-12T07:48:16Z
CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility
MySQL 5.7 has a more strict SQL mode by default with which CloudStack
is not compatible.
By setting the SQL Mode to a more relaxed mode on run-time we can
run without changing any SQL server settings.
Admins could also apply this to the [mysqld] section of their my.cnf:
sql_mode = 'STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'
Signed-off-by: Wido den Hollander <wi...@widodh.nl>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2037
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Done @rhtyd, how does this look like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Lgtm
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Do you know if this have an impact if we still use MySQL 5.6 or MySQL 5.5 on another host and have CloudStack installed on Ubuntu or CentOS 7 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2037
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
LGTM
@wido can you change the base branch to 4.9, to get this in 4.9 branch as well? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2037
<b>Trillian test result (tid-990)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29008 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2037-t990-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 356.82 | test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py
test_01_vpc_site2site_vpn | Success | 170.05 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.17 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 266.25 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 314.92 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 551.56 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 526.61 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1427.30 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 579.18 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 771.35 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1315.83 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 157.04 | test_volumes.py
test_08_resize_volume | Success | 157.09 | test_volumes.py
test_07_resize_fail | Success | 156.55 | test_volumes.py
test_06_download_detached_volume | Success | 156.29 | test_volumes.py
test_05_detach_volume | Success | 155.82 | test_volumes.py
test_04_delete_attached_volume | Success | 151.24 | test_volumes.py
test_03_download_attached_volume | Success | 156.37 | test_volumes.py
test_02_attach_volume | Success | 124.30 | test_volumes.py
test_01_create_volume | Success | 715.49 | test_volumes.py
test_deploy_vm_multiple | Success | 252.94 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.62 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.94 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.89 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.91 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 45.49 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 45.90 | test_templates.py
test_10_destroy_cpvm | Success | 161.72 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.75 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.57 | test_ssvm.py
test_07_reboot_ssvm | Success | 163.72 | test_ssvm.py
test_06_stop_cpvm | Success | 131.86 | test_ssvm.py
test_05_stop_ssvm | Success | 164.04 | test_ssvm.py
test_04_cpvm_internals | Success | 1.21 | test_ssvm.py
test_03_ssvm_internals | Success | 3.46 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.11 | test_snapshots.py
test_04_change_offering_small | Success | 239.66 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 40.34 | test_routers.py
test_08_start_router | Success | 35.32 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.73 | test_routers.py
test_03_restart_network_cleanup | Success | 60.57 | test_routers.py
test_02_router_internal_adv | Success | 1.17 | test_routers.py
test_01_router_internal_basic | Success | 0.63 | test_routers.py
test_router_dns_guestipquery | Success | 76.76 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 278.30 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.95 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.11 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.98 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.23 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.43 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 495.55 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 426.09 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 97.32 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.81 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.25 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.46 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.45 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.69 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.54 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.29 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.34 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.36 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.31 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.60 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 87.64 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.16 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.11 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.42 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.31 | test_non_contigiousvlan.py
test_01_nic | Success | 444.94 | test_nic.py
test_releaseIP | Success | 252.91 | test_network.py
test_reboot_router | Success | 424.03 | test_network.py
test_public_ip_user_account | Success | 10.26 | test_network.py
test_public_ip_admin_account | Success | 40.28 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.89 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 62.08 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.61 | test_network.py
test_delete_account | Success | 298.16 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.66 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.93 | test_network.py
test_nic_secondaryip_add_remove | Success | 208.40 | test_multipleips_per_nic.py
test_list_zones_metrics | Success | 0.23 | test_metrics_api.py
test_list_volumes_metrics | Success | 5.47 | test_metrics_api.py
test_list_vms_metrics | Success | 187.06 | test_metrics_api.py
test_list_pstorage_metrics | Success | 0.29 | test_metrics_api.py
test_list_infrastructure_metrics | Success | 0.39 | test_metrics_api.py
test_list_hosts_metrics | Success | 0.31 | test_metrics_api.py
test_list_clusters_metrics | Success | 0.33 | test_metrics_api.py
login_test_saml_user | Success | 19.13 | test_login.py
test_assign_and_removal_lb | Success | 134.63 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.57 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 217.69 | test_loadbalance.py
test_03_list_snapshots | Success | 0.07 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.16 | test_iso.py
test_03_delete_iso | Success | 95.15 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 21.00 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 209.60 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 152.97 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 520.84 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 425.88 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.27 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.16 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.96 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.85 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.87 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.06 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.90 | test_dynamicroles.py
test_role_lifecycle_update | Success | 10.99 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.91 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.43 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.88 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.89 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.25 | test_dynamicroles.py
test_role_account_acls | Success | 8.34 | test_dynamicroles.py
test_default_role_deletion | Success | 5.97 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.23 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.12 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.16 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.66 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.58 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 75.76 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.49 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 50.72 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.97 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.99 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 207.35 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 212.81 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 61.03 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
@pdion891 I'll run regression tests
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---