[jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109402#comment-16109402 ] 

ASF GitHub Bot commented on GEODE-3230:
---------------------------------------

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r130677047
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java ---
    @@ -260,6 +265,7 @@ private JMXServiceURL getJMXServiceURL() throws AttachNotSupportedException, IOE
             // need to load the management-agent and get the address
     
             final String javaHome = vm.getSystemProperties().getProperty("java.home");
    +        assertState(StringUtils.isNotBlank(javaHome), CliStrings.JAVA_HOME_NOT_FOUND_ERROR_MESSAGE);
    --- End diff --
    
    I worry about changing the exception the exception thrown here (before I think it would have thrown an `IOException`).


> Delete unused commands in CliStrings
> ------------------------------------
>
>                 Key: GEODE-3230
>                 URL: https://issues.apache.org/jira/browse/GEODE-3230
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example, {{start manager}} has a whole set of associated commands - {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}}, {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere. These commands should be deleted to clean up the code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)