You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/09/23 16:44:40 UTC

[PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

keith-turner opened a new pull request, #4920:
URL: https://github.com/apache/accumulo/pull/4920

   If the TinyLfu cache works well as the default going forward then the LRU cache could eventually be dropped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4920:
URL: https://github.com/apache/accumulo/pull/4920#issuecomment-2368826603

   Opened this based on a conversation w/ @cshannon about 4.0 testing.  If we do all future testing with TinyLfu and it seems to work well and have no problems, then the lru cache code could eventually be dropped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4920:
URL: https://github.com/apache/accumulo/pull/4920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4920:
URL: https://github.com/apache/accumulo/pull/4920#issuecomment-2368873842

   Ran `mvn verify -Psunny` successfully with these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4920:
URL: https://github.com/apache/accumulo/pull/4920#issuecomment-2368906449

   > Should we set the forRemoval flag to be true in the deprecated annotation? I guess if that's the case we'd be expected to remove it for sure from 4.0 so maybe we leave it as is and be more conservative.
   
   forRemoval has subtle problems and there was a PR that outlined those problems and removed its partial use in the code, but not sure what the PR number is.  For this particular code its unlikely users reference it any other way than configuring it, so that leaves the log message as the primary way of notifying the user of it deprecation.  I mainly added the deprecation annotation to avoid new direct uses in the accumulo code base.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org