You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/06/29 18:44:32 UTC
Review Request 67788: Added regression test for archiver utility
symlink extraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67788/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
Bugs: MESOS-9038
https://issues.apache.org/jira/browse/MESOS-9038
Repository: mesos
Description
-------
This modifies an existing test to account for archives with symlinks
under subdirectories.
Diffs
-----
3rdparty/stout/tests/archiver_tests.cpp cdf24a5d9accb1082e8bf3809c865a92d93e63d8
Diff: https://reviews.apache.org/r/67788/diff/1/
Testing
-------
```
make check
# Revert the commit that fixed MESOS-9038.
git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit
cmake --build . --target stout-tests
# Now this is expected to fail.
3rdparty/stout/tests/stout-tests --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*"
```
Thanks,
Joseph Wu
Re: Review Request 67788: Added regression test for archiver utility
symlink extraction.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67788/#review205598
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 29, 2018, 11:44 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67788/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 11:44 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
>
>
> Bugs: MESOS-9038
> https://issues.apache.org/jira/browse/MESOS-9038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This modifies an existing test to account for archives with symlinks
> under subdirectories.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/archiver_tests.cpp cdf24a5d9accb1082e8bf3809c865a92d93e63d8
>
>
> Diff: https://reviews.apache.org/r/67788/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
>
> # Revert the commit that fixed MESOS-9038.
> git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit
> cmake --build . --target stout-tests
>
> # Now this is expected to fail.
> 3rdparty/stout/tests/stout-tests --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 67788: Added regression test for archiver utility
symlink extraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67788/#review205586
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67788]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 29, 2018, 11:44 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67788/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 11:44 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
>
>
> Bugs: MESOS-9038
> https://issues.apache.org/jira/browse/MESOS-9038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This modifies an existing test to account for archives with symlinks
> under subdirectories.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/archiver_tests.cpp cdf24a5d9accb1082e8bf3809c865a92d93e63d8
>
>
> Diff: https://reviews.apache.org/r/67788/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
>
> # Revert the commit that fixed MESOS-9038.
> git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit
> cmake --build . --target stout-tests
>
> # Now this is expected to fail.
> 3rdparty/stout/tests/stout-tests --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 67788: Added regression test for archiver utility
symlink extraction.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67788/#review205582
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67788']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67788
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67788/logs/mesos-tests-stdout.log):
```
[ RUN ] SlaveTest.ResourceVersions
[ OK ] SlaveTest.ResourceVersions (205 ms)
[ RUN ] SlaveTest.ReconfigurationPolicy
[ OK ] SlaveTest.ReconfigurationPolicy (283 ms)
[ RUN ] SlaveTest.ResourceProviderReconciliation
[ OK ] SlaveTest.ResourceProviderReconciliation (352 ms)
[ RUN ] SlaveTest.RunTaskResourceVersions
[ OK ] SlaveTest.RunTaskResourceVersions (302 ms)
[----------] 83 tests from SlaveTest (72266 ms total)
[----------] 3 tests from SlaveStateTest
[ RUN ] SlaveStateTest.CheckpointString
[ OK ] SlaveStateTest.CheckpointString (4 ms)
[ RUN ] SlaveStateTest.CheckpointProtobufMessage
[ OK ] SlaveStateTest.CheckpointProtobufMessage (8 ms)
[ RUN ] SlaveStateTest.CheckpointRepeatedProtobufMessages
[ OK ] SlaveStateTest.CheckpointRepeatedProtobufMessages (9 ms)
[----------] 3 tests from SlaveStateTest (24 ms total)
[----------] 30 tests from SlaveRecoveryTest/0, where TypeParam = class mesos::internal::slave::MesosContainerizer
[ RUN ] SlaveRecoveryTest/0.RecoverSlaveState
[ OK ] SlaveRecoveryTest/0.RecoverSlaveState (826 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager
[ OK ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager (3013 ms)
[ RUN ] SlaveRecoveryTest/0.ReconnectExecutor
[ OK ] SlaveRecoveryTest/0.ReconnectExecutor (3243 ms)
[ RUN ] SlaveRecoveryTest/0.ReconnectExecutorRetry
[ OK ] SlaveRecoveryTest/0.ReconnectExecutorRetry (1000 ms)
[ RUN ] SlaveRecoveryTest/0.PingTimeoutDuringRecovery
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67788/logs/mesos-tests-stderr.log):
```
@ 00007FF616185FCA )<process::ProcessBase *
@ 00007FF6161B5D0C std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *>
@ 00007FF61624963C std::invoke<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *>
@ 00007FF61618F631 )<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *
@ 00007FF6162FBBD6 process::ProcessBase *)>::CallableFn<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> > >::operator(
@ 00007FF617CFD42D process::ProcessBase *)>::operator(
@ 00007FF617BADA69 process::ProcessBase::consume
@ 00007FF617D56C5A process::DispatchEvent::consume
@ 00007FF613D8A5C7 process::ProcessBase::serve
@ 00007FF617BBC060 process::ProcessManager::resume
@ 00007FF617CEA521 ??
@ 00007FF617C0DF20 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF617C6E7B0 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF617C2355C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF617D3D92A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF617D29198 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF617D0F6ED std::_Pad::_Call_func
@ 00007FFF0E453428 _register_onexit_function
@ 00007FFF0E453071 _register_onexit_function
@ 00007FFF1F0A1FE4 BaseThreadInitThunk
@ 00007FFF211FF061 RtlUserThreadStart
erizer.cpp:1064] Recovering provisioner
I0629 20:14:10.855664 16792 provisioner.cpp:494] Provisioner recovery complete
I0629 20:14:10.859652 13096 composing.cpp:339] Finished recovering all containerizers
I0629 20:14:10.859652 16792 slave.cpp:7158] Recovering executors
I0629 20:14:10.860664 16792 slave.cpp:7182] Sending reconnect request to executor '684e9dba-7171-44f6-a4eb-8358eb027f74' of framework 9bf6d415-1604-4f2d-b420-1b1680255e8d-0000 at executor(1)@192.10.1.6:56232
I0629 20:14:10.867663 4196 slave.cpp:4984] Received re-registration message from executor '684e9dba-7171-44f6-a4eb-8358eb027f74' of framework 9bf6d415-1604-4f2d-b420-1b1680255e8d-0000
I0629 20:14:10.870658 20736 slave.cpp:5901] No pings from master received within 75secs
F0629 20:14:10.873656 17256 slave.cpp:1249] Check failed: state == DISCONNECTED || state == RUNNING || state == TERMINATING RECOVERING
```
- Mesos Reviewbot Windows
On June 29, 2018, 6:44 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67788/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 6:44 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
>
>
> Bugs: MESOS-9038
> https://issues.apache.org/jira/browse/MESOS-9038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This modifies an existing test to account for archives with symlinks
> under subdirectories.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/archiver_tests.cpp cdf24a5d9accb1082e8bf3809c865a92d93e63d8
>
>
> Diff: https://reviews.apache.org/r/67788/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
>
> # Revert the commit that fixed MESOS-9038.
> git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit
> cmake --build . --target stout-tests
>
> # Now this is expected to fail.
> 3rdparty/stout/tests/stout-tests --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>