You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/19 19:37:03 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5309: Fix Traffic Monitor Log Spam
ocket8888 opened a new pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309
## What does this PR (Pull Request) do?
- [x] This PR fixes #5306
## Which Traffic Control components are affected by this PR?
- Traffic Monitor
## What is the best way to verify this PR?
Start CDN-in-a-Box, set one (or more, if you like) cache server to ADMIN_DOWN, notice that only the availability change is logged, not every time it's polled.
## If this is a bug fix, what versions of Traffic Control are affected?
- master
- 5.0.x (RC1)
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309#discussion_r527156188
##########
File path: .gitignore
##########
@@ -65,6 +65,10 @@ local.tar.gz
.projectile
*.bak
*.iml
+.anjuta/
+.anjuta_sym_db.db
+*.anjuta
+*.kateproject
Review comment:
What are these for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309#discussion_r527235973
##########
File path: traffic_monitor/health/cache.go
##########
@@ -322,7 +327,7 @@ func CalcAvailability(
Ipv6Available: availStatus.Available.IPv6,
})
- if available, ok := localStates.GetCache(tc.CacheName(result.ID)); !ok || !available.IsAvailable || !availStatus.ProcessedAvailable {
Review comment:
I am now seeing it from that path - which is to say you are correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309#discussion_r527206513
##########
File path: traffic_monitor/health/cache.go
##########
@@ -322,7 +327,7 @@ func CalcAvailability(
Ipv6Available: availStatus.Available.IPv6,
})
- if available, ok := localStates.GetCache(tc.CacheName(result.ID)); !ok || !available.IsAvailable || !availStatus.ProcessedAvailable {
Review comment:
Originally this was `available.IsAvailable != availStatus.ProcessedAvailable` (4.1). I think it should use that instead of `lastStatus`.
I'm not seeing a log entry when going from ADMIN_DOWN -> ONLINE and I assume this is the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309#discussion_r527156188
##########
File path: .gitignore
##########
@@ -65,6 +65,10 @@ local.tar.gz
.projectile
*.bak
*.iml
+.anjuta/
+.anjuta_sym_db.db
+*.anjuta
+*.kateproject
Review comment:
What are these for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5309: Fix Traffic Monitor Log Spam
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5309:
URL: https://github.com/apache/trafficcontrol/pull/5309#discussion_r527221848
##########
File path: traffic_monitor/health/cache.go
##########
@@ -322,7 +327,7 @@ func CalcAvailability(
Ipv6Available: availStatus.Available.IPv6,
})
- if available, ok := localStates.GetCache(tc.CacheName(result.ID)); !ok || !available.IsAvailable || !availStatus.ProcessedAvailable {
Review comment:
`available` no longer exists
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org