You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/06/27 06:58:37 UTC
[GitHub] carbondata pull request #2420: [WIP] updated rename command so that table di...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2420
[WIP] updated rename command so that table directory is not renamed
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata alter_rename_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2420
----
commit eda345921786fe4d37294a81cae08b228e4338f9
Author: kunal642 <ku...@...>
Date: 2018-06-27T06:58:04Z
updated rename command so that table directory is not renamed
----
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5619/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5612/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5472/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5653/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6839/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5579/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5578/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5688/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6777/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200166867
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java ---
@@ -345,14 +346,18 @@ public static CarbonLoadModel getLoadModel(Configuration conf) throws IOExceptio
CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB,
CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB_DEFAULT))));
- model.setBadRecordsLocation(
- conf.get(BAD_RECORD_PATH,
- carbonProperty.getProperty(
- CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH,
- carbonProperty.getProperty(
- CarbonCommonConstants.CARBON_BADRECORDS_LOC,
- CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL))));
-
+ String badRecordsPath = conf.get(BAD_RECORD_PATH);
+ if (StringUtils.isEmpty(badRecordsPath)) {
+ badRecordsPath =
--- End diff --
conf.get will give bad_record_path from load options
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2420
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6790/
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6583/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6732/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6667/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6662/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200237355
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java ---
@@ -378,8 +377,14 @@ private static void getChildDimensionDictionaryDetail(CarbonDimension queryDimen
ColumnIdentifier columnIdentifier;
if (null != dimension.getColumnSchema().getParentColumnTableRelations() && !dimension
.getColumnSchema().getParentColumnTableRelations().isEmpty()) {
- dictionarySourceAbsoluteTableIdentifier = getTableIdentifierForColumn(dimension,
- carbonTable.getAbsoluteTableIdentifier());
+ RelationIdentifier parentRelationIdentifier =
--- End diff --
separate to function
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6727/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5630/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5527/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6722/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6692/
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5484/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6851/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5565/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5574/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest sdv please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2420
LGTM
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6598/
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5479/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5437/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6886/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200151855
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
@@ -255,6 +256,29 @@ object StreamSinkFactory {
optionsFinal.put("fileheader", carbonTable.getCreateOrderColumn(carbonTable.getTableName)
.asScala.map(_.getColName).mkString(","))
}
+ val badRecordsFromLoad = parameters.get("bad_record_path")
+ val badRecordsFromCreate = carbonTable.getTableInfo.getFactTable.getTableProperties
+ .get("bad_records_path")
+ val badRecordsPath = if (badRecordsFromLoad.isDefined &&
--- End diff --
badRecordsFromLoad.isDefined check not required
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5564/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6734/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5608/
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6579/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6713/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5668/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5545/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6822/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5501/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200167194
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
@@ -255,6 +256,29 @@ object StreamSinkFactory {
optionsFinal.put("fileheader", carbonTable.getCreateOrderColumn(carbonTable.getTableName)
.asScala.map(_.getColName).mkString(","))
}
+ val badRecordsFromLoad = parameters.get("bad_record_path")
+ val badRecordsFromCreate = carbonTable.getTableInfo.getFactTable.getTableProperties
+ .get("bad_records_path")
+ val badRecordsPath = if (badRecordsFromLoad.isDefined &&
--- End diff --
badRecordsFromLoad if Option[String] to get the value from it i need to check isDefined and then get the value.
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5492/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234535
--- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ---
@@ -107,19 +107,10 @@ object AlterTableUtil {
*
* @param locks
* @param locksAcquired
- * @param dbName
- * @param tableName
- * @param tablePath
*/
- def releaseLocksManually(locks: List[ICarbonLock],
- locksAcquired: List[String],
- dbName: String,
- tableName: String,
- tablePath: String): Unit = {
- val lockLocation = tablePath
+ def releaseLocksManually(locks: List[ICarbonLock], locksAcquired: List[String]): Unit = {
locks.zip(locksAcquired).foreach { case (carbonLock, lockType) =>
- val lockFilePath = CarbonTablePath.getLockFilePath(lockLocation, lockType)
- if (carbonLock.releaseLockManually(lockFilePath)) {
+ if (carbonLock.unlock()) {
--- End diff --
locks can be removed as state updation is only in hive
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6643/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5489/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5539/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200155277
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java ---
@@ -72,6 +72,28 @@ public CarbonLoadModel build(Map<String, String> options, long UUID, String task
}
optionsFinal.put("fileheader", Strings.mkString(columns, ","));
}
+ String badRecordsFromLoad = options.get("bad_record_path");
+ String badRecordsFromCreate =
+ table.getTableInfo().getFactTable().getTableProperties().get("bad_records_path");
--- End diff --
Move this logic to common place, related to badrecords, this logic repeated so many times
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5522/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5502/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5526/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6802/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6812/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5553/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5633/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5599/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5519/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6665/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5553/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5489/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5498/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5679/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5587/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6816/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6607/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5643/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5651/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5424/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5549/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5564/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5568/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5576/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234454
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala ---
@@ -158,13 +158,11 @@ class CarbonHiveMetaStore extends CarbonFileMetastore {
oldTablePath: String,
sparkSession: SparkSession,
schemaConverter: ThriftWrapperSchemaConverterImpl) = {
- val newTablePath =
- CarbonTablePath.getNewTablePath(oldTablePath, newTableIdentifier.getTableName)
val wrapperTableInfo = schemaConverter.fromExternalToWrapperTableInfo(
thriftTableInfo,
newTableIdentifier.getDatabaseName,
newTableIdentifier.getTableName,
- newTablePath)
+ oldTablePath)
--- End diff --
rename to tablePath
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6700/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5618/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5557/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6858/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6855/
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234399
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java ---
@@ -92,13 +90,7 @@ public static String getBadLogStoreLocation(CarbonDataLoadConfiguration configur
String storeLocation) {
String badLogStoreLocation = (String) configuration
.getDataLoadProperty(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH);
- if (null == badLogStoreLocation) {
- badLogStoreLocation =
- CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC);
- }
- badLogStoreLocation = badLogStoreLocation + File.separator + storeLocation;
-
- return badLogStoreLocation;
+ return badLogStoreLocation + File.separator + storeLocation;
--- End diff --
CarbontablePath has path building functions, move all path building there
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5642/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest sdv please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5572/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5452/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6740/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2420
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5646/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5494/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2420
retest this please
---
[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200150569
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java ---
@@ -345,14 +346,18 @@ public static CarbonLoadModel getLoadModel(Configuration conf) throws IOExceptio
CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB,
CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB_DEFAULT))));
- model.setBadRecordsLocation(
- conf.get(BAD_RECORD_PATH,
- carbonProperty.getProperty(
- CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH,
- carbonProperty.getProperty(
- CarbonCommonConstants.CARBON_BADRECORDS_LOC,
- CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL))));
-
+ String badRecordsPath = conf.get(BAD_RECORD_PATH);
+ if (StringUtils.isEmpty(badRecordsPath)) {
+ badRecordsPath =
--- End diff --
carbon table properties should be checked first then take from configuration
---
[GitHub] carbondata issue #2420: [WIP] updated rename command so that table directory...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5414/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6899/
---
[GitHub] carbondata issue #2420: [CARBONDATA-2666] updated rename command so that tab...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2420
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6730/
---