You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Nikolay Ananiev <an...@thegdb.com> on 2005/09/08 17:28:42 UTC
APR::Request::CGI::upload() should be removed?
Joe,
after moving upload() to APR::Request, I think
APR::Request::CGI::upload() should be removed. Am I right?
Here's a patch
Index: glue/perl/xsbuilder/APR/Request/CGI/CGI.pm
===================================================================
--- glue/perl/xsbuilder/APR/Request/CGI/CGI.pm (revision 279567)
+++ glue/perl/xsbuilder/APR/Request/CGI/CGI.pm (working copy)
@@ -1,29 +1,3 @@
require APR::Request;
use APR::Pool;
push @ISA, "APR::Request";
-
-sub upload {
- my $req = shift;
- my $body = $req->body;
- $body->param_class("APR::Request::CGI::Upload");
- if (@_) {
- return grep {$_->upload} $body->get(shift) if wantarray;
- for ($body->get(shift)) {
- return $_ if $_->upload;
- }
- }
- return map {$_->upload ? $_->name : () } values %$body;
-}
-
-
-package APR::Request::CGI::Upload;
-use APR::Request::Param;
-push our @ISA, "APR::Request::Param";
-
-sub type {}
-sub filename {}
-sub link {}
-sub fh {}
-sub tempname {}
-sub io {}
-sub slurp {}