You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Daikon5 (via GitHub)" <gi...@apache.org> on 2026/01/26 15:33:55 UTC
[PR] IGNITE-27637 Updated downloads page with closer.lua links [ignite-website]
Daikon5 opened a new pull request, #310:
URL: https://github.com/apache/ignite-website/pull/310
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27637 Update downloads page with closer.lua links [ignite-website]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #310:
URL: https://github.com/apache/ignite-website/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27637 Update downloads page with closer.lua links [ignite-website]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #310:
URL: https://github.com/apache/ignite-website/pull/310#discussion_r2736413648
##########
_src/_components/download-extension-binary.pug:
##########
@@ -51,6 +51,6 @@
date: "2022-05-17",
guide: "/docs/latest/extensions-and-integrations/zookeeper-ip-finder-ext.html",
notes: "/releases/ext/zookeeper-ip-finder-ext-1.0.0/release_notes.html",
- sourcelink: "https://archive.apache.org/dist/ignite/ignite-extensions/ignite-zookeeper-ip-finder-ext/1.0.0/zookeeper-ip-finder-ext-bin.zip",
+ sourcelink: "https://www.apache.org/dyn/closer.lua/ignite/ignite-extensions/ignite-zookeeper-ip-finder-ext/1.0.0/ignite-zookeeper-ip-finder-ext-bin.zip",
Review Comment:
This change renames the referenced artifact from `zookeeper-ip-finder-ext-bin.zip` to `ignite-zookeeper-ip-finder-ext-bin.zip`. Since the PR is about `closer.lua` links, please double-check the published artifact name and avoid renaming unless the dist artifact was actually renamed (otherwise this will produce a broken download link).
##########
download.html:
##########
@@ -400,13 +400,13 @@ <h2 class="capstext pb-5">SOURCE RELEASES</h2>
<td class="jsLinksInside">
<a
class="sourcelink"
- href="https://archive.apache.org/dist/ignite/3.1.0/apache-ignite-3.1.0-src.zip"
+ href="https://www.apache.org/dyn/closer.lua/ignite/3.1.0/apache-ignite-3.1.0-src.zip?action=download"
target="_blank"
onclick="gtag('event', 'download', {'event_category': 'apache_ignite_source_download', 'event_label': 'apache-ignite-3.1.0'});"
>apache-ignite-3.1.0-src.zip</a
>
- (<a href="https://archive.apache.org/dist/ignite/3.1.0/apache-ignite-3.1.0-src.zip.asc" target="_blank">pgp</a
- ><a href="https://archive.apache.org/dist/ignite/3.1.0/apache-ignite-3.1.0-src.zip.sha512" target="_blank">sha512</a>)
+ (<a href="https://www.apache.org/dyn/closer.lua/ignite/3.1.0/apache-ignite-3.1.0-src.zip.asc?action=download" target="_blank">pgp</a
+ ><a href="https://www.apache.org/dyn/closer.lua/ignite/3.1.0/apache-ignite-3.1.0-src.zip.sha512?action=download" target="_blank">sha512</a>)
Review Comment:
The PGP/SHA512 links here are also being changed to go through `closer.lua`. This conflicts with the “How to verify” section on the same page, which advises downloading signatures from the main distribution directory rather than a mirror. Consider keeping only the main zip on `closer.lua` and pointing `.asc`/`.sha512` to `downloads.apache.org`.
##########
_src/download.pug:
##########
@@ -65,10 +65,10 @@ block main
if(params.sourcelink)
- let fileNameArr = params.sourcelink.split("/");
- let fileName = fileNameArr[fileNameArr.length - 1];
- a.sourcelink(href=params.sourcelink, target="_blank", onclick=params.onclick) !{fileName}
+ a.sourcelink(href=params.sourcelink + "?action=download", target="_blank", onclick=params.onclick) !{fileName}
| (
- a(href=params.sourcelink + ".asc", target="_blank") pgp
- a(href=params.sourcelink + ".sha512", target="_blank") sha512
+ a(href=params.sourcelink + ".asc" + "?action=download", target="_blank") pgp
+ a(href=params.sourcelink + ".sha512" + "?action=download", target="_blank") sha512
| )
Review Comment:
Same issue as above for extension downloads: `.asc` and `.sha512` are linked via `closer.lua` (mirrors), but verification instructions recommend downloading signature/checksum from the main distribution directory. Use `downloads.apache.org` (or equivalent canonical host) for `.asc`/`.sha512` links and reserve `closer.lua` for the main artifact.
##########
_src/download.pug:
##########
@@ -43,10 +43,10 @@ block main
if(params.sourcelink)
- let fileNameArr = params.sourcelink.split("/");
- let fileName = fileNameArr[fileNameArr.length - 1];
- a.sourcelink(href=params.sourcelink, target="_blank", onclick=params.onclick) !{fileName}
+ a.sourcelink(href=params.sourcelink + "?action=download", target="_blank", onclick=params.onclick) !{fileName}
| (
- a(href=params.sourcelink + ".asc", target="_blank") pgp
- a(href=params.sourcelink + ".sha512", target="_blank") sha512
+ a(href=params.sourcelink + ".asc?action=download", target="_blank") pgp
+ a(href=params.sourcelink + ".sha512?action=download", target="_blank") sha512
| )
Review Comment:
The PGP/SHA512 links are being routed through `closer.lua` (mirrors). This contradicts the page’s own verification guidance to fetch signatures/checksums from the main distribution directory (and avoids the possibility of being redirected to an HTTP mirror). Keep the main artifact download on `closer.lua`, but link `.asc` and `.sha512` to the canonical distribution host (e.g., `https://downloads.apache.org/...`) instead of the mirror redirector.
##########
_src/_components/download-extension-source.pug:
##########
@@ -87,6 +87,6 @@
date: "2022-05-17",
guide: "/docs/latest/extensions-and-integrations/zookeeper-ip-finder-ext.html",
notes: "/releases/ext/zookeeper-ip-finder-ext-1.0.0/release_notes.html",
- sourcelink: "https://archive.apache.org/dist/ignite/ignite-extensions/ignite-zookeeper-ip-finder-ext/1.0.0/zookeeper-ip-finder-ext-src.zip",
+ sourcelink: "https://www.apache.org/dyn/closer.lua/ignite/ignite-extensions/ignite-zookeeper-ip-finder-ext/1.0.0/ignite-zookeeper-ip-finder-ext-src.zip",
Review Comment:
This change renames the referenced artifact from `zookeeper-ip-finder-ext-src.zip` to `ignite-zookeeper-ip-finder-ext-src.zip`. That’s beyond the stated goal of switching to `closer.lua` and risks breaking the link if the published artifact name hasn’t changed. Please verify the actual filename under the Ignite dist path and keep the download filename consistent across pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org