You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/14 13:20:46 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #3716: Remove unreachable decimal take

tustvold opened a new pull request, #3716:
URL: https://github.com/apache/arrow-rs/pull/3716

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This code is unreachable as downcast_primitive already handles decimals
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3716: Remove unreachable decimal take

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3716:
URL: https://github.com/apache/arrow-rs/pull/3716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #3716: Remove unreachable decimal take

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3716:
URL: https://github.com/apache/arrow-rs/pull/3716#issuecomment-1430209740

   Benchmark runs are scheduled for baseline = 3fcfda9d4260c11d4bfd1f5564b17e5262b710a3 and contender = 86836a8d49059603b833395655c6f6c4a67be7e7. 86836a8d49059603b833395655c6f6c4a67be7e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c734114022804f49821d36f9e05a9399...958865c446d042e99e696654cf3f98fe/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/838ad75bf6b74415a1b8fdd0a735b6fd...bbd5da9ff1e64f2c9c90879efb6f4160/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4cd9419f7885429d85076c03c47c53cb...10e6e7b90a614ecbb1726fbacb14a05d/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5db0c5f5726c44ebaadb6b219d24a460...ba3499867fca4b34a1e94fe47e0082ae/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3716: Remove unreachable decimal take

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3716:
URL: https://github.com/apache/arrow-rs/pull/3716#issuecomment-1430040126

   TBC this is unreachable because the downcast_primitive code already handles the case of Decimal arrays


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #3716: Remove unreachable decimal take

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3716:
URL: https://github.com/apache/arrow-rs/pull/3716#issuecomment-1430033817

   cc @liukun4515 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org