[jira] [Commented] (PDFBOX-3417) Redundant/incorrect code in PDVisibleSignDesigner.java

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373596#comment-15373596 ] 

Tilman Hausherr commented on PDFBOX-3417:
-----------------------------------------

Uh, yes. And it has been this way since 2013 (PDFBOX-1766). And I have no idea what was the artist' intention.

> Redundant/incorrect code in PDVisibleSignDesigner.java
> ------------------------------------------------------
>
>                 Key: PDFBOX-3417
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3417
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.1.0
>            Reporter: Vittal Aithal
>            Priority: Trivial
>
> org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSignDesigner.java contains the following in the calculatePageSize method:
> {code}
>     float x = pageWidth;
>     float y = 0;
>     pageWidth += y;
>     float tPercent = (100 * y / (x + y));
>     imageSizeInPercents = 100 - tPercent;
> {code}
> I can't see how this would result in anything but an imageSizeInPercents of 100.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org