You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Ortwin Glück <or...@nose.ch> on 2002/08/29 11:29:04 UTC
Re: [HttpClient] [PATCH] streams, webapp, bugfix
This cummulative patch changes:
- unbuffered input streams
- webapp tests fixed (including patches by Ryan Lubke)
- authentication retry bug
Odi
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by Jeff Dever <js...@sympatico.ca>.
Done deal.
Ortwin Glück wrote:
> You can safely remove
>
> protected void readResponseBody(HttpState state, HttpConnection conn,
> OutputStream out) throws IOException
>
> from the code. It has been replaced completely and is not used any longer.
>
> You should also change the HttpMethodBase.strictMode initial value to false.
>
> Odi
>
> Jeff Dever wrote:
> > _readResponseBody was there and OK, but the old readResponseBody was there and
> > never called it. Fixed now.
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by Ortwin Glück <or...@nose.ch>.
You can safely remove
protected void readResponseBody(HttpState state, HttpConnection conn,
OutputStream out) throws IOException
from the code. It has been replaced completely and is not used any longer.
You should also change the HttpMethodBase.strictMode initial value to false.
Odi
Jeff Dever wrote:
> _readResponseBody was there and OK, but the old readResponseBody was there and
> never called it. Fixed now.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by Jeff Dever <js...@sympatico.ca>.
_readResponseBody was there and OK, but the old readResponseBody was there and
never called it. Fixed now.
Ortwin Glück wrote:
> Well it wasn't. The HttpMethodBase seems to lack some of my code. Take a
> look at readResponseBody and _readResponseBody please.
>
> Odi
>
> Jeff Dever wrote:
> > This patch has been applied. Whew! The previous formatting patch applied by
> > dIon made the application of this patch very difficult. The formatting patch
> > had some good changes, but patches of this kind are highly disruptive and
> > should probablly schedluled or announced beforehand to minimize the
> > possiblity of interferance.
> >
> > Anyway, Odi can you please re-run and specific tests to ensure the patch was
> > applied successfully?
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by Ortwin Glück <or...@nose.ch>.
Well it wasn't. The HttpMethodBase seems to lack some of my code. Take a
look at readResponseBody and _readResponseBody please.
Odi
Jeff Dever wrote:
> This patch has been applied. Whew! The previous formatting patch applied by
> dIon made the application of this patch very difficult. The formatting patch
> had some good changes, but patches of this kind are highly disruptive and
> should probablly schedluled or announced beforehand to minimize the
> possiblity of interferance.
>
> Anyway, Odi can you please re-run and specific tests to ensure the patch was
> applied successfully?
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by di...@multitask.com.au.
jsdever wrote on 03/09/2002 12:58:19 AM:
> This patch has been applied. Whew! The previous formatting patch
applied by
> dIon made the application of this patch very difficult. The formatting
patch
> had some good changes, but patches of this kind are highly disruptive
and
> should probablly schedluled or announced beforehand to minimize the
> possiblity of interferance.
My apologies.
I'd also ask that we do smaller commits. Monolithic commits will always
have conflict problems on a project that has activity. I've been working
with the jalopy plugin for Maven, so the formatting may be something we
can do all at once, on demand soon.
> Anyway, Odi can you please re-run and specific tests to ensure the patch
was
> applied successfully?
Is there documentation yet on running the web-app tests? I must've missed
it last week.
--
dIon Gillard, Multitask Consulting
Work: http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [HttpClient] [PATCH] streams, webapp, bugfix
Posted by Jeff Dever <js...@sympatico.ca>.
This patch has been applied. Whew! The previous formatting patch applied by
dIon made the application of this patch very difficult. The formatting patch
had some good changes, but patches of this kind are highly disruptive and
should probablly schedluled or announced beforehand to minimize the
possiblity of interferance.
Anyway, Odi can you please re-run and specific tests to ensure the patch was
applied successfully?
Ortwin Glück wrote:
> This cummulative patch changes:
>
> - unbuffered input streams
> - webapp tests fixed (including patches by Ryan Lubke)
> - authentication retry bug
>
> Odi
>
> ------------------------------------------------------------------------
> Name: patch.diff
> patch.diff Type: Plain Text (text/plain)
> Encoding: 7bit
>
> Name: AutoCloseInputStream.java
> AutoCloseInputStream.java Type: Plain Text (text/plain)
> Encoding: 8bit
>
> Name: ChunkedInputStream.java
> ChunkedInputStream.java Type: Plain Text (text/plain)
> Encoding: 8bit
>
> Name: ContentLengthInputStream.java
> ContentLengthInputStream.java Type: Plain Text (text/plain)
> Encoding: 8bit
>
> Name: WireLogInputStream.java
> WireLogInputStream.java Type: Plain Text (text/plain)
> Encoding: 8bit
>
> Name: TestStreams.java
> TestStreams.java Type: Plain Text (text/plain)
> Encoding: 7bit
>
> Part 1.8Type: Plain Text (text/plain)
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>