[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1981: [bug]Resolve that running logs do not display exceptions.

[GitBox <gi...@apache.org>]

wolfboys commented on code in PR #1981:
URL: https://github.com/apache/incubator-streampark/pull/1981#discussion_r1015353486


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/LoggerServiceImpl.java:
##########
@@ -47,20 +47,20 @@ public class LoggerServiceImpl implements LoggerService {
      * @param limit       limit
      * @return log string data
      */
-    public CompletionStage<String> queryLog(String nameSpace, String jobName, int skipLineNum, int limit) {
-        return CompletableFuture.supplyAsync(() -> jobDeploymentsWatch(nameSpace, jobName)
+    public CompletionStage<String> queryLog(String nameSpace, String jobName, String jobId, int skipLineNum, int limit) {
+        return CompletableFuture.supplyAsync(() -> jobDeploymentsWatch(nameSpace, jobName, jobId)
         ).exceptionally(e -> {
             try {
-                return String.format("%s/%s_%s_err.log", new File("").getCanonicalPath(), nameSpace, jobName);
+                return String.format("%s/%s_err.log", new File("temp").getCanonicalPath(), jobId);

Review Comment:
   `new File("temp").getCanonicalPath()` need to replace to `WebUtils.getAppTempDir()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org