You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Luke Cwik (JIRA)" <ji...@apache.org> on 2017/10/13 00:15:00 UTC

[jira] [Commented] (BEAM-3049) Java SDK Harness bundles non-relocated code, including Dataflow runner

    [ https://issues.apache.org/jira/browse/BEAM-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202851#comment-16202851 ] 

Luke Cwik commented on BEAM-3049:
---------------------------------

Since your breaking up the dependencies so that the runner harness doesn't need to depend on the SDK harness then this wouldn't be an issue.

Removing the Dataflow Runner dependency is a different issue.

> Java SDK Harness bundles non-relocated code, including Dataflow runner
> ----------------------------------------------------------------------
>
>                 Key: BEAM-3049
>                 URL: https://issues.apache.org/jira/browse/BEAM-3049
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-harness
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> This causes a problem if something depends on the harness but does not want the harness's copy of its dependencies. I know we intend to break the dependency on the Dataflow runner. It also bundles a couple other things unshaded.
> Mostly, the harness should be executed entirely containerized so it doesn't matter, in which case there's no need to relocate anything, and bundling is just a convenience. But we should have a clear policy that we adhere to. Either it is a library and should have good hygeine, or if it doesn't have good hygeine it must not be used as a library.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)