You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/23 16:49:29 UTC
[GitHub] [airflow] ashb commented on a change in pull request #21740: Make Grid and and Graph view work with task mapping
ashb commented on a change in pull request #21740:
URL: https://github.com/apache/airflow/pull/21740#discussion_r813100814
##########
File path: airflow/www/static/js/tree/InstanceTooltip.jsx
##########
@@ -24,30 +24,33 @@ import { Box, Text } from '@chakra-ui/react';
import { formatDateTime, getDuration, formatDuration } from '../datetime_utils';
+const STATES = [
+ ['success', 0],
+ ['failed', 0],
+ ['upstream_failed', 0],
+ ['up_for_retry', 0],
+ ['up_for_reschedule', 0],
+ ['running', 0],
+ ['deferred', 0],
+ ['sensing', 0],
+ ['queued', 0],
+ ['scheduled', 0],
+ ['skipped', 0],
+ ['no_status', 0],
Review comment:
Not thrilled about having this list in multiple JS files. Is there any sensible way to define it once and reuse it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org