You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/27 12:20:32 UTC
[PR] HDDS-10225. Speed up TestSCMHAManagerImpl [ozone]
adoroszlai opened a new pull request, #6109:
URL: https://github.com/apache/ozone/pull/6109
## What changes were proposed in this pull request?
`TestSCMHAManagerImpl` has three test cases, each starting new leader SCM from scratch:
* add SCM
* remove SCM
* invalid scenarios
```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.041 s - in org.apache.hadoop.hdds.scm.ha.TestSCMHAManagerImpl
```
This change reduces test execution time by starting a single leader SCM.
1. Testing removal of peer requires adding it first, so `testRemoveSCM` already depends on "add SCM" functionality working correctly. The patch deletes "add SCM" setup from `testRemoveSCM`, now it relies on the state left by `testAddSCM`.
2. Testing invalid scenarios does not need a fresh SCM leader, requests being tested are invalid either way.
Also, some additional code cleanup, performed in separate commits for easier review.
https://issues.apache.org/jira/browse/HDDS-10225
## How was this patch tested?
```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.489 s - in org.apache.hadoop.hdds.scm.ha.TestSCMHAManagerImpl
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/7678209884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10225. Speed up TestSCMHAManagerImpl [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6109:
URL: https://github.com/apache/ozone/pull/6109#issuecomment-1916582453
Thanks @nandakumar131 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10225. Speed up TestSCMHAManagerImpl [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #6109:
URL: https://github.com/apache/ozone/pull/6109#issuecomment-1916579667
Thanks @adoroszlai for the improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10225. Speed up TestSCMHAManagerImpl [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 merged PR #6109:
URL: https://github.com/apache/ozone/pull/6109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org