[incubator-skywalking] branch prometheus-improve updated: Remove two unnecessary counter.

[wu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch prometheus-improve
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/prometheus-improve by this push:
     new 2c017d9  Remove two unnecessary counter.
2c017d9 is described below

commit 2c017d94144772e2279bd44f51cbbf60c3f68b6e
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Wed Jan 9 21:29:55 2019 +0800

    Remove two unnecessary counter.
---
 .../skywalking/oap/server/core/storage/PersistenceTimer.java      | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
index 522f9d5..367bd9e 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java
@@ -38,9 +38,7 @@ public enum PersistenceTimer {
     private Boolean isStarted = false;
     private final Boolean debug;
     private CounterMetric errorCounter;
-    private CounterMetric prepareCounter;
     private HistogramMetric prepareLatency;
-    private CounterMetric executeCounter;
     private HistogramMetric executeLatency;
 
     PersistenceTimer() {
@@ -57,12 +55,8 @@ public enum PersistenceTimer {
         MetricCreator metricCreator = moduleManager.find(TelemetryModule.NAME).provider().getService(MetricCreator.class);
         errorCounter = metricCreator.createCounter("persistence_timer_bulk_error_count", "Error execution of the prepare stage in persistence timer",
             MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE);
-        prepareCounter = metricCreator.createCounter("persistence_timer_bulk_prepare_count", "Execution of the prepare stage in persistence timer",
-            MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE);
         prepareLatency = metricCreator.createHistogramMetric("persistence_timer_bulk_prepare_latency", "Latency of the prepare stage in persistence timer",
             MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE);
-        executeCounter = metricCreator.createCounter("persistence_timer_bulk_execute_count", "Execution of the execute stage in persistence timer",
-            MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE);
         executeLatency = metricCreator.createHistogramMetric("persistence_timer_bulk_execute_latency", "Latency of the execute stage in persistence timer",
             MetricTag.EMPTY_KEY, MetricTag.EMPTY_VALUE);
 
@@ -83,7 +77,6 @@ public enum PersistenceTimer {
 
         long startTime = System.currentTimeMillis();
         try {
-            prepareCounter.inc();
             HistogramMetric.Timer timer = prepareLatency.createTimer();
 
             List batchAllCollection = new LinkedList();
@@ -114,7 +107,6 @@ public enum PersistenceTimer {
                 timer.finish();
             }
 
-            executeCounter.inc();
             HistogramMetric.Timer executeLatencyTimer = executeLatency.createTimer();
             try {
                 batchDAO.batchPersistence(batchAllCollection);