You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 13:41:34 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
wangyang0918 opened a new pull request #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, we just check whether the JobManager/TaskManager is smaller than YARN minimum allocation memory. I think it should be enriched by checking whether it is a multiple of YARN minimum allocation memory.
Because YARN will always normalize the resource request by insuring that the requested memory is a multiple of minimum allocation. The minimum allocation could be configured in YARN ResourceManager via 'yarn.scheduler.minimum-allocation-mb'.
## Brief change log
* Update the warning log
## Verifying this change
* Manually test and logs look like the following
```
2020-02-21 21:28:40,190 INFO org.apache.flink.yarn.YarnClusterDescriptor - No path for the flink jar passed. Using the location of class org.apache.flink.yarn.YarnClusterDescriptor to locate the jar
2020-02-21 21:28:40,561 WARN org.apache.flink.yarn.YarnClusterDescriptor - The [JobManager memory(1025), TaskManager memory(1568)] is not a multiple of YARN minimum allocation memory(128), so some extra memory will be wasted. Because YARN will always normalize the resource request by insuring that the requested memory is a multiple of minimum allocation. The value of 'yarn.scheduler.minimum-allocation-mb' is '128'. Please increase the specified memory size.
2020-02-21 21:28:40,561 INFO org.apache.flink.yarn.YarnClusterDescriptor - Cluster specification: ClusterSpecification{masterMemoryMB=1025, taskManagerMemoryMB=1568, slotsPerTaskManager=1}
2020-02-21 21:28:40,925 WARN org.apache.hadoop.hdfs.shortcircuit.DomainSocketFactory - The short-circuit local reads feature cannot be used because libhadoop cannot be loaded.
2020-02-21 21:30:26,596 INFO org.apache.flink.yarn.YarnClusterDescriptor - Submitting application master application_1581945672065_0124
2020-02-21 21:30:26,829 INFO org.apache.hadoop.yarn.client.api.impl.YarnClientImpl - Submitted application application_1581945672065_0124
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150018467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423)
* 754693bae424353bac4cdd6d0db556ed8f6234f9 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150231364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150018467 TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150018467)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 754693bae424353bac4cdd6d0db556ed8f6234f9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150231364) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494)
* 0c7e2f0b6374a0fcaaf765aa410ab207e278706f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150298749",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 754693bae424353bac4cdd6d0db556ed8f6234f9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150231364) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494)
* 0c7e2f0b6374a0fcaaf765aa410ab207e278706f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150298749)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#discussion_r383064789
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -521,11 +521,18 @@ private ClusterSpecification validateClusterResources(
int jobManagerMemoryMb = clusterSpecification.getMasterMemoryMB();
final int taskManagerMemoryMb = clusterSpecification.getTaskManagerMemoryMB();
- if (jobManagerMemoryMb < yarnMinAllocationMB || taskManagerMemoryMb < yarnMinAllocationMB) {
- LOG.warn("The JobManager or TaskManager memory is below the smallest possible YARN Container size. "
- + "The value of 'yarn.scheduler.minimum-allocation-mb' is '" + yarnMinAllocationMB + "'. Please increase the memory size." +
- "YARN will allocate the smaller containers but the scheduler will account for the minimum-allocation-mb, maybe not all instances " +
- "you requested will start.");
+ final List<String> noteMem = new ArrayList<>();
+ if (jobManagerMemoryMb % yarnMinAllocationMB != 0 || jobManagerMemoryMb == 0) {
+ noteMem.add("JobManager memory(" + jobManagerMemoryMb + ")");
+ }
+ if (taskManagerMemoryMb % yarnMinAllocationMB != 0 || taskManagerMemoryMb == 0) {
+ noteMem.add("TaskManager memory(" + taskManagerMemoryMb + ")");
+ }
+ if (noteMem.size() > 0) {
+ LOG.warn("The {} is not a multiple of YARN minimum allocation memory({}), so some extra memory will be wasted. "
+ + "Because YARN will always normalize the resource request by insuring that the requested memory is a multiple "
+ + "of minimum allocation. The value of 'yarn.scheduler.minimum-allocation-mb' is '" + yarnMinAllocationMB + "'. "
+ + "Please increase the specified memory size.", noteMem.toString(), yarnMinAllocationMB);
Review comment:
I would suggest to have a more concise log message. The current one mentions "multiple of YARN min allocation" and the configured value of yarnMinAllocationMB twice each, which is not necessary.
I would suggest the following:
`The configured {} memory is {} MB. YARN will allocate {} MB to make up an integer multiple of its minimum allocation memory ({} MB, configured via 'yarn.scheduler.minimum-allocation-mb'). The extra {} MB may not be used by Flink.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150018467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150298749",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5516",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c7e2f0b6374a0fcaaf765aa410ab207e278706f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150298749) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5516)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150018467 TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423 TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150018467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11176: [FLINK-15948][yarn]
Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589658002
@tillrohrmann Could you take a look? This is a very small change to enrich the logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150018467 TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423 TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150018467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150298749",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
}, {
"hash" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5516",
"triggerID" : "0c7e2f0b6374a0fcaaf765aa410ab207e278706f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c7e2f0b6374a0fcaaf765aa410ab207e278706f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150298749) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5516)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11176: [FLINK-15948][yarn]
Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
Hash:adb2e9e62190ba505ee86554a97452984fbc2de4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:adb2e9e62190ba505ee86554a97452984fbc2de4
-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11176: [FLINK-15948][yarn]
Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589658522
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit adb2e9e62190ba505ee86554a97452984fbc2de4 (Fri Feb 21 13:44:31 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11176: [FLINK-15948][yarn]
Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-590295807
@xintongsong Thanks a lot for your review and suggestion, especially for the text. I have addressed your comments. Please take a look at your convenience.
@tillrohrmann Do you mind to take a look too and help to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 closed pull request #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
wangyang0918 closed pull request #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150231364",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 754693bae424353bac4cdd6d0db556ed8f6234f9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150231364) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-589671142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150018467",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423",
"triggerID" : "adb2e9e62190ba505ee86554a97452984fbc2de4",
"triggerType" : "PUSH"
}, {
"hash" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "754693bae424353bac4cdd6d0db556ed8f6234f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adb2e9e62190ba505ee86554a97452984fbc2de4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150018467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5423)
* 754693bae424353bac4cdd6d0db556ed8f6234f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11176: [FLINK-15948][yarn]
Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#issuecomment-592301510
Merged to master via [d6f039](https://github.com/apache/flink/commit/d6f0396b0e171be1942d12ac77afa73852ab2809). Thanks @tillrohrmann.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11176:
[FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory
URL: https://github.com/apache/flink/pull/11176#discussion_r383064879
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -521,11 +521,18 @@ private ClusterSpecification validateClusterResources(
int jobManagerMemoryMb = clusterSpecification.getMasterMemoryMB();
final int taskManagerMemoryMb = clusterSpecification.getTaskManagerMemoryMB();
- if (jobManagerMemoryMb < yarnMinAllocationMB || taskManagerMemoryMb < yarnMinAllocationMB) {
- LOG.warn("The JobManager or TaskManager memory is below the smallest possible YARN Container size. "
- + "The value of 'yarn.scheduler.minimum-allocation-mb' is '" + yarnMinAllocationMB + "'. Please increase the memory size." +
- "YARN will allocate the smaller containers but the scheduler will account for the minimum-allocation-mb, maybe not all instances " +
- "you requested will start.");
+ final List<String> noteMem = new ArrayList<>();
+ if (jobManagerMemoryMb % yarnMinAllocationMB != 0 || jobManagerMemoryMb == 0) {
+ noteMem.add("JobManager memory(" + jobManagerMemoryMb + ")");
+ }
+ if (taskManagerMemoryMb % yarnMinAllocationMB != 0 || taskManagerMemoryMb == 0) {
+ noteMem.add("TaskManager memory(" + taskManagerMemoryMb + ")");
+ }
+ if (noteMem.size() > 0) {
+ LOG.warn("The {} is not a multiple of YARN minimum allocation memory({}), so some extra memory will be wasted. "
+ + "Because YARN will always normalize the resource request by insuring that the requested memory is a multiple "
+ + "of minimum allocation. The value of 'yarn.scheduler.minimum-allocation-mb' is '" + yarnMinAllocationMB + "'. "
+ + "Please increase the specified memory size.", noteMem.toString(), yarnMinAllocationMB);
Review comment:
I would suggest to wrap the checking and the logging into one method, and call it twice for both JM and TM. The method could look like:
`logIfComponentMemNotIntegerMultipleOfYarnMinAllocation(String componentName, int componentMemoryMB, int yarnMinAllocationMB)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services