You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/01 13:22:56 UTC
[GitHub] [skywalking] liqiangz opened a new pull request #6671: Http code
liqiangz opened a new pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or the bug issue number or bug issue link>
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
The framework change httpCode after AbstractMethodInterceptor. Replace it with
org.apache.skywalking.apm.plugin.spring.mvc.v5.InvokeInterceptor.
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #5905.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `54.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head 18a3982. Consider uploading reports for the commit 18a3982 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 0.00% -54.20%
============================================
Files 1796 171 -1625
Lines 38527 4256 -34271
Branches 4235 480 -3755
============================================
- Hits 20878 0 -20878
+ Misses 16654 4256 -12398
+ Partials 995 0 -995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1764 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...18a3982](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `10.62%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 43.56% -10.63%
+ Complexity 4181 2677 -1504
=============================================
Files 1796 844 -952
Lines 38527 21174 -17353
Branches 4235 2028 -2207
=============================================
- Hits 20878 9225 -11653
+ Misses 16654 11260 -5394
+ Partials 995 689 -306
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1379 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r605661309
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -19,12 +19,16 @@
import java.lang.reflect.Method;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveResponseHolder;
+import org.springframework.http.HttpStatus;
import org.springframework.web.server.ServerWebExchange;
+import reactor.core.publisher.Mono;
Review comment:
I will change the referenced package to spring-boot-starter-webflux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.11%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 41.07% -13.12%
+ Complexity 4181 2463 -1718
=============================================
Files 1796 813 -983
Lines 38527 20212 -18315
Branches 4235 1938 -2297
=============================================
- Hits 20878 8302 -12576
+ Misses 16654 11273 -5381
+ Partials 995 637 -358
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1419 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `9.76%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 58.36% +9.76%
+ Complexity 3500 833 -2667
============================================
Files 985 175 -810
Lines 24307 4282 -20025
Branches 2371 481 -1890
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1466 -10024
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [821 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.39%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.79% -5.40%
+ Complexity 4181 3019 -1162
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18824 -2054
- Misses 16654 18762 +2108
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [227 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `26.11%`.
> The diff coverage is `76.92%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 28.23% -26.12%
+ Complexity 4198 2137 -2061
=============================================
Files 1796 1002 -794
Lines 38500 24714 -13786
Branches 4241 2390 -1851
=============================================
- Hits 20922 6977 -13945
- Misses 16586 17196 +610
+ Partials 992 541 -451
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `14.63% <0.00%> (-42.61%)` | `10.00 <0.00> (-21.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.79% <0.00%> (-54.03%)` | `4.00 <0.00> (-6.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1433 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `5.20%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 53.80% +5.20%
- Complexity 3500 4000 +500
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13879 +2066
+ Misses 11490 10712 -778
- Partials 1004 1206 +202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [230 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.43%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.75% -13.44%
+ Complexity 4181 2900 -1281
=============================================
Files 1796 1026 -770
Lines 38527 25410 -13117
Branches 4235 2501 -1734
=============================================
- Hits 20878 10357 -10521
+ Misses 16654 14266 -2388
+ Partials 995 787 -208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `3.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 51.68% +3.08%
- Complexity 3500 3917 +417
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13334 +1521
+ Misses 11490 11304 -186
- Partials 1004 1159 +155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [224 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.46%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.87% -2.47%
+ Complexity 4198 3936 -262
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20060 -862
- Misses 16586 17605 +1019
- Partials 992 1006 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `11.18%`.
> The diff coverage is `76.92%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 43.15% -11.19%
+ Complexity 4198 3309 -889
=============================================
Files 1796 1030 -766
Lines 38500 25569 -12931
Branches 4241 2504 -1737
=============================================
- Hits 20922 11035 -9887
+ Misses 16586 13608 -2978
+ Partials 992 926 -66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `15.33% <0.00%> (-41.92%)` | `11.00 <0.00> (-20.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.79% <0.00%> (-54.03%)` | `4.00 <0.00> (-6.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.77%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.57% -3.78%
+ Complexity 4198 3782 -416
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19556 -1366
- Misses 16586 18108 +1522
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `30.06%`.
> The diff coverage is `76.92%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 24.27% -30.07%
+ Complexity 4198 1877 -2321
=============================================
Files 1796 1002 -794
Lines 38500 24591 -13909
Branches 4241 2358 -1883
=============================================
- Hits 20922 5970 -14952
- Misses 16586 18172 +1586
+ Partials 992 449 -543
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `14.63% <0.00%> (-42.61%)` | `10.00 <0.00> (-21.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.79% <0.00%> (-54.03%)` | `4.00 <0.00> (-6.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1458 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `15.95%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 48.59% 32.64% -15.96%
+ Complexity 3500 2410 -1090
=============================================
Files 985 1005 +20
Lines 24307 24652 +345
Branches 2371 2414 +43
=============================================
- Hits 11813 8047 -3766
- Misses 11490 15984 +4494
+ Partials 1004 621 -383
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only activate webflux plugin when not using spring mvc reactive api
![image](https://user-images.githubusercontent.com/16935891/113428210-fb32ed00-9408-11eb-8594-bff10db672c2.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 207 -778
Lines 24307 4901 -19406
Branches 2371 555 -1816
============================================
- Hits 11813 0 -11813
+ Misses 11490 4901 -6589
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [970 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.75%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.43% -5.76%
+ Complexity 4181 2999 -1182
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18686 -2192
- Misses 16654 18900 +2246
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [231 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.94%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.24% -5.95%
+ Complexity 4181 2977 -1204
============================================
Files 1796 1797 +1
Lines 38527 38539 +12
Branches 4235 4219 -16
============================================
- Hits 20878 18593 -2285
- Misses 16654 18951 +2297
Partials 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [238 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `6.55%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 47.63% -6.56%
+ Complexity 4181 2907 -1274
============================================
Files 1796 1797 +1
Lines 38527 38538 +11
Branches 4235 4219 -16
============================================
- Hits 20878 18356 -2522
- Misses 16654 19189 +2535
+ Partials 995 993 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [260 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.30%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.88% -13.31%
+ Complexity 4181 2907 -1274
=============================================
Files 1796 1028 -768
Lines 38527 25452 -13075
Branches 4235 2505 -1730
=============================================
- Hits 20878 10405 -10473
+ Misses 16654 14258 -2396
+ Partials 995 789 -206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `3.72%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 52.32% +3.72%
- Complexity 3500 3944 +444
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13497 +1684
+ Misses 11490 11125 -365
- Partials 1004 1175 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [225 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812311940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `23.98%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 30.35% -23.99%
+ Complexity 4198 2334 -1864
=============================================
Files 1796 998 -798
Lines 38500 24250 -14250
Branches 4241 2336 -1905
=============================================
- Hits 20922 7362 -13560
+ Misses 16586 16263 -323
+ Partials 992 625 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-57.25%)` | `0.00 <0.00> (-31.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `6.17% <0.00%> (-61.65%)` | `3.00 <0.00> (-7.00)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `0.00% <0.00%> (-95.66%)` | `0.00 <0.00> (-8.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1447 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.76%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.42% -5.77%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18681 -2197
- Misses 16654 18905 +2251
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r605679946
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -19,12 +19,16 @@
import java.lang.reflect.Method;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveResponseHolder;
+import org.springframework.http.HttpStatus;
import org.springframework.web.server.ServerWebExchange;
+import reactor.core.publisher.Mono;
Review comment:
@ascrutae InvokeInterceptor enhance `org.springframework.web.reactive.result.method.InvocableHandlerMethod`. This class only appears in the webflux package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.75%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.58% -3.76%
+ Complexity 4198 816 -3382
============================================
Files 1796 203 -1593
Lines 38500 4845 -33655
Branches 4241 549 -3692
============================================
- Hits 20922 2451 -18471
+ Misses 16586 2085 -14501
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-89.48%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1711 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.67%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.66% -2.68%
+ Complexity 4198 3911 -287
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19981 -941
- Misses 16586 17683 +1097
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [119 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `3.82%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 52.42% +3.82%
- Complexity 3500 3951 +451
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13525 +1712
+ Misses 11490 11093 -397
- Partials 1004 1179 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [224 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `7.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 41.27% -7.33%
+ Complexity 3500 3036 -464
============================================
Files 985 979 -6
Lines 24307 24059 -248
Branches 2371 2348 -23
============================================
- Hits 11813 9931 -1882
- Misses 11490 13275 +1785
+ Partials 1004 853 -151
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 204 -781
Lines 24307 4851 -19456
Branches 2371 554 -1817
============================================
- Hits 11813 0 -11813
+ Misses 11490 4851 -6639
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [971 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `8.27%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 56.87% +8.27%
+ Complexity 3500 833 -2667
============================================
Files 985 181 -804
Lines 24307 4394 -19913
Branches 2371 490 -1881
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1578 -9912
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [814 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.72%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.47% -5.73%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1797 +1
Lines 38527 38541 +14
Branches 4235 4219 -16
============================================
- Hits 20878 18681 -2197
- Misses 16654 18866 +2212
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 48.29% -0.31%
- Complexity 3500 3724 +224
============================================
Files 985 1036 +51
Lines 24307 25761 +1454
Branches 2371 2523 +152
============================================
+ Hits 11813 12441 +628
- Misses 11490 12235 +745
- Partials 1004 1085 +81
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r606662520
##########
File path: test/plugin/scenarios/springmvc-reactive-scenario/config/expectedData.yaml
##########
@@ -44,7 +73,31 @@ segmentItems:
startTime: not null
endTime: not null
componentId: 14
+ isError: false
+ tags:
+ - {key: url, value: not null}
+ - {key: http.method, value: GET}
Review comment:
@ascrutae `status_code` is recorded When `httpStatus >= 400` in spring plugins. `{GET}/testcase/error` will `record status_code=500`
```java
HttpStatus httpStatus = exchange.getResponse().getStatusCode();
if (httpStatus != null && httpStatus.isError()) {
span.errorOccurred();
Tags.STATUS_CODE.set(span, Integer.toString(httpStatus.value()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `14.53%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 39.65% -14.54%
+ Complexity 4181 2832 -1349
=============================================
Files 1796 1023 -773
Lines 38527 25393 -13134
Branches 4235 2501 -1734
=============================================
- Hits 20878 10070 -10808
+ Misses 16654 14563 -2091
+ Partials 995 760 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `12.54%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 48.59% 36.05% -12.55%
+ Complexity 3500 2641 -859
=============================================
Files 985 1005 +20
Lines 24307 24794 +487
Branches 2371 2428 +57
=============================================
- Hits 11813 8940 -2873
- Misses 11490 15159 +3669
+ Partials 1004 695 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only activate webflux plugin when not using spring mvc reactive api.
And when use webflux plugin, the trace is broken.
![image](https://user-images.githubusercontent.com/16935891/113431134-ddb45200-940d-11eb-96b3-ac7925eadc0a.png)
![image](https://user-images.githubusercontent.com/16935891/113431364-3a177180-940e-11eb-9c7c-492b5fb829b0.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `23.98%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 30.35% -23.99%
+ Complexity 4198 2334 -1864
=============================================
Files 1796 998 -798
Lines 38500 24250 -14250
Branches 4241 2336 -1905
=============================================
- Hits 20922 7362 -13560
+ Misses 16586 16263 -323
+ Partials 992 625 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-57.25%)` | `0.00 <0.00> (-31.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `6.17% <0.00%> (-61.65%)` | `3.00 <0.00> (-7.00)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `0.00% <0.00%> (-95.66%)` | `0.00 <0.00> (-8.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1447 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `14.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.12% -14.07%
+ Complexity 4181 2871 -1310
=============================================
Files 1796 1026 -770
Lines 38527 25410 -13117
Branches 4235 2501 -1734
=============================================
- Hits 20878 10196 -10682
+ Misses 16654 14445 -2209
+ Partials 995 769 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.71%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.47% -5.72%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1797 +1
Lines 38527 38539 +12
Branches 4235 4219 -16
============================================
- Hits 20878 18681 -2197
- Misses 16654 18864 +2210
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `8.90%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 45.28% -8.91%
+ Complexity 4181 2749 -1432
============================================
Files 1796 844 -952
Lines 38527 21174 -17353
Branches 4235 2028 -2207
============================================
- Hits 20878 9589 -11289
+ Misses 16654 10865 -5789
+ Partials 995 720 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 54.28% -0.06%
+ Complexity 4198 816 -3382
============================================
Files 1796 184 -1612
Lines 38500 4515 -33985
Branches 4241 515 -3726
============================================
- Hits 20922 2451 -18471
+ Misses 16586 1755 -14831
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1709 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `2.36%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head 18a3982. Consider uploading reports for the commit 18a3982 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 51.82% -2.37%
+ Complexity 4181 3874 -307
============================================
Files 1796 1798 +2
Lines 38527 38582 +55
Branches 4235 4220 -15
============================================
- Hits 20878 19996 -882
- Misses 16654 17593 +939
+ Partials 995 993 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...18a3982](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.30%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.04% -3.31%
+ Complexity 4198 3776 -422
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 13069 -7853
+ Misses 16586 11452 -5134
- Partials 992 1084 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.46%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.87% -2.47%
+ Complexity 4198 3936 -262
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20060 -862
- Misses 16586 17605 +1019
- Partials 992 1006 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `7.91%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 56.51% +7.91%
+ Complexity 3500 833 -2667
============================================
Files 985 183 -802
Lines 24307 4422 -19885
Branches 2371 492 -1879
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1606 -9884
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [812 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `4.95%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 43.64% -4.96%
+ Complexity 3500 3052 -448
============================================
Files 985 1793 +808
Lines 24307 38434 +14127
Branches 2371 4240 +1869
============================================
+ Hits 11813 16776 +4963
- Misses 11490 20656 +9166
+ Partials 1004 1002 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `54.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head 18a3982. Consider uploading reports for the commit 18a3982 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 0.00% -54.20%
============================================
Files 1796 176 -1620
Lines 38527 4326 -34201
Branches 4235 485 -3750
============================================
- Hits 20878 0 -20878
+ Misses 16654 4326 -12328
+ Partials 995 0 -995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1762 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...18a3982](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `7.91%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 40.68% -7.92%
+ Complexity 3500 2996 -504
============================================
Files 985 979 -6
Lines 24307 24028 -279
Branches 2371 2343 -28
============================================
- Hits 11813 9775 -2038
- Misses 11490 13401 +1911
+ Partials 1004 852 -152
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [154 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812838398
@ascrutae I feel that springmvc 5 plugin and webflux plugin should be two levels. Just like springmvc5 plugin and tomcat plugin. So the problem of the springmvc5 plugin that cannot collect http code should also be fixed. This issue should have nothing to do with the webflux plugin, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `22.60%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 48.59% 25.99% -22.61%
+ Complexity 3500 1983 -1517
=============================================
Files 985 1003 +18
Lines 24307 24524 +217
Branches 2371 2406 +35
=============================================
- Hits 11813 6374 -5439
- Misses 11490 17674 +6184
+ Partials 1004 476 -528
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [452 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.75%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.58% -3.76%
+ Complexity 4198 816 -3382
============================================
Files 1796 203 -1593
Lines 38500 4845 -33655
Branches 4241 549 -3692
============================================
- Hits 20922 2451 -18471
+ Misses 16586 2085 -14501
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-89.48%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1711 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `5.04%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 43.55% -5.05%
+ Complexity 3500 3036 -464
============================================
Files 985 1793 +808
Lines 24307 38432 +14125
Branches 2371 4240 +1869
============================================
+ Hits 11813 16738 +4925
- Misses 11490 20692 +9202
+ Partials 1004 1002 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only webflux plugin when not using spring mvc api
![image](https://user-images.githubusercontent.com/16935891/113428210-fb32ed00-9408-11eb-8594-bff10db672c2.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.46%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.87% -2.47%
+ Complexity 4198 3936 -262
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20060 -862
- Misses 16586 17605 +1019
- Partials 992 1006 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `6.93%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 47.40% -6.94%
+ Complexity 4198 3563 -635
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 12138 -8784
+ Misses 16586 12455 -4131
- Partials 992 1012 +20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812836844
@ascrutae Move the webflux plugin into the plugins folder and run springmvc-reactive-scenario demo, you can use my branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `2.49%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 51.69% -2.50%
+ Complexity 4181 3844 -337
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 19945 -933
- Misses 16654 17640 +986
Partials 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ascrutae commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
ascrutae commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r605667631
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -19,12 +19,16 @@
import java.lang.reflect.Method;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveResponseHolder;
+import org.springframework.http.HttpStatus;
import org.springframework.web.server.ServerWebExchange;
+import reactor.core.publisher.Mono;
Review comment:
That will woks in spring boot webflux, But I am afraid that it causes ClassNotFoundException exception if someone only uses spring web framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `11.40%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.93% -11.41%
+ Complexity 4198 3088 -1110
=============================================
Files 1796 1030 -766
Lines 38500 25587 -12913
Branches 4241 2510 -1731
=============================================
- Hits 20922 10987 -9935
+ Misses 16586 13731 -2855
+ Partials 992 869 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.74% <100.00%> (-1.50%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 208 -777
Lines 24307 4913 -19394
Branches 2371 555 -1816
============================================
- Hits 11813 0 -11813
+ Misses 11490 4913 -6577
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [969 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.75%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.58% -3.76%
+ Complexity 4198 816 -3382
============================================
Files 1796 203 -1593
Lines 38500 4845 -33655
Branches 4241 549 -3692
============================================
- Hits 20922 2451 -18471
+ Misses 16586 2085 -14501
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-89.48%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1711 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `7.14%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 47.19% -7.15%
+ Complexity 4198 3546 -652
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 12084 -8838
+ Misses 16586 12518 -4068
- Partials 992 1003 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1302 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `2.77%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 51.42% -2.78%
+ Complexity 4181 3795 -386
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 19838 -1040
- Misses 16654 17745 +1091
- Partials 995 997 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.08%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 41.10% -13.09%
+ Complexity 4181 2465 -1716
=============================================
Files 1796 813 -983
Lines 38527 20212 -18315
Branches 4235 1938 -2297
=============================================
- Hits 20878 8309 -12569
+ Misses 16654 11269 -5385
+ Partials 995 634 -361
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1419 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.46%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.87% -2.47%
+ Complexity 4198 3936 -262
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20060 -862
- Misses 16586 17605 +1019
- Partials 992 1006 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `25.50%`.
> The diff coverage is `76.92%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 28.83% -25.51%
+ Complexity 4198 2179 -2019
=============================================
Files 1796 1002 -794
Lines 38500 24714 -13786
Branches 4241 2390 -1851
=============================================
- Hits 20922 7126 -13796
- Misses 16586 17043 +457
+ Partials 992 545 -447
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `14.63% <0.00%> (-42.61%)` | `10.00 <0.00> (-21.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `13.79% <0.00%> (-54.03%)` | `4.00 <0.00> (-6.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1430 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `54.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head 18a3982. Consider uploading reports for the commit 18a3982 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 0.00% -54.20%
============================================
Files 1796 175 -1621
Lines 38527 4317 -34210
Branches 4235 484 -3751
============================================
- Hits 20878 0 -20878
+ Misses 16654 4317 -12337
+ Partials 995 0 -995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1762 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...18a3982](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `54.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 0.00% -54.35%
============================================
Files 1796 172 -1624
Lines 38500 4307 -34193
Branches 4241 498 -3743
============================================
- Hits 20922 0 -20922
+ Misses 16586 4307 -12279
+ Partials 992 0 -992
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1763 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `7.50%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 41.09% -7.51%
+ Complexity 3500 3024 -476
============================================
Files 985 979 -6
Lines 24307 24058 -249
Branches 2371 2344 -27
============================================
- Hits 11813 9887 -1926
- Misses 11490 13318 +1828
+ Partials 1004 853 -151
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.84%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.49% -3.85%
+ Complexity 4198 3779 -419
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19527 -1395
- Misses 16586 18137 +1551
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [154 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `17.70%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 36.48% -17.71%
+ Complexity 4181 2192 -1989
=============================================
Files 1796 813 -983
Lines 38527 20172 -18355
Branches 4235 1928 -2307
=============================================
- Hits 20878 7359 -13519
+ Misses 16654 12258 -4396
+ Partials 995 555 -440
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1436 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only activate webflux plugin when not using spring mvc reactive api
![image](https://user-images.githubusercontent.com/16935891/113428210-fb32ed00-9408-11eb-8594-bff10db672c2.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `10.48%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 43.70% -10.49%
+ Complexity 4181 2680 -1501
=============================================
Files 1796 844 -952
Lines 38527 21174 -17353
Branches 4235 2028 -2207
=============================================
- Hits 20878 9254 -11624
+ Misses 16654 11222 -5432
+ Partials 995 698 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1379 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ascrutae commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
ascrutae commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812824761
> @ascrutae When using springmvc reactive api, two spans will be created by mistake.
> I think we can only activate webflux plugin when not using spring mvc reactive api.
> And when use webflux plugin, the trace is broken.
> ![image](https://user-images.githubusercontent.com/16935891/113431134-ddb45200-940d-11eb-96b3-ac7925eadc0a.png)
> ![image](https://user-images.githubusercontent.com/16935891/113431364-3a177180-940e-11eb-9c7c-492b5fb829b0.png)
Could you give me a simple demo to reproduce this issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `54.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 0.00% -54.35%
============================================
Files 1796 179 -1617
Lines 38500 4451 -34049
Branches 4241 510 -3731
============================================
- Hits 20922 0 -20922
+ Misses 16586 4451 -12135
+ Partials 992 0 -992
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1763 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812836844
@ascrutae Move the webflux plugin into the plugins folder and run springmvc-reactive-scenario demo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `54.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head 18a3982. Consider uploading reports for the commit 18a3982 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 0.00% -54.20%
============================================
Files 1796 173 -1623
Lines 38527 4268 -34259
Branches 4235 480 -3755
============================================
- Hits 20878 0 -20878
+ Misses 16654 4268 -12386
+ Partials 995 0 -995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1762 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...18a3982](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.94% -13.25%
+ Complexity 4181 2907 -1274
=============================================
Files 1796 1026 -770
Lines 38527 25410 -13117
Branches 4235 2501 -1734
=============================================
- Hits 20878 10405 -10473
+ Misses 16654 14216 -2438
+ Partials 995 789 -206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.72%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.47% -5.73%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1797 +1
Lines 38527 38541 +14
Branches 4235 4219 -16
============================================
- Hits 20878 18681 -2197
- Misses 16654 18866 +2212
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `14.40%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 39.78% -14.41%
+ Complexity 4181 2843 -1338
=============================================
Files 1796 1026 -770
Lines 38527 25410 -13117
Branches 4235 2501 -1734
=============================================
- Hits 20878 10110 -10768
+ Misses 16654 14538 -2116
+ Partials 995 762 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.94%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.24% -5.95%
+ Complexity 4181 2977 -1204
============================================
Files 1796 1797 +1
Lines 38527 38539 +12
Branches 4235 4219 -16
============================================
- Hits 20878 18593 -2285
- Misses 16654 18951 +2297
Partials 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [238 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.71%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.62% -2.72%
+ Complexity 4198 3909 -289
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19965 -957
- Misses 16586 17699 +1113
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.37%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 41.96% -12.38%
+ Complexity 4198 3019 -1179
=============================================
Files 1796 1013 -783
Lines 38500 25223 -13277
Branches 4241 2459 -1782
=============================================
- Hits 20922 10585 -10337
+ Misses 16586 13801 -2785
+ Partials 992 837 -155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `2.91%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 45.68% -2.92%
+ Complexity 3500 3272 -228
============================================
Files 985 1793 +808
Lines 24307 38446 +14139
Branches 2371 4240 +1869
============================================
+ Hits 11813 17563 +5750
- Misses 11490 19885 +8395
+ Partials 1004 998 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [1249 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.45%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.45% 0.00% -48.46%
============================================
Files 985 171 -814
Lines 24307 4256 -20051
Branches 2371 480 -1891
============================================
- Hits 11777 0 -11777
+ Misses 11534 4256 -7278
+ Partials 996 0 -996
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `7.72%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 56.32% +7.72%
+ Complexity 3500 833 -2667
============================================
Files 985 186 -799
Lines 24307 4437 -19870
Branches 2371 492 -1879
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1621 -9869
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [809 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.93%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.41% -3.94%
+ Complexity 4198 3776 -422
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19495 -1427
- Misses 16586 18177 +1591
- Partials 992 999 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `11.52%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.81% -11.53%
+ Complexity 4198 3082 -1116
=============================================
Files 1796 1030 -766
Lines 38500 25587 -12913
Branches 4241 2510 -1731
=============================================
- Hits 20922 10956 -9966
+ Misses 16586 13772 -2814
+ Partials 992 859 -133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.74% <100.00%> (-1.50%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ascrutae commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
ascrutae commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812840595
You're right, the spring plugin should work single.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `14.57%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 39.76% -14.58%
+ Complexity 4198 2984 -1214
=============================================
Files 1796 999 -797
Lines 38500 24569 -13931
Branches 4241 2404 -1837
=============================================
- Hits 20922 9771 -11151
+ Misses 16586 13959 -2627
+ Partials 992 839 -153
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-57.25%)` | `0.00 <0.00> (-31.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `6.17% <0.00%> (-61.65%)` | `3.00 <0.00> (-7.00)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `0.00% <0.00%> (-95.66%)` | `0.00 <0.00> (-8.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1367 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.30%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.03% -12.31%
+ Complexity 4198 3019 -1179
=============================================
Files 1796 1011 -785
Lines 38500 25179 -13321
Branches 4241 2458 -1783
=============================================
- Hits 20922 10585 -10337
+ Misses 16586 13757 -2829
+ Partials 992 837 -155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.76%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.42% -5.77%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18681 -2197
- Misses 16654 18905 +2251
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `8.59%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 57.19% +8.59%
+ Complexity 3500 833 -2667
============================================
Files 985 178 -807
Lines 24307 4369 -19938
Branches 2371 489 -1882
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1553 -9937
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [817 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.34%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 41.99% -12.35%
+ Complexity 4198 3041 -1157
=============================================
Files 1796 1030 -766
Lines 38500 25587 -12913
Branches 4241 2510 -1731
=============================================
- Hits 20922 10746 -10176
+ Misses 16586 13994 -2592
+ Partials 992 847 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `2.36%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 51.82% -2.37%
+ Complexity 4181 3874 -307
============================================
Files 1796 1798 +2
Lines 38527 38582 +55
Branches 4235 4220 -15
============================================
- Hits 20878 19996 -882
- Misses 16654 17593 +939
+ Partials 995 993 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.76%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.42% -5.77%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18681 -2197
- Misses 16654 18905 +2251
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.76%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.42% -5.77%
+ Complexity 4181 2996 -1185
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18681 -2197
- Misses 16654 18905 +2251
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.56%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.78% -2.57%
+ Complexity 4198 3919 -279
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20024 -898
- Misses 16586 17640 +1054
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.94%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 41.39% -12.95%
+ Complexity 4198 3019 -1179
=============================================
Files 1796 1030 -766
Lines 38500 25570 -12930
Branches 4241 2509 -1732
=============================================
- Hits 20922 10585 -10337
+ Misses 16586 14148 -2438
+ Partials 992 837 -155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `14.56%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 39.63% -14.57%
+ Complexity 4181 2832 -1349
=============================================
Files 1796 1026 -770
Lines 38527 25410 -13117
Branches 4235 2501 -1734
=============================================
- Hits 20878 10070 -10808
+ Misses 16654 14580 -2074
+ Partials 995 760 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `9.51%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 44.82% -9.52%
+ Complexity 4198 3408 -790
============================================
Files 1796 1030 -766
Lines 38500 25569 -12931
Branches 4241 2504 -1737
============================================
- Hits 20922 11461 -9461
+ Misses 16586 13155 -3431
+ Partials 992 953 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `54.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 0.00% -54.35%
============================================
Files 1796 176 -1620
Lines 38500 4326 -34174
Branches 4241 485 -3756
============================================
- Hits 20922 0 -20922
+ Misses 16586 4326 -12260
+ Partials 992 0 -992
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1763 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `2.70%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 51.48% -2.71%
+ Complexity 4181 3801 -380
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 19864 -1014
- Misses 16654 17720 +1066
- Partials 995 996 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `14.15%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 40.18% -14.16%
+ Complexity 4198 3004 -1194
=============================================
Files 1796 999 -797
Lines 38500 24572 -13928
Branches 4241 2404 -1837
=============================================
- Hits 20922 9874 -11048
+ Misses 16586 13860 -2726
+ Partials 992 838 -154
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0.00% <0.00%> (-57.25%)` | `0.00 <0.00> (-31.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `6.17% <0.00%> (-61.65%)` | `3.00 <0.00> (-7.00)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `0.00% <0.00%> (-95.66%)` | `0.00 <0.00> (-8.00)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `6.34%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 47.99% -6.35%
+ Complexity 4198 3586 -612
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 12289 -8633
+ Misses 16586 12305 -4281
- Partials 992 1011 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1298 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only activate webflux plugin when not using spring mvc api
![image](https://user-images.githubusercontent.com/16935891/113428210-fb32ed00-9408-11eb-8594-bff10db672c2.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.38%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.95% -3.39%
+ Complexity 4198 3766 -432
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 13048 -7874
+ Misses 16586 11474 -5112
- Partials 992 1083 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.31%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.03% -12.32%
+ Complexity 4198 3019 -1179
=============================================
Files 1796 1012 -784
Lines 38500 25184 -13316
Branches 4241 2458 -1783
=============================================
- Hits 20922 10585 -10337
+ Misses 16586 13762 -2824
+ Partials 992 837 -155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 207 -778
Lines 24307 4909 -19398
Branches 2371 555 -1816
============================================
- Hits 11813 0 -11813
+ Misses 11490 4909 -6581
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [970 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `14.56%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 39.62% -14.57%
+ Complexity 4181 2830 -1351
=============================================
Files 1796 1023 -773
Lines 38527 25393 -13134
Branches 4235 2501 -1734
=============================================
- Hits 20878 10061 -10817
+ Misses 16654 14572 -2082
+ Partials 995 760 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `7.51%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 41.07% -7.52%
+ Complexity 3500 3021 -479
============================================
Files 985 979 -6
Lines 24307 24058 -249
Branches 2371 2344 -27
============================================
- Hits 11813 9883 -1930
- Misses 11490 13320 +1830
+ Partials 1004 855 -149
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-9.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r605658858
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -19,12 +19,16 @@
import java.lang.reflect.Method;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveResponseHolder;
+import org.springframework.http.HttpStatus;
import org.springframework.web.server.ServerWebExchange;
+import reactor.core.publisher.Mono;
Review comment:
What is this import for?
I notice you added one more dependency, is this always used in Spring classpath?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `54.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 0.00% -54.35%
============================================
Files 1796 181 -1615
Lines 38500 4463 -34037
Branches 4241 510 -3731
============================================
- Hits 20922 0 -20922
+ Misses 16586 4463 -12123
+ Partials 992 0 -992
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1763 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `8.27%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 56.87% +8.27%
+ Complexity 3500 833 -2667
============================================
Files 985 181 -804
Lines 24307 4394 -19913
Branches 2371 490 -1881
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1578 -9912
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [814 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812572691
@ascrutae When using springmvc reactive api, two spans will be created by mistake.
I think we can only activate webflux plugin when not using spring mvc reactive api.
And when use webflux plugin, the trace is broken.
![image](https://user-images.githubusercontent.com/16935891/113431134-ddb45200-940d-11eb-96b3-ac7925eadc0a.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ascrutae commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
ascrutae commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r606661636
##########
File path: test/plugin/scenarios/springmvc-reactive-scenario/config/expectedData.yaml
##########
@@ -44,7 +73,31 @@ segmentItems:
startTime: not null
endTime: not null
componentId: 14
+ isError: false
+ tags:
+ - {key: url, value: not null}
+ - {key: http.method, value: GET}
Review comment:
Does it miss the status_code tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.75%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.43% -5.76%
+ Complexity 4181 2991 -1190
============================================
Files 1796 1797 +1
Lines 38527 38539 +12
Branches 4235 4219 -16
============================================
- Hits 20878 18666 -2212
- Misses 16654 18878 +2224
Partials 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.30%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.88% -13.31%
+ Complexity 4181 2907 -1274
=============================================
Files 1796 1028 -768
Lines 38527 25452 -13075
Branches 4235 2505 -1730
=============================================
- Hits 20878 10405 -10473
+ Misses 16654 14258 -2396
+ Partials 995 789 -206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 206 -779
Lines 24307 4862 -19445
Branches 2371 554 -1817
============================================
- Hits 11813 0 -11813
+ Misses 11490 4862 -6628
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [969 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `9.61%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 44.57% -9.62%
+ Complexity 4181 2726 -1455
============================================
Files 1796 844 -952
Lines 38527 21174 -17353
Branches 4235 2028 -2207
============================================
- Hits 20878 9438 -11440
+ Misses 16654 11025 -5629
+ Partials 995 711 -284
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ascrutae commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
ascrutae commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812539334
Could you move the [webflux plugin](https://github.com/apache/skywalking/tree/master/apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plugin) into the plugins folder to resolve this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on a change in pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on a change in pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#discussion_r605697574
##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v5/InvokeInterceptor.java
##########
@@ -19,12 +19,16 @@
import java.lang.reflect.Method;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder;
import org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveResponseHolder;
+import org.springframework.http.HttpStatus;
import org.springframework.web.server.ServerWebExchange;
+import reactor.core.publisher.Mono;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `3.79%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head be26150 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.07% 51.87% +3.79%
- Complexity 3458 3936 +478
============================================
Files 982 1799 +817
Lines 24292 38671 +14379
Branches 2371 4231 +1860
============================================
+ Hits 11679 20060 +8381
- Misses 11630 17605 +5975
- Partials 983 1006 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `2.56%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 51.78% -2.57%
+ Complexity 4198 3919 -279
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 20024 -898
- Misses 16586 17640 +1054
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.40%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.93% -3.41%
+ Complexity 4198 3763 -435
============================================
Files 1796 1030 -766
Lines 38500 25605 -12895
Branches 4241 2505 -1736
============================================
- Hits 20922 13043 -7879
+ Misses 16586 11478 -5108
- Partials 992 1084 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `15.97%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 48.59% 32.62% -15.98%
+ Complexity 3500 2404 -1096
=============================================
Files 985 1004 +19
Lines 24307 24626 +319
Branches 2371 2414 +43
=============================================
- Hits 11813 8035 -3778
- Misses 11490 15969 +4479
+ Partials 1004 622 -382
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [357 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `21.14%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 33.20% -21.15%
+ Complexity 4198 2499 -1699
=============================================
Files 1796 1010 -786
Lines 38500 25077 -13423
Branches 4241 2451 -1790
=============================================
- Hits 20922 8326 -12596
+ Misses 16586 16082 -504
+ Partials 992 669 -323
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `51.56% <100.00%> (-5.68%)` | `28.00 <0.00> (-3.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1408 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `11.41%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.92% -11.42%
+ Complexity 4198 3086 -1112
=============================================
Files 1796 1030 -766
Lines 38500 25587 -12913
Branches 4241 2510 -1731
=============================================
- Hits 20922 10984 -9938
+ Misses 16586 13734 -2852
+ Partials 992 869 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.74% <100.00%> (-1.50%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `4.62%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 53.22% +4.62%
- Complexity 3500 3979 +479
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13731 +1918
+ Misses 11490 10869 -621
- Partials 1004 1197 +193
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [226 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `15.62%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 38.72% -15.63%
+ Complexity 4198 2848 -1350
=============================================
Files 1796 1011 -785
Lines 38500 25157 -13343
Branches 4241 2458 -1783
=============================================
- Hits 20922 9741 -11181
+ Misses 16586 14647 -1939
+ Partials 992 769 -223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **decrease** coverage by `48.59%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 48.59% 0.00% -48.60%
============================================
Files 985 201 -784
Lines 24307 4760 -19547
Branches 2371 543 -1828
============================================
- Hits 11813 0 -11813
+ Misses 11490 4760 -6730
+ Partials 1004 0 -1004
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [968 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `3.82%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 52.42% +3.82%
- Complexity 3500 3950 +450
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13524 +1711
+ Misses 11490 11094 -396
- Partials 1004 1179 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [225 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `5.33%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 48.85% -5.34%
+ Complexity 4181 3028 -1153
============================================
Files 1796 1798 +2
Lines 38527 38580 +53
Branches 4235 4220 -15
============================================
- Hits 20878 18848 -2030
- Misses 16654 18738 +2084
+ Partials 995 994 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [223 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `6.30%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.19% 47.88% -6.31%
+ Complexity 4181 2928 -1253
============================================
Files 1796 1797 +1
Lines 38527 38539 +12
Branches 4235 4219 -16
============================================
- Hits 20878 18453 -2425
- Misses 16654 19091 +2437
Partials 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812316066
> @wu-sheng `InvokeInterceptor` enhance `org.springframework.web.reactive.result.method.InvocableHandlerMethod`. This class only appears in the webflux package. This method will only be executed when the user uses webflux, if it is not used, it should not affect the original process.
@ascrutae Could you verify the codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `3.74%`.
> The diff coverage is `48.27%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 50.59% -3.75%
+ Complexity 4198 3783 -415
============================================
Files 1796 1799 +3
Lines 38500 38671 +171
Branches 4241 4231 -10
============================================
- Hits 20922 19565 -1357
- Misses 16586 18099 +1513
- Partials 992 1007 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/plugin/spring/mvc/v5/InvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNS54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjUvSW52b2tlSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gin/spring/mvc/commons/ReactiveResponseHolder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlc3BvbnNlSG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ugin/lettuce/v5/RedisChannelWriterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NoYW5uZWxXcml0ZXJJbnRlcmNlcHRvci5qYXZh) | `56.75% <33.33%> (-7.53%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `68.57% <73.33%> (+0.71%)` | `8.00 <1.00> (+1.00)` | |
| [...ing/apm/plugin/lettuce/v5/LettucePluginConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9MZXR0dWNlUGx1Z2luQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.79% <100.00%> (-3.45%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [152 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `9.18%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 45.16% -9.19%
+ Complexity 4198 3436 -762
============================================
Files 1796 1030 -766
Lines 38500 25569 -12931
Branches 4241 2504 -1737
============================================
- Hits 20922 11547 -9375
+ Misses 16586 13062 -3524
+ Partials 992 960 -32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1313 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `8.84%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 45.49% -8.85%
+ Complexity 4198 3454 -744
============================================
Files 1796 1030 -766
Lines 38500 25569 -12931
Branches 4241 2504 -1737
============================================
- Hits 20922 11633 -9289
+ Misses 16586 12973 -3613
+ Partials 992 963 -29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `54.35% <100.00%> (-2.89%)` | `30.00 <0.00> (-1.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1309 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `0.71%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 53.63% -0.72%
+ Complexity 4198 816 -3382
============================================
Files 1796 187 -1609
Lines 38500 4570 -33930
Branches 4241 516 -3725
============================================
- Hits 20922 2451 -18471
+ Misses 16586 1810 -14776
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1710 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812311940
@wu-sheng InvokeInterceptor enhance org.springframework.web.reactive.result.method.InvocableHandlerMethod. This class only appears in the webflux package. This method will only be executed when the user uses webflux, if it is not used, it should not affect the original process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (d83b347) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `7.77%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d83b347 differs from pull request most recent head b5cb7f2. Consider uploading reports for the commit b5cb7f2 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 56.37% +7.77%
+ Complexity 3500 833 -2667
============================================
Files 985 185 -800
Lines 24307 4433 -19874
Branches 2371 492 -1879
============================================
- Hits 11813 2499 -9314
+ Misses 11490 1617 -9873
+ Partials 1004 317 -687
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `66.66% <0.00%> (-22.23%)` | `5.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <0.00%> (-12.25%)` | `8.00% <0.00%> (-2.00%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [810 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (be26150) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be26150 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 54.34% 54.09% -0.25%
+ Complexity 4198 816 -3382
============================================
Files 1796 186 -1610
Lines 38500 4531 -33969
Branches 4241 515 -3726
============================================
- Hits 20922 2451 -18471
+ Misses 16586 1771 -14815
+ Partials 992 309 -683
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-88.10%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1709 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
liqiangz edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812836844
@ascrutae Move the webflux plugin into the plugins folder and run springmvc-reactive-scenario demo, you can use my branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (b5cb7f2) into [master](https://codecov.io/gh/apache/skywalking/commit/41bc528ae596b2b7e30000bf0c287701c63e6110?el=desc) (41bc528) will **increase** coverage by `2.39%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
============================================
+ Coverage 48.59% 50.99% +2.39%
- Complexity 3500 3872 +372
============================================
Files 985 1036 +51
Lines 24307 25797 +1490
Branches 2371 2524 +153
============================================
+ Hits 11813 13155 +1342
+ Misses 11490 11489 -1
- Partials 1004 1153 +149
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [236 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [41bc528...b5cb7f2](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (48a5e43) into [master](https://codecov.io/gh/apache/skywalking/commit/75b52917df04ad212a0b168546181ce9c879d9d8?el=desc) (75b5291) will **decrease** coverage by `12.30%`.
> The diff coverage is `88.46%`.
> :exclamation: Current head 48a5e43 differs from pull request most recent head eb309fe. Consider uploading reports for the commit eb309fe to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.34% 42.03% -12.31%
+ Complexity 4198 3047 -1151
=============================================
Files 1796 1030 -766
Lines 38500 25587 -12913
Branches 4241 2510 -1731
=============================================
- Hits 20922 10756 -10166
+ Misses 16586 13984 -2602
+ Partials 992 847 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...king/oap/server/core/storage/PersistenceTimer.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9QZXJzaXN0ZW5jZVRpbWVyLmphdmE=) | `72.72% <78.57%> (+4.87%)` | `8.00 <1.00> (+1.00)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `91.89% <100.00%> (-8.11%)` | `2.00 <0.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.05% <100.00%> (-2.19%)` | `29.00 <0.00> (-2.00)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `67.81% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...e/plugin/elasticsearch/base/BatchProcessEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9CYXRjaFByb2Nlc3NFc0RBTy5qYXZh) | `94.73% <100.00%> (-0.92%)` | `7.00 <0.00> (-1.00)` | |
| [...icsearch7/StorageModuleElasticsearch7Provider.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdQcm92aWRlci5qYXZh) | `66.23% <100.00%> (-0.44%)` | `9.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1340 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [0dd9cc1...eb309fe](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6671: Fix springmvc reactive api can't collect HTTP statusCode.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6671:
URL: https://github.com/apache/skywalking/pull/6671#issuecomment-812238036
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=h1) Report
> Merging [#6671](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=desc) (824eedb) into [master](https://codecov.io/gh/apache/skywalking/commit/b8a040ea74e3197c3f693122f8ee3a33b444ef46?el=desc) (b8a040e) will **decrease** coverage by `13.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 824eedb differs from pull request most recent head fbf2e60. Consider uploading reports for the commit fbf2e60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6671/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6671 +/- ##
=============================================
- Coverage 54.19% 40.39% -13.80%
+ Complexity 4181 2531 -1650
=============================================
Files 1796 844 -952
Lines 38527 21115 -17412
Branches 4235 2026 -2209
=============================================
- Hits 20878 8530 -12348
+ Misses 16654 11943 -4711
+ Partials 995 642 -353
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1397 more](https://codecov.io/gh/apache/skywalking/pull/6671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=footer). Last update [b8a040e...fbf2e60](https://codecov.io/gh/apache/skywalking/pull/6671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org