You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/04/13 19:18:43 UTC
Review Request 46154: GEODE-1018: Retrieve queues only once gateway
listener to avoid a race
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46154/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and nabarun nag.
Repository: geode
Description
-------
The second call to getQueues could have returned null due to a
concurrent change. By fetching the queues only once we avoid a race.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialSecondaryGatewayListener.java 5cb0ec0f4b993e76e96b68d1e5722e9b34dbba1b
Diff: https://reviews.apache.org/r/46154/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 46154: GEODE-1018: Retrieve queues only once
gateway listener to avoid a race
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46154/#review128712
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On April 13, 2016, 5:18 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46154/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 5:18 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The second call to getQueues could have returned null due to a
> concurrent change. By fetching the queues only once we avoid a race.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialSecondaryGatewayListener.java 5cb0ec0f4b993e76e96b68d1e5722e9b34dbba1b
>
> Diff: https://reviews.apache.org/r/46154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 46154: GEODE-1018: Retrieve queues only once
gateway listener to avoid a race
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46154/#review128718
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On April 13, 2016, 5:18 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46154/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 5:18 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The second call to getQueues could have returned null due to a
> concurrent change. By fetching the queues only once we avoid a race.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialSecondaryGatewayListener.java 5cb0ec0f4b993e76e96b68d1e5722e9b34dbba1b
>
> Diff: https://reviews.apache.org/r/46154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>