Re: [PR] Flink: Exclude Vintage and clean up test deps [iceberg]

["uros-b (via GitHub)" <gi...@apache.org>]

uros-b commented on code in PR #17770:
URL: https://github.com/apache/iceberg/pull/17770#discussion_r3839619189


##########
gradle/libs.versions.toml:
##########
@@ -211,6 +209,7 @@ joda-time = { module = "joda-time:joda-time", version.ref = "joda" }
 junit-jupiter = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit" }
 junit-jupiter-engine = { module = "org.junit.jupiter:junit-jupiter-engine", version.ref = "junit" }
 junit-pioneer = { module = "org.junit-pioneer:junit-pioneer", version.ref = "junit-pioneer" }
+junit-v4 = { module = "junit:junit", version.ref = "junit4" }

Review Comment:
   junit-v4 is inserted between junit-pioneer (line 213) and junit-platform-launcher (line 214), but the junit-* library block is strictly alphabetically ordered (junit-jupiter → junit-jupiter-engine → junit-pioneer → junit-platform-launcher → junit-suite-api → junit-suite-engine). Since v > s, junit-v4 should be placed after junit-suite-engine. A one-line reorder in the TOML is all that is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org