You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Mark Thomas <ma...@apache.org> on 2021/01/18 17:12:35 UTC

[VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

We have fixed a couple of bugs and a regression in 1.2.3, so I would
like to release Apache Commons Daemon 1.2.4.

Apache Commons Daemon 1.2.4 RC2 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2 (svn
revision 45480)

The Git tag commons-daemon-1.2.4-RC2 commit for this RC is
0373c020f233236ca7acf4fa4ceef31e27b7cb70 which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=0373c020f233236ca7acf4fa4ceef31e27b7cb70
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-daemon.git
--branch commons-daemon-1.2.4-RC2 commons-daemon-1.2.4-RC2

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1538/org/apache/commons/commons-daemon/1.2.4/

These are the artifacts and their hashes:

commons-daemon-1.2.4-bin-windows.zip=9c2bc010828826acbde5613aaf2de303471b33f2cb655b0ac91574e27123b8bcbe59e987d9e47d5835c171a5db31922b1458ed2e4fef840fd06c048f61f1e62b
commons-daemon-1.2.4-bin.tar.gz=66c33091fa51b6845ce45f326708419ef20ecd4a60bc175b94620a708f398843d9d53cfa8bfd2f5ab924c30b7034af602cb65e3e1cf164a5f687353f755919fe
commons-daemon-1.2.4-bin.zip=a6ced9c772dda60c1cf000a39e189bc3017030a15335d40dcd6283c5953dbaf455c86c3487fca1d672315b767c272983ec3ddc95126e9767a0fb6005ee7426d3
commons-daemon-1.2.4-javadoc.jar=5b080fa5b01ffd7868ce922c27b5bfe8ca5b30b74f9bfe5b77082c33878b5bfd87fe3e99e9be3f411b23a7136043894fea1731e2e52ea76a302f1468f2e67d09
commons-daemon-1.2.4-native-src.tar.gz=655f5b106238f6ac7f6e42dd32acfc553b302aa2c248b839528abdc9872bad5c80da3ef15399a7ff8c414427aafea9c4e9656b2887d98be4584f3926ac02ca23
commons-daemon-1.2.4-native-src.zip=6bbc7ea9ed31c71faae2f72c305ee8637827316728857abca17463d7d80c94ff9e739cbcf3fe632fdaf2ec16cacb15c1d38d5b2a316e9c124f500d620fde5136
commons-daemon-1.2.4-sources.jar=770eafc27c0a8070749ab9bb1f2c05df3449f98ce25a4e656632963d052eabcb8793f28eeb839249c1fadf8ce852c4a7bb8da8c79510823085d221b95030ed9a
commons-daemon-1.2.4-src.tar.gz=36e9cb3153ca763bfaaa71575a1584610254f1ce4c0f666ff7bbc628311405430536413525c9c777e4364eea62a247fb084750d837e84a62d9fce92a61909d56
commons-daemon-1.2.4-src.zip=c19615eeea0e471446c8159d68c708d2468cf2656637355c75d5bcd2b4f588399a6074d9bce8b2e15ba332c9d0c6f047f063f3218f0bd16771c4fdd800d6eac4


Details of changes since 1.2.3 are in the change log:

https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2/site/changes-report.html


KEYS:
  https://www.apache.org/dist/commons/KEYS


Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Mark Thomas,
Release Manager (using key 10C01C5A2F6059E7)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by Gary Gregory <ga...@gmail.com>.
+1

Building package from src zip. SHA512 ok.

Same environment for me as RC1, double checked I could build Windows
binaries.

Apache RAT check ok
JapiCmp ok

Gary

On Wed, Jan 20, 2021, 11:04 Rob Tompkins <ch...@gmail.com> wrote:

> Reviewed. All looks good.
>
> +1
>
> Cheers,
> -Rob
>
> > On Jan 20, 2021, at 10:52 AM, Mark Thomas <ma...@apache.org> wrote:
> >
> > On 18/01/2021 17:12, Mark Thomas wrote:
> >> We have fixed a couple of bugs and a regression in 1.2.3, so I would
> >> like to release Apache Commons Daemon 1.2.4.
> >
> > <snip/>
> >
> >> Please review the release candidate and vote.
> >> This vote will close no sooner that 72 hours from now.
> >>
> >>  [X] +1 Release these artifacts
> >
> > Mark
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by Rob Tompkins <ch...@gmail.com>.
Reviewed. All looks good.

+1

Cheers,
-Rob

> On Jan 20, 2021, at 10:52 AM, Mark Thomas <ma...@apache.org> wrote:
> 
> On 18/01/2021 17:12, Mark Thomas wrote:
>> We have fixed a couple of bugs and a regression in 1.2.3, so I would
>> like to release Apache Commons Daemon 1.2.4.
> 
> <snip/>
> 
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>> 
>>  [X] +1 Release these artifacts
> 
> Mark
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by Mark Thomas <ma...@apache.org>.
On 18/01/2021 17:12, Mark Thomas wrote:
> We have fixed a couple of bugs and a regression in 1.2.3, so I would
> like to release Apache Commons Daemon 1.2.4.

<snip/>

> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
> 
>   [X] +1 Release these artifacts

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE][RESULT] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by Mark Thomas <ma...@apache.org>.
The following votes were cast:

Binding:
+1: kinow, markt, chtompki, ggregory

No other votes were cast. The vote therefore passes.

Thanks to everyone who contributed toward this release.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by Mark Thomas <ma...@apache.org>.
On 19/01/2021 03:30, Bruno P. Kinoshita wrote:
>  [x] +1 Release these artifacts
> 
> Building OK from the tag, with Ubuntu LTS + Java 8, Maven 3.5.4.
> 
> Minor notes:
> - "Maven artifacts are here", the URL is 404 for me, I logged in to repository.apache.org, and copied the link:
> OK = 
> https://repository.apache.org/content/repositories/orgapachecommons-1538/commons-daemon/commons-daemon/1.2.4/
> 
> BROKEN = 
> https://repository.apache.org/content/repositories/orgapachecommons-1538/org/apache/commons/commons-daemon/1.2.4/
> 
> I think the groupId is the issue? Checked signatures, they match with the one used for source folder in dist area.
> 
> 
> - "Details of changes since 1.2.3 are in the change log" the change log link is broken, but I generated the site locally, and it looks OK. The dist area site folder has only the apidocs I think? Not a blocker IMO

Thanks for the review.

I'll take a look at the various link issues. The Commons Release plug-in
makes various assumptions that aren't true for Daemon. I've worked
around some of them and edited others out of the generated vote text. I
obviously missed some. I'll add some more detailed notes to
HOW-TO-RELEASE.txt for next time.

Cheers,

Mark


> 
> Cheers
> Bruno
> 
> p.s.: I checked the NOTICE file because the commit message said 2012, but it has the correct years now :)
> 
> 
>     On Tuesday, 19 January 2021, 6:12:41 am NZDT, Mark Thomas <ma...@apache.org> wrote:  
>  
>  We have fixed a couple of bugs and a regression in 1.2.3, so I would
> like to release Apache Commons Daemon 1.2.4.
> 
> Apache Commons Daemon 1.2.4 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2 (svn
> revision 45480)
> 
> The Git tag commons-daemon-1.2.4-RC2 commit for this RC is
> 0373c020f233236ca7acf4fa4ceef31e27b7cb70 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=0373c020f233236ca7acf4fa4ceef31e27b7cb70
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-daemon.git
> --branch commons-daemon-1.2.4-RC2 commons-daemon-1.2.4-RC2
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1538/org/apache/commons/commons-daemon/1.2.4/
> 
> These are the artifacts and their hashes:
> 
> commons-daemon-1.2.4-bin-windows.zip=9c2bc010828826acbde5613aaf2de303471b33f2cb655b0ac91574e27123b8bcbe59e987d9e47d5835c171a5db31922b1458ed2e4fef840fd06c048f61f1e62b
> commons-daemon-1.2.4-bin.tar.gz=66c33091fa51b6845ce45f326708419ef20ecd4a60bc175b94620a708f398843d9d53cfa8bfd2f5ab924c30b7034af602cb65e3e1cf164a5f687353f755919fe
> commons-daemon-1.2.4-bin.zip=a6ced9c772dda60c1cf000a39e189bc3017030a15335d40dcd6283c5953dbaf455c86c3487fca1d672315b767c272983ec3ddc95126e9767a0fb6005ee7426d3
> commons-daemon-1.2.4-javadoc.jar=5b080fa5b01ffd7868ce922c27b5bfe8ca5b30b74f9bfe5b77082c33878b5bfd87fe3e99e9be3f411b23a7136043894fea1731e2e52ea76a302f1468f2e67d09
> commons-daemon-1.2.4-native-src.tar.gz=655f5b106238f6ac7f6e42dd32acfc553b302aa2c248b839528abdc9872bad5c80da3ef15399a7ff8c414427aafea9c4e9656b2887d98be4584f3926ac02ca23
> commons-daemon-1.2.4-native-src.zip=6bbc7ea9ed31c71faae2f72c305ee8637827316728857abca17463d7d80c94ff9e739cbcf3fe632fdaf2ec16cacb15c1d38d5b2a316e9c124f500d620fde5136
> commons-daemon-1.2.4-sources.jar=770eafc27c0a8070749ab9bb1f2c05df3449f98ce25a4e656632963d052eabcb8793f28eeb839249c1fadf8ce852c4a7bb8da8c79510823085d221b95030ed9a
> commons-daemon-1.2.4-src.tar.gz=36e9cb3153ca763bfaaa71575a1584610254f1ce4c0f666ff7bbc628311405430536413525c9c777e4364eea62a247fb084750d837e84a62d9fce92a61909d56
> commons-daemon-1.2.4-src.zip=c19615eeea0e471446c8159d68c708d2468cf2656637355c75d5bcd2b4f588399a6074d9bce8b2e15ba332c9d0c6f047f063f3218f0bd16771c4fdd800d6eac4
> 
> 
> Details of changes since 1.2.3 are in the change log:
> 
> https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2/site/changes-report.html
> 
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Mark Thomas,
> Release Manager (using key 10C01C5A2F6059E7)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
>   
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons Daemon 1.2.4 based on RC2

Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
 [x] +1 Release these artifacts

Building OK from the tag, with Ubuntu LTS + Java 8, Maven 3.5.4.

Minor notes:
- "Maven artifacts are here", the URL is 404 for me, I logged in to repository.apache.org, and copied the link:
OK = 
https://repository.apache.org/content/repositories/orgapachecommons-1538/commons-daemon/commons-daemon/1.2.4/

BROKEN = 
https://repository.apache.org/content/repositories/orgapachecommons-1538/org/apache/commons/commons-daemon/1.2.4/

I think the groupId is the issue? Checked signatures, they match with the one used for source folder in dist area.


- "Details of changes since 1.2.3 are in the change log" the change log link is broken, but I generated the site locally, and it looks OK. The dist area site folder has only the apidocs I think? Not a blocker IMO

Cheers
Bruno

p.s.: I checked the NOTICE file because the commit message said 2012, but it has the correct years now :)


    On Tuesday, 19 January 2021, 6:12:41 am NZDT, Mark Thomas <ma...@apache.org> wrote:  
 
 We have fixed a couple of bugs and a regression in 1.2.3, so I would
like to release Apache Commons Daemon 1.2.4.

Apache Commons Daemon 1.2.4 RC2 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2 (svn
revision 45480)

The Git tag commons-daemon-1.2.4-RC2 commit for this RC is
0373c020f233236ca7acf4fa4ceef31e27b7cb70 which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=0373c020f233236ca7acf4fa4ceef31e27b7cb70
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-daemon.git
--branch commons-daemon-1.2.4-RC2 commons-daemon-1.2.4-RC2

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1538/org/apache/commons/commons-daemon/1.2.4/

These are the artifacts and their hashes:

commons-daemon-1.2.4-bin-windows.zip=9c2bc010828826acbde5613aaf2de303471b33f2cb655b0ac91574e27123b8bcbe59e987d9e47d5835c171a5db31922b1458ed2e4fef840fd06c048f61f1e62b
commons-daemon-1.2.4-bin.tar.gz=66c33091fa51b6845ce45f326708419ef20ecd4a60bc175b94620a708f398843d9d53cfa8bfd2f5ab924c30b7034af602cb65e3e1cf164a5f687353f755919fe
commons-daemon-1.2.4-bin.zip=a6ced9c772dda60c1cf000a39e189bc3017030a15335d40dcd6283c5953dbaf455c86c3487fca1d672315b767c272983ec3ddc95126e9767a0fb6005ee7426d3
commons-daemon-1.2.4-javadoc.jar=5b080fa5b01ffd7868ce922c27b5bfe8ca5b30b74f9bfe5b77082c33878b5bfd87fe3e99e9be3f411b23a7136043894fea1731e2e52ea76a302f1468f2e67d09
commons-daemon-1.2.4-native-src.tar.gz=655f5b106238f6ac7f6e42dd32acfc553b302aa2c248b839528abdc9872bad5c80da3ef15399a7ff8c414427aafea9c4e9656b2887d98be4584f3926ac02ca23
commons-daemon-1.2.4-native-src.zip=6bbc7ea9ed31c71faae2f72c305ee8637827316728857abca17463d7d80c94ff9e739cbcf3fe632fdaf2ec16cacb15c1d38d5b2a316e9c124f500d620fde5136
commons-daemon-1.2.4-sources.jar=770eafc27c0a8070749ab9bb1f2c05df3449f98ce25a4e656632963d052eabcb8793f28eeb839249c1fadf8ce852c4a7bb8da8c79510823085d221b95030ed9a
commons-daemon-1.2.4-src.tar.gz=36e9cb3153ca763bfaaa71575a1584610254f1ce4c0f666ff7bbc628311405430536413525c9c777e4364eea62a247fb084750d837e84a62d9fce92a61909d56
commons-daemon-1.2.4-src.zip=c19615eeea0e471446c8159d68c708d2468cf2656637355c75d5bcd2b4f588399a6074d9bce8b2e15ba332c9d0c6f047f063f3218f0bd16771c4fdd800d6eac4


Details of changes since 1.2.3 are in the change log:

https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC2/site/changes-report.html


KEYS:
  https://www.apache.org/dist/commons/KEYS


Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Mark Thomas,
Release Manager (using key 10C01C5A2F6059E7)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org