You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2014/07/14 06:48:16 UTC
git commit: HBASE-11499 AsyncProcess.buildDetailedErrorMessage
concatenates strings using + in a loop (Mike Drob)
Repository: hbase
Updated Branches:
refs/heads/master fc5736340 -> a6fd48ba1
HBASE-11499 AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop (Mike Drob)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a6fd48ba
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a6fd48ba
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a6fd48ba
Branch: refs/heads/master
Commit: a6fd48ba12e0f82b3ea937227845a63e5c1f8bf7
Parents: fc57363
Author: stack <st...@apache.org>
Authored: Sun Jul 13 21:48:06 2014 -0700
Committer: stack <st...@apache.org>
Committed: Sun Jul 13 21:48:06 2014 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/client/AsyncProcess.java | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/a6fd48ba/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
index c184147..d1bcc0b 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
@@ -1407,23 +1407,24 @@ class AsyncProcess {
}
private String buildDetailedErrorMsg(String string, int index) {
- String error = string + "; called for " + index +
- ", actionsInProgress " + actionsInProgress.get() + "; replica gets: ";
+ StringBuilder error = new StringBuilder(128);
+ error.append(string).append("; called for ").append(index).append(", actionsInProgress ")
+ .append(actionsInProgress.get()).append("; replica gets: ");
if (replicaGetIndices != null) {
for (int i = 0; i < replicaGetIndices.length; ++i) {
- error += replicaGetIndices[i] + ", ";
+ error.append(replicaGetIndices[i]).append(", ");
}
} else {
- error += (hasAnyReplicaGets ? "all" : "none");
+ error.append(hasAnyReplicaGets ? "all" : "none");
}
- error += "; results ";
+ error.append("; results ");
if (results != null) {
for (int i = 0; i < results.length; ++i) {
Object o = results[i];
- error += ((o == null) ? "null" : o.toString()) + ", ";
+ error.append(((o == null) ? "null" : o.toString())).append(", ");
}
}
- return error;
+ return error.toString();
}
@Override