You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Patrick Wendell (JIRA)" <ji...@apache.org> on 2014/09/16 01:12:34 UTC

[jira] [Resolved] (SPARK-3518) Remove useless statement in JsonProtocol

     [ https://issues.apache.org/jira/browse/SPARK-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Wendell resolved SPARK-3518.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.2.0
                   1.1.1
         Assignee: Kousuke Saruta

Fixed by:
https://github.com/apache/spark/pull/2380

> Remove useless statement in JsonProtocol
> ----------------------------------------
>
>                 Key: SPARK-3518
>                 URL: https://issues.apache.org/jira/browse/SPARK-3518
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 1.2.0
>            Reporter: Kousuke Saruta
>            Assignee: Kousuke Saruta
>            Priority: Minor
>             Fix For: 1.1.1, 1.2.0
>
>
> In org.apache.spark.util.JsonProtocol#taskInfoToJson, a variable named "accumUpdateMap" is created as follows.
> {code}
> val accumUpdateMap = taskInfo.accumulables
> {code}
> But accumUpdateMap is never used and there is 2nd invocation of "taskInfo.accumlables" as follows.
> {code}
> ("Accumulables" -> JArray(taskInfo.accumulables.map(accumulableInfoToJson).toList))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org