SHINDIG-1809 and Uri encoding/decoding

[Stanton Sievers <ss...@us.ibm.com>]

Hi everyone,

I was looking at SHINDIG-1809 [1] and why 
DefaultJsUriManager.processExternJsUri(Uri) is not decoding "%3A", i.e. 
':', when parsing the libs from the Uri's path.  After digging a bit I 
noticed that neither Uri nor UriBuilder in Shindig seem to do any 
decoding.  In fact, org.apache.shindig.common.uri.Uri.fromJavaUri(URI) 
calls UriBuilder with the raw components from the java.net.URI and not the 
decoded ones.

Anyone know why this is the case?  Why use the java.net.URI.getRaw* 
methods instead of using the getters that decode the pieces?

Thanks,
-Stanton

[1] https://issues.apache.org/jira/browse/SHINDIG-1809

Re: SHINDIG-1809 and Uri encoding/decoding

[Henry Saputra <he...@gmail.com>]

Hmm looks like the code has not been updated for a while. My guess is
that the server code assume that the iframe and JS URIs will be
generated by Shindig with the non encoded format so there is no need
to decode the incoming URLs

But looks like a bug to me.

- Henry

On Mon, Jun 25, 2012 at 5:24 AM, Stanton Sievers <ss...@us.ibm.com> wrote:
> Hi everyone,
>
> I was looking at SHINDIG-1809 [1] and why
> DefaultJsUriManager.processExternJsUri(Uri) is not decoding "%3A", i.e.
> ':', when parsing the libs from the Uri's path.  After digging a bit I
> noticed that neither Uri nor UriBuilder in Shindig seem to do any
> decoding.  In fact, org.apache.shindig.common.uri.Uri.fromJavaUri(URI)
> calls UriBuilder with the raw components from the java.net.URI and not the
> decoded ones.
>
> Anyone know why this is the case?  Why use the java.net.URI.getRaw*
> methods instead of using the getters that decode the pieces?
>
> Thanks,
> -Stanton
>
> [1] https://issues.apache.org/jira/browse/SHINDIG-1809