[GitHub] [hive] rkirtir commented on a diff in pull request #4098: HIVE-27122: Use Caffeine for caching metadata objects in Compactor threads

["rkirtir (via GitHub)" <gi...@apache.org>]

rkirtir commented on code in PR #4098:
URL: https://github.com/apache/hive/pull/4098#discussion_r1127580345


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/TaskHandler.java:
##########
@@ -58,12 +55,7 @@ public abstract class TaskHandler {
   public abstract List<Runnable> getTasks() throws MetaException;
 
   protected Table resolveTable(String dbName, String tableName) throws MetaException {
-    try {
-      return getMSForConf(conf).getTable(getDefaultCatalog(conf), dbName, tableName);
-    } catch (MetaException e) {
-      LOG.error("Unable to find table {}.{}, {}", dbName, tableName, e.getMessage());
-      throw e;
-    }
+    return CompactorUtil.resolveTable(conf, dbName, tableName);

Review Comment:
   How about calling CompactorUtil.resolveTable(conf, dbName, tableName) from initiator directly. 
   does taskhandler responsible for all caffein cache related
    tasks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org